kenjreno/esphome-ratgdo
1
0
Fork 0
mirror of https://github.com/ratgdo/esphome-ratgdo.git synced 2025-03-03 04:19:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't require two messages to update state, some GDOs throttle replies when door is closed

Browse Source
This commit is contained in:
Marius Muja 2024-01-12 10:09:12 -08:00
parent 9e2bebc3f0
commit 56795f591e
1 changed files with 7 additions and 17 deletions

24
components/ratgdo/secplus1.cpp

@ -210,7 +210,7 @@ namespace secplus1 {
// if we have a partial packet and it's been over 100ms since last byte was read, // if we have a partial packet and it's been over 100ms since last byte was read,
// the rest is not coming (a full packet should be received in ~20ms), // the rest is not coming (a full packet should be received in ~20ms),
// discard it so we can read the following packet correctly // discard it so we can read the following packet correctly
ESP_LOGW(TAG, "[%d] Discard incomplete packet, [%02X ...]", millis(), rx_packet[0]); ESP_LOGW(TAG, "[%d] Discard incomplete packet: [%02X ...]", millis(), rx_packet[0]);
reading_msg = false; reading_msg = false;
byte_count = 0; byte_count = 0;
} }
@ -264,30 +264,20 @@ namespace secplus1 {
door_state = DoorState::UNKNOWN; door_state = DoorState::UNKNOWN;
} }
if (this->door_state != door_state) { this->door_state = door_state;
this->prev_door_state = this->door_state; this->ratgdo_->received(door_state);
this->door_state = door_state;
} else {
this->ratgdo_->received(door_state);
}
} }
else if (cmd.type == CommandType::DOOR_STATUS_37) { else if (cmd.type == CommandType::DOOR_STATUS_37) {
// inject door status request // inject door status request
this->sw_serial_.write(0x38); this->sw_serial_.write(0x38);
} else if (cmd.type == CommandType::OTHER_STATUS) { } else if (cmd.type == CommandType::OTHER_STATUS) {
LightState light_state = to_LightState((cmd.value >> 2) & 1, LightState::UNKNOWN); LightState light_state = to_LightState((cmd.value >> 2) & 1, LightState::UNKNOWN);
if (this->light_state != light_state) { this->light_state = light_state;
this->light_state = light_state; this->ratgdo_->received(light_state);
} else {
this->ratgdo_->received(light_state);
}
LockState lock_state = to_LockState((~cmd.value >> 3) & 1, LockState::UNKNOWN); LockState lock_state = to_LockState((~cmd.value >> 3) & 1, LockState::UNKNOWN);
if (this->lock_state != lock_state) { this->lock_state = lock_state;
this->lock_state = lock_state; this->ratgdo_->received(lock_state);
} else {
this->ratgdo_->received(lock_state);
}
} }
else if (cmd.type == CommandType::OBSTRUCTION) { else if (cmd.type == CommandType::OBSTRUCTION) {
ObstructionState obstruction_state = cmd.value == 0 ? ObstructionState::CLEAR : ObstructionState::OBSTRUCTED; ObstructionState obstruction_state = cmd.value == 0 ? ObstructionState::CLEAR : ObstructionState::OBSTRUCTED;