kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-11-04 05:15:42 +00:00
Code Issues Projects Releases Wiki Activity

Respect maxNumberOfDays regardless of endpoint

Browse Source
This commit is contained in:
Reagan Elm
2018-02-10 20:53:38 -05:00
parent 20eec53b14
commit 3d1741c904
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/default/weatherforecast/weatherforecast.js
View File

@@ -259,7 +259,6 @@ Module.register("weatherforecast",{
if (self.config.forecastEndpoint == "forecast/daily") { if (self.config.forecastEndpoint == "forecast/daily") {
self.config.forecastEndpoint = "forecast"; self.config.forecastEndpoint = "forecast";
self.config.maxNumberOfDays = self.config.maxNumberOfDays * 8;
Log.warn(self.name + ": Your AppID does not support long term forecasts. Switching to fallback endpoint."); Log.warn(self.name + ": Your AppID does not support long term forecasts. Switching to fallback endpoint.");
} }
@@ -298,12 +297,6 @@ Module.register("weatherforecast",{
params += "&units=" + this.config.units; params += "&units=" + this.config.units;
params += "&lang=" + this.config.lang; params += "&lang=" + this.config.lang;
/*
* Submit a specific number of days to forecast, between 1 to 16 days.
* The OpenWeatherMap API properly handles values outside of the 1 - 16 range and returns 7 days by default.
* This is simply being pedantic and doing it ourselves.
*/
params += "&cnt=" + (((this.config.maxNumberOfDays < 1) || (this.config.maxNumberOfDays > 16)) ? 7 * 8 : this.config.maxNumberOfDays);
params += "&APPID=" + this.config.appid; params += "&APPID=" + this.config.appid;
return params; return params;
@@ -354,6 +347,11 @@ Module.register("weatherforecast",{
this.forecast.push(forecastData); this.forecast.push(forecastData);
lastDay = day; lastDay = day;
// Stop processing when maxNumberOfDays is reached
if (this.forecast.length === this.config.maxNumberOfDays) {
break;
}
} else { } else {
//Log.log("Compare max: ", forecast.temp.max, parseFloat(forecastData.maxTemp)); //Log.log("Compare max: ", forecast.temp.max, parseFloat(forecastData.maxTemp));
forecastData.maxTemp = forecast.temp.max > parseFloat(forecastData.maxTemp) ? this.roundValue(forecast.temp.max) : forecastData.maxTemp; forecastData.maxTemp = forecast.temp.max > parseFloat(forecastData.maxTemp) ? this.roundValue(forecast.temp.max) : forecastData.maxTemp;