mirror of https://github.com/MichMich/MagicMirror.git synced 2026-06-13 14:25:46 +00:00

Files

Kristjan ESPERANTO 5d11b5d73b fix: modules losing data after HTTP 304 responses (#4180 )

When a server responds with 304 (nothing changed since last fetch), the
response has no body. Several modules were trying to parse that empty
body anyway - which either cleared their cached data or threw an
exception. The result: a blank calendar, empty newsfeed, or missing
weather data after the next refresh cycle.

This was reported in the forum:
https://forum.magicmirror.builders/topic/20250/calendar-events-broadcasting-nothing-showing

The bug was "introduced" by #4120, which correctly started forwarding
304s to consumers - but not all were ready for it.

### Fix

Skip parsing on 304 and keep the existing data as-is:

- **calendar** - re-broadcasts cached events
- **newsfeed** - re-broadcasts cached items
- **buienradar, openmeteo, weatherflow, weathergov** - return early
before calling `response.json()`

2026-06-06 20:05:05 +02:00

buienradar.js

fix: modules losing data after HTTP 304 responses (#4180 )

2026-06-06 20:05:05 +02:00

envcanada.js

fix: modules losing data after HTTP 304 responses (#4180 )

2026-06-06 20:05:05 +02:00

openmeteo.js

fix: modules losing data after HTTP 304 responses (#4180 )

2026-06-06 20:05:05 +02:00

openweathermap.js

fix: modules losing data after HTTP 304 responses (#4180 )