kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-09 11:28:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

chan_sip: sip_subscribe_mwi_destroy should not call sip_destroy

Browse Source 
sip_subscribe_mwi_destroy calls sip_destroy on the reference counted
mwi->call.  This results in the fields of mwi->call being freed, but
mwi->call itself it leaked.  If other code is still using mwi->call
it can cause problems.  This change uses dialog_unref instead, to
balance the ref provided by sip_alloc().

ASTERISK-24087 #close
Reported by: Corey Farrell
Review: https://reviewboard.asterisk.org/r/3834/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@419440 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Corey Farrell
2014-07-24 17:55:48 +00:00
parent 94afd8c438
commit 0789fefda6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
channels/chan_sip.c
View File

@@ -6108,9 +6108,9 @@ static void sip_subscribe_mwi_destroy(struct sip_subscription_mwi *mwi)
{ {
if (mwi->call) { if (mwi->call) {
mwi->call->mwi = NULL; mwi->call->mwi = NULL;
sip_destroy(mwi->call); mwi->call = dialog_unref(mwi->call, "sip_subscription_mwi destruction");
} }
AST_SCHED_DEL(sched, mwi->resub); AST_SCHED_DEL(sched, mwi->resub);
ast_string_field_free_memory(mwi); ast_string_field_free_memory(mwi);
ast_free(mwi); ast_free(mwi);