mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-25 06:00:36 +00:00
ari: User better nicknames for ARI operations
While working on building client libraries from the Swagger API, I
noticed a problem with the nicknames.
channel.deleteChannel()
channel.answerChannel()
channel.muteChannel()
Etc. We put the object name in the nickname (since we were generating C
code), but it makes OO generators redundant.
This patch makes the nicknames more OO friendly. This resulted in a lot
of name changing within the res_ari_*.so modules, but not much else.
There were a couple of other fixed I made in the process.
* When reversible operations (POST /hold, POST /unhold) were made more
RESTful (POST /hold, DELETE /unhold), the path for the second operation
was left in the API declaration. This worked, but really the two
operations should have been on the same API.
* The POST /unmute operation had still not been REST-ified.
Review: https://reviewboard.asterisk.org/r/2940/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@402528 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -631,6 +631,11 @@ class ApiDeclaration(Stringify):
|
||||
api_json = api_decl_json.get('apis') or []
|
||||
self.apis = [
|
||||
Api().load(j, processor, context) for j in api_json]
|
||||
paths = set()
|
||||
for api in self.apis:
|
||||
if api.path in paths:
|
||||
raise SwaggerError("API with duplicated path: %s" % api.path, context)
|
||||
paths.add(api.path)
|
||||
self.has_websocket = filter(lambda api: api.has_websocket,
|
||||
self.apis) == []
|
||||
models = api_decl_json.get('models').items() or []
|
||||
|
||||
Reference in New Issue
Block a user