formatting fixes (bug #4736)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6162 65c4cc65-6c06-0410-ace0-fbb531ad65f3

pbx.c

@@ -226,9 +226,7 @@ static struct pbx_builtin {
 } builtins[] = 
 {
 	/* These applications are built into the PBX core and do not
-	   need separate modules
+	   need separate modules */
-	   
-	    */
 
 	{ "AbsoluteTimeout", pbx_builtin_atimeout,
 	"Set absolute maximum time of call",
@@ -763,7 +761,6 @@ static int matchcid(const char *cidpattern, const char *callerid)
 	/* If the Caller*ID pattern is empty, then we're matching NO Caller*ID, so
 	   failing to get a number should count as a match, otherwise not */
 
-
 	if (!ast_strlen_zero(cidpattern))
 		failresult = 0;
 	else
@@ -939,15 +936,15 @@ void pbx_retrieve_variable(struct ast_channel *c, const char *var, char **ret, c
 
 		if (abs(offset) > strlen(*ret)) {	/* Offset beyond string */
 			if (offset >= 0) 
-				offset=strlen(*ret);
+				offset = strlen(*ret);
 			else 
-				offset=-strlen(*ret);	
+				offset =- strlen(*ret);	
 		}
 		if ((offset < 0 && offset2 > -offset) || (offset >= 0 && offset+offset2 > strlen(*ret))) {
 			if (offset >= 0) 
-				offset2=strlen(*ret)-offset;
+				offset2 = strlen(*ret)-offset;
 			else 
-				offset2=strlen(*ret)+offset;
+				offset2 = strlen(*ret)+offset;
 		}
 		if (offset >= 0)
 			*ret += offset;
@@ -1113,7 +1110,7 @@ icky:
 				ast_log(LOG_WARNING,"Comparing variable '%s' with '%s'\n",var,ast_var_name(variables));
 #endif
 				if (strcasecmp(ast_var_name(variables),var)==0) {
-					*ret=ast_var_value(variables);
+					*ret = ast_var_value(variables);
 					if (*ret) {
 						ast_copy_string(workspace, *ret, workspacelen);
 						*ret = workspace;
@@ -1281,7 +1278,7 @@ int ast_custom_function_register(struct ast_custom_function *acf)
 
 	/* try to lock functions list ... */
 	if (ast_mutex_lock(&acflock)) {
-		ast_log(LOG_ERROR, "Unable to lock function list\n");
+		ast_log(LOG_ERROR, "Unable to lock function list. Failed registering function %s\n", acf->name);
 		return -1;
 	}
 
@@ -1309,7 +1306,10 @@ char *ast_func_read(struct ast_channel *chan, const char *in, char *workspace, s
 	struct ast_custom_function *acfptr;
 
 	function = ast_strdupa(in);
-	if (function) {
+	if (!function) {
+		ast_log(LOG_ERROR, "Out of memory\n");
+		return ret;
+	}
 	if ((args = strchr(function, '('))) {
 		*args = '\0';
 		args++;
@@ -1332,9 +1332,6 @@ char *ast_func_read(struct ast_channel *chan, const char *in, char *workspace, s
 	} else {
 		ast_log(LOG_ERROR, "Function %s not registered\n", function);
 	}
-	} else {
-		ast_log(LOG_ERROR, "Out of memory\n");
-	}
 	return ret;
 }
 
@@ -1344,7 +1341,10 @@ void ast_func_write(struct ast_channel *chan, const char *in, const char *value)
 	struct ast_custom_function *acfptr;
 
 	function = ast_strdupa(in);
-	if (function) {
+	if (!function) {
+		ast_log(LOG_ERROR, "Out of memory\n");
+		return;
+	}
 	if ((args = strchr(function, '('))) {
 		*args = '\0';
 		args++;
@@ -1362,14 +1362,11 @@ void ast_func_write(struct ast_channel *chan, const char *in, const char *value)
 		if (acfptr->write) {
 			acfptr->write(chan, function, args, value);
 		} else {
-				ast_log(LOG_ERROR, "Function %s cannot be written to\n", function);
+			ast_log(LOG_ERROR, "Function %s is read-only, it cannot be written to\n", function);
 		}
 	} else {
 		ast_log(LOG_ERROR, "Function %s not registered\n", function);
 	}
-	} else {
-		ast_log(LOG_ERROR, "Out of memory\n");
-	}
 }
 
 static void pbx_substitute_variables_helper_full(struct ast_channel *c, const char *cp1, char *cp2, int count, struct varshead *headp)
@@ -1443,7 +1440,7 @@ static void pbx_substitute_variables_helper_full(struct ast_channel *c, const ch
 			len = vare - vars - 1;
 
 			/* Skip totally over variable name */
-			whereweare += ( len + 3);
+			whereweare += (len + 3);
 
 			/* Store variable name (and truncate) */
 			memset(var, 0, sizeof(var));
@@ -3113,7 +3110,7 @@ static int handle_show_applications(int fd, int argc, char *argv[])
 				/* Match all words on command line */
 				int i;
 				printapp = 1;
-				for (i=3;i<argc;i++) {
+				for (i=3; i<argc; i++) {
 					if (!strcasestr(a->description, argv[i])) {
 						printapp = 0;
 					} else {
@@ -3668,10 +3665,10 @@ static void get_timerange(struct ast_timing *i, char *times)
 	/* Do the last one */
 	i->minmask[x/30] |= (1 << (x % 30));
 #else
-	for (cth=0;cth<24;cth++) {
+	for (cth=0; cth<24; cth++) {
 		/* Initialize masks to blank */
 		i->minmask[cth] = 0;
-		for (ctm=0;ctm<30;ctm++) {
+		for (ctm=0; ctm<30; ctm++) {
 			if (
 			/* First hour with more than one hour */
 			      (((cth == s1) && (ctm >= s2)) &&
@@ -3789,7 +3786,7 @@ static unsigned int get_day(char *day)
 	} else
 		e = s;
 	mask = 0;
-	for (x=s;x!=e;x = (x + 1) % 31) {
+	for (x=s; x!=e; x = (x + 1) % 31) {
 		mask |= (1 << x);
 	}
 	mask |= (1 << x);