kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-09 11:28:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up and ensure proper usage of alloca()

Browse Source 
This replaces all calls to alloca() with ast_alloca() which calls gcc's
__builtin_alloca() to avoid BSD semantics and removes all NULL checks
on memory allocated via ast_alloca() and ast_strdupa().

(closes issue ASTERISK-20125)
Review: https://reviewboard.asterisk.org/r/2032/
Patch-by: Walter Doekes (wdoekes)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@370642 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Kinsey Moore
2012-07-31 19:31:42 +00:00
parent 80efa31733
commit 377caa7fb1
58 changed files with 296 additions and 370 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
main/utils.c
View File

@@ -1023,7 +1023,7 @@ int ast_pthread_create_stack(pthread_t *thread, pthread_attr_t *attr, void *(*st
#endif
if (!attr) {
attr = alloca(sizeof(*attr));
attr = ast_alloca(sizeof(*attr));
pthread_attr_init(attr);
}
@@ -1071,7 +1071,7 @@ int ast_pthread_create_detached_stack(pthread_t *thread, pthread_attr_t *attr, v
int res;
if (!attr) {
attr = alloca(sizeof(*attr));
attr = ast_alloca(sizeof(*attr));
pthread_attr_init(attr);
attr_destroy = 1;
}
@@ -1935,7 +1935,7 @@ int ast_mkdir(const char *path, int mode)
int len = strlen(path), count = 0, x, piececount = 0;
char *tmp = ast_strdupa(path);
char **pieces;
char *fullpath = alloca(len + 1);
char *fullpath = ast_alloca(len + 1);
int res = 0;
for (ptr = tmp; *ptr; ptr++) {
@@ -1944,7 +1944,7 @@ int ast_mkdir(const char *path, int mode)
}
/* Count the components to the directory path */
pieces = alloca(count * sizeof(*pieces));
pieces = ast_alloca(count * sizeof(*pieces));
for (ptr = tmp; *ptr; ptr++) {
if (*ptr == '/') {
*ptr = '\0';