kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-15 14:28:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix XML encoding of 'identity display' in NOTIFY messages, continued.

Browse Source 
When r378933 was merged into 1.8, it should have also escaped
remote_display, since it will have the same XML encoding problem when
the caller/callee roles are reversed.

(closes issue ABE-2902)
Reported by: Guenther Kelleter


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@379001 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
David M. Lee
2013-01-14 15:11:39 +00:00
parent 89e5288798
commit 37f037f444
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
channels/chan_sip.c
View File

@@ -13116,8 +13116,8 @@ static void state_notify_build_xml(int state, int full, const char *exten, const
if ((state & AST_EXTENSION_RINGING) && sip_cfg.notifyringing) { if ((state & AST_EXTENSION_RINGING) && sip_cfg.notifyringing) {
/* Twice the extension length should be enough for XML encoding */ /* Twice the extension length should be enough for XML encoding */
char local_display[AST_MAX_EXTENSION * 2]; char local_display[AST_MAX_EXTENSION * 2];
char remote_display[AST_MAX_EXTENSION * 2];
char *local_target = ast_strdupa(mto); char *local_target = ast_strdupa(mto);
const char *remote_display = exten;
/* It may seem odd to base the remote_target on the To header here, /* It may seem odd to base the remote_target on the To header here,
* but testing by reporters on issue ASTERISK-16735 found that basing * but testing by reporters on issue ASTERISK-16735 found that basing
* on the From header would cause ringing state hints to not work * on the From header would cause ringing state hints to not work
@@ -13129,6 +13129,7 @@ static void state_notify_build_xml(int state, int full, const char *exten, const
char *remote_target = ast_strdupa(mto); char *remote_target = ast_strdupa(mto);
ast_xml_escape(exten, local_display, sizeof(local_display)); ast_xml_escape(exten, local_display, sizeof(local_display));
ast_xml_escape(exten, remote_display, sizeof(remote_display));
/* There are some limitations to how this works. The primary one is that the /* There are some limitations to how this works. The primary one is that the
callee must be dialing the same extension that is being monitored. Simply dialing callee must be dialing the same extension that is being monitored. Simply dialing
@@ -13148,8 +13149,9 @@ static void state_notify_build_xml(int state, int full, const char *exten, const
remote_target = ast_alloca(need); remote_target = ast_alloca(need);
snprintf(remote_target, need, "sip:%s@%s", cid_num, p->fromdomain); snprintf(remote_target, need, "sip:%s@%s", cid_num, p->fromdomain);
remote_display = ast_strdupa(S_COR(caller->caller.id.name.valid, ast_xml_escape(S_COR(caller->caller.id.name.valid,
caller->caller.id.name.str, "")); caller->caller.id.name.str, ""),
remote_display, sizeof(remote_display));
connected_num = S_COR(caller->connected.id.number.valid, connected_num = S_COR(caller->connected.id.number.valid,
caller->connected.id.number.str, ""); caller->connected.id.number.str, "");