kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-31 10:47:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

ARI - implement allowMultiple for parameters

Browse Source 
Swagger allows parameters to be specified as 'allowMultiple', meaning
that the parameter may be specified as a comma separated list of
values.

I had written some of the API docs using that, but promptly forgot
about implementing it. This patch finally fills in that gap.

The codegen template was updated to represent 'allowMultiple' fields
as array/size fields in the _args structs. It also parses the comma
separated list using ast_app_separate_args(), so quoted strings in the
argument will be handled properly.

Review: https://reviewboard.asterisk.org/r/2698/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@396122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
David M. Lee
2013-08-02 14:36:32 +00:00
parent 10c91bc96e
commit 537ecebd2d
22 changed files with 682 additions and 192 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
rest-api-templates/param_parsing.mustache
View File

@@ -18,15 +18,48 @@
{{!
* Snippet for decoding parameters into an _args struct.
}}
struct ast_{{c_nickname}}_args args = {};
{{#has_parameters}}
struct ast_variable *i;
{{#has_query_parameters}}
for (i = get_params; i; i = i->next) {
{{#query_parameters}}
if (strcmp(i->name, "{{name}}") == 0) {
{{^allow_multiple}}
args.{{c_name}} = {{c_convert}}(i->value);
{{/allow_multiple}}
{{#allow_multiple}}
/* Parse comma separated list */
char *vals[MAX_VALS];
size_t j;
args.{{c_name}}_parse = ast_strdup(i->value);
if (!args.{{c_name}}_parse) {
ast_ari_response_alloc_failed(response);
goto fin;
}
args.{{c_name}}_count = ast_app_separate_args(
args.{{c_name}}_parse, ',', vals, ARRAY_LEN(vals));
if (args.{{c_name}}_count == 0) {
ast_ari_response_alloc_failed(response);
goto fin;
}
if (args.{{c_name}}_count >= MAX_VALS) {
ast_ari_response_error(response, 400,
"Bad Request",
"Too many values for {{c_name}}");
goto fin;
}
args.{{c_name}} = ast_malloc(sizeof(*args.{{c_name}}) * args.{{c_name}}_count);
if (!args.{{c_name}}) {
ast_ari_response_alloc_failed(response);
goto fin;
}
for (j = 0; j < args.{{c_name}}_count; ++j) {
args.{{c_name}}[j] = {{c_convert}}(vals[j]);
}
{{/allow_multiple}}
} else
{{/query_parameters}}
{}
@@ -42,4 +75,3 @@
{}
}
{{/has_path_parameters}}
{{/has_parameters}}