Merge "res_pjsip_t38.c: Be smarter about how we respond when T.38 is disabled."

This commit is contained in:
Joshua Colp
2018-07-10 07:21:45 -05:00
committed by Gerrit Code Review

View File

@@ -507,21 +507,42 @@ static struct ast_frame *t38_framehook(struct ast_channel *chan, struct ast_fram
return f; return f;
} }
if (f->frametype == AST_FRAME_CONTROL && f->subclass.integer == AST_CONTROL_T38_PARAMETERS) { if (f->frametype == AST_FRAME_CONTROL
&& f->subclass.integer == AST_CONTROL_T38_PARAMETERS) {
if (channel->session->endpoint->media.t38.enabled) { if (channel->session->endpoint->media.t38.enabled) {
struct t38_parameters_task_data *data = t38_parameters_task_data_alloc(channel->session, f); struct t38_parameters_task_data *data;
if (!data) { data = t38_parameters_task_data_alloc(channel->session, f);
return f; if (data
} && ast_sip_push_task(channel->session->serializer,
t38_interpret_parameters, data)) {
if (ast_sip_push_task(channel->session->serializer, t38_interpret_parameters, data)) {
ao2_ref(data, -1); ao2_ref(data, -1);
} }
} else { } else {
struct ast_control_t38_parameters parameters = { .request_response = AST_T38_REFUSED, }; static const struct ast_control_t38_parameters rsp_refused = {
ast_debug(2, "T.38 support not enabled, rejecting T.38 control packet\n"); .request_response = AST_T38_REFUSED,
ast_queue_control_data(chan, AST_CONTROL_T38_PARAMETERS, &parameters, sizeof(parameters)); };
static const struct ast_control_t38_parameters rsp_terminated = {
.request_response = AST_T38_TERMINATED,
};
const struct ast_control_t38_parameters *parameters = f->data.ptr;
switch (parameters->request_response) {
case AST_T38_REQUEST_NEGOTIATE:
ast_debug(2, "T.38 support not enabled on %s, refusing T.38 negotiation\n",
ast_channel_name(chan));
ast_queue_control_data(chan, AST_CONTROL_T38_PARAMETERS,
&rsp_refused, sizeof(rsp_refused));
break;
case AST_T38_REQUEST_TERMINATE:
ast_debug(2, "T.38 support not enabled on %s, 'terminating' T.38 session\n",
ast_channel_name(chan));
ast_queue_control_data(chan, AST_CONTROL_T38_PARAMETERS,
&rsp_terminated, sizeof(rsp_terminated));
break;
default:
break;
}
} }
} }