mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-24 13:50:08 +00:00
ari: User better nicknames for ARI operations
While working on building client libraries from the Swagger API, I
noticed a problem with the nicknames.
channel.deleteChannel()
channel.answerChannel()
channel.muteChannel()
Etc. We put the object name in the nickname (since we were generating C
code), but it makes OO generators redundant.
This patch makes the nicknames more OO friendly. This resulted in a lot
of name changing within the res_ari_*.so modules, but not much else.
There were a couple of other fixed I made in the process.
* When reversible operations (POST /hold, POST /unhold) were made more
RESTful (POST /hold, DELETE /unhold), the path for the second operation
was left in the API declaration. This worked, but really the two
operations should have been on the same API.
* The POST /unmute operation had still not been REST-ified.
Review: https://reviewboard.asterisk.org/r/2940/
........
Merged revisions 402528 from http://svn.asterisk.org/svn/asterisk/branches/12
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@402529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -157,6 +157,7 @@ class AsteriskProcessor(SwaggerPostProcessor):
|
||||
# Now in all caps, for include guard
|
||||
resource_api.name_caps = resource_api.name.upper()
|
||||
resource_api.name_title = resource_api.name.capitalize()
|
||||
resource_api.c_name = snakify(resource_api.name)
|
||||
# Construct the PathSegement tree for the API.
|
||||
if resource_api.api_declaration:
|
||||
resource_api.root_path = PathSegment('', None)
|
||||
@@ -182,7 +183,7 @@ class AsteriskProcessor(SwaggerPostProcessor):
|
||||
api.wiki_path = wikify(api.path)
|
||||
|
||||
def process_operation(self, operation, context):
|
||||
# Nicknames are camelcase, Asterisk coding is snake case
|
||||
# Nicknames are camelCase, Asterisk coding is snake case
|
||||
operation.c_nickname = snakify(operation.nickname)
|
||||
operation.c_http_method = 'AST_HTTP_' + operation.http_method
|
||||
if not operation.summary.endswith("."):
|
||||
|
||||
Reference in New Issue
Block a user