From 8184532a9ffc7bbd19bfdf4dd3d7bc65e85c426c Mon Sep 17 00:00:00 2001 From: George Joseph Date: Thu, 19 Jun 2014 15:59:45 +0000 Subject: [PATCH] Remove the problematic and unneeded AST_MODFLAG_GLOBAL_SYMBOLS from pbx_lua.c AST_MODFLAG_GLOBAL_SYMBOLS was causing the module to be incorrectly loaded before pbx_config. pbx_config was therefore blowing away contexts that were created by pbx_lua. With AST_MODFLAG_DEFAULT the load order is now correct and contexs are being properly merged. AST_MODFLAG_GLOBAL_SYMBOLS was not needed anyway since no other modules needed its global symbols that early. ASTERISK-23818 #close Reported by: Dennis Guse Tested by: Dennis Guse Tested by: George Joseph Review: https://reviewboard.asterisk.org/r/3629/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@416667 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- pbx/pbx_lua.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pbx/pbx_lua.c b/pbx/pbx_lua.c index ee6dc7c864..33155f0a84 100644 --- a/pbx/pbx_lua.c +++ b/pbx/pbx_lua.c @@ -1526,6 +1526,9 @@ static int load_or_reload_lua_stuff(void) res = AST_MODULE_LOAD_DECLINE; } + if (!res) { + ast_log(LOG_NOTICE, "Lua PBX Switch loaded.\n"); + } lua_close(L); return res; } @@ -1535,6 +1538,7 @@ static int unload_module(void) ast_context_destroy(NULL, registrar); ast_unregister_switch(&lua_switch); lua_free_extensions(); + ast_log(LOG_NOTICE, "Lua PBX Switch unloaded.\n"); return 0; } @@ -1558,7 +1562,7 @@ static int load_module(void) return AST_MODULE_LOAD_SUCCESS; } -AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_GLOBAL_SYMBOLS, "Lua PBX Switch", +AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_DEFAULT, "Lua PBX Switch", .load = load_module, .unload = unload_module, .reload = reload,