kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-09 19:38:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Coverity Report: Fix issues for error type UNINIT in Core supported modules

Browse Source 
(issue ASTERISK-19652)
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/1909/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@366048 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Jonathan Rose
2012-05-10 15:35:33 +00:00
parent 50b43947f1
commit a7650f8002
5 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/app_chanspy.c
View File

@@ -1250,6 +1250,7 @@ static int extenspy_exec(struct ast_channel *chan, const char *data)
} }
} else { } else {
/* Coverity - This uninit_use should be ignored since this macro initializes the flags */
ast_clear_flag(&flags, AST_FLAGS_ALL); ast_clear_flag(&flags, AST_FLAGS_ALL);
} }
@@ -1294,6 +1295,7 @@ static int dahdiscan_exec(struct ast_channel *chan, const char *data)
int res; int res;
char *mygroup = NULL; char *mygroup = NULL;
/* Coverity - This uninit_use should be ignored since this macro initializes the flags */
ast_clear_flag(&flags, AST_FLAGS_ALL); ast_clear_flag(&flags, AST_FLAGS_ALL);
if (!ast_strlen_zero(data)) { if (!ast_strlen_zero(data)) {

7
apps/app_disa.c
View File

@@ -181,8 +181,13 @@ static int disa_exec(struct ast_channel *chan, const char *data)
args.context = "disa"; args.context = "disa";
if (ast_strlen_zero(args.mailbox)) if (ast_strlen_zero(args.mailbox))
args.mailbox = ""; args.mailbox = "";
if (!ast_strlen_zero(args.options)) if (!ast_strlen_zero(args.options)) {
ast_app_parse_options(app_opts, &flags, NULL, args.options); ast_app_parse_options(app_opts, &flags, NULL, args.options);
} else {
/* Coverity - This uninit_use should be ignored since this macro initializes the flags */
ast_clear_flag(&flags, AST_FLAGS_ALL);
}
ast_debug(1, "Mailbox: %s\n",args.mailbox); ast_debug(1, "Mailbox: %s\n",args.mailbox);

5
apps/app_page.c
View File

@@ -177,6 +177,11 @@ static int page_exec(struct ast_channel *chan, const char *data)
if (!ast_strlen_zero(args.options)) { if (!ast_strlen_zero(args.options)) {
ast_app_parse_options(page_opts, &flags, opts, args.options); ast_app_parse_options(page_opts, &flags, opts, args.options);
} else {
/* opts must be initialized if there wasn't an options string. */
for (i = 0; i < OPT_ARG_ARRAY_SIZE; i++) {
opts[i] = NULL;
}
} }
if (!ast_strlen_zero(args.timeout)) { if (!ast_strlen_zero(args.timeout)) {

2
funcs/func_cdr.c
View File

@@ -197,7 +197,7 @@ AST_APP_OPTIONS(cdr_func_options, {
static int cdr_read(struct ast_channel *chan, const char *cmd, char *parse, static int cdr_read(struct ast_channel *chan, const char *cmd, char *parse,
char *buf, size_t len) char *buf, size_t len)
{ {
char *ret; char *ret = NULL;
struct ast_flags flags = { 0 }; struct ast_flags flags = { 0 };
struct ast_cdr *cdr; struct ast_cdr *cdr;
AST_DECLARE_APP_ARGS(args, AST_DECLARE_APP_ARGS(args,

2
main/features.c
View File

@@ -3345,9 +3345,11 @@ static int feature_interpret(struct ast_channel *chan, struct ast_channel *peer,
struct ast_flags features; struct ast_flags features;
struct ast_call_feature feature; struct ast_call_feature feature;
if (sense == FEATURE_SENSE_CHAN) { if (sense == FEATURE_SENSE_CHAN) {
/* Coverity - This uninit_use should be ignored since this macro initializes the flags */
ast_copy_flags(&features, &(config->features_caller), AST_FLAGS_ALL); ast_copy_flags(&features, &(config->features_caller), AST_FLAGS_ALL);
} }
else { else {
/* Coverity - This uninit_use should be ignored since this macro initializes the flags */
ast_copy_flags(&features, &(config->features_callee), AST_FLAGS_ALL); ast_copy_flags(&features, &(config->features_callee), AST_FLAGS_ALL);
} }