mirror of
https://github.com/asterisk/asterisk.git
synced 2026-06-09 03:45:27 +00:00
fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@153337 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -144,10 +144,14 @@ static void fdprintf(int fd, char *fmt, ...)
|
||||
{
|
||||
char stuff[4096];
|
||||
va_list ap;
|
||||
int res;
|
||||
|
||||
va_start(ap, fmt);
|
||||
vsnprintf(stuff, sizeof(stuff), fmt, ap);
|
||||
va_end(ap);
|
||||
write(fd, stuff, strlen(stuff));
|
||||
if ((res = write(fd, stuff, strlen(stuff))) < 0) {
|
||||
fprintf(stderr, "write() failed: %s\n", strerror(errno));
|
||||
}
|
||||
}
|
||||
|
||||
static char *get_header(struct message *m, char *var)
|
||||
@@ -398,13 +402,16 @@ static int manager_action(char *action, char *fmt, ...)
|
||||
struct ast_mansession *s;
|
||||
char tmp[4096];
|
||||
va_list ap;
|
||||
int res;
|
||||
|
||||
s = &session;
|
||||
fdprintf(s->fd, "Action: %s\r\n", action);
|
||||
va_start(ap, fmt);
|
||||
vsnprintf(tmp, sizeof(tmp), fmt, ap);
|
||||
va_end(ap);
|
||||
write(s->fd, tmp, strlen(tmp));
|
||||
if ((res = write(s->fd, tmp, strlen(tmp))) < 0) {
|
||||
fprintf(stderr, "write() failed: %s\n", strerror(errno));
|
||||
}
|
||||
fdprintf(s->fd, "\r\n");
|
||||
return 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user