kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-15 14:28:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory stomping bug in astman.

Browse Source 
This memset complained in dev mod on my Ubuntu box. The memset is both
unnecessary and dangerous. At this point, m hasn't been initialized
yet, so the memset will write off to whatever address happens to be
on the stack at the time.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@409077 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
David M. Lee
2014-02-27 16:23:11 +00:00
parent a6a92ffe3d
commit b695da6510
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
utils/astman.c
View File

@@ -738,7 +738,6 @@ static int manager_login(char *hostname)
show_message("Login Failed", get_header(m, "Message")); show_message("Login Failed", get_header(m, "Message"));
} }
} else { } else {
memset(m, 0, sizeof(m));
manager_action("Login", manager_action("Login",
"Username: %s\r\n" "Username: %s\r\n"
"Secret: %s\r\n", "Secret: %s\r\n",