mirror of
https://github.com/asterisk/asterisk.git
synced 2025-11-08 19:08:14 +00:00
apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
@@ -202,8 +202,7 @@ int ast_db_get(const char *family, const char *keys, char *value, int valuelen)
|
||||
if (data.size) {
|
||||
((char *)data.data)[data.size - 1] = '\0';
|
||||
/* Make sure that we don't write too much to the dst pointer or we don't read too much from the source pointer */
|
||||
strncpy(value, data.data, (valuelen > data.size) ? data.size : valuelen);
|
||||
value[valuelen - 1] = '\0';
|
||||
ast_copy_string(value, data.data, (valuelen > data.size) ? data.size : valuelen);
|
||||
} else {
|
||||
ast_log(LOG_NOTICE, "Strange, empty value for /%s/%s\n", family, keys);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user