kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-11-14 05:48:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

chan_sip: Don't crash in Dial on invalid destination

Browse Source 
Stripping the DNID in a SIP dial string can result in attempting to call
the argument parsing macros on an empty string, causing a crash.

ASTERISK-26131 #close
Reported by: Dwayne Hubbard
Patches:
	dw-asterisk-master-dnid-crash.patch (license #6257) patch
	uploaded by Dwayne Hubbard

Change-Id: Ib84c1f740a9ec0539d582b09d847fc85ddca1c5e
This commit is contained in:
Sean Bright
2017-12-12 16:19:09 -05:00
parent 0384e49a6e
commit d22bccef95
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
channels/chan_sip.c
View File

@@ -30554,6 +30554,14 @@ static struct ast_channel *sip_request_call(const char *type, struct ast_format_
} }
} }
/* If stripping the DNID left us with nothing, bail out */
if (ast_strlen_zero(tmp)) {
dialog_unlink_all(p);
dialog_unref(p, "unref dialog p from bad destination");
*cause = AST_CAUSE_DESTINATION_OUT_OF_ORDER;
return NULL;
}
/* Divvy up the items separated by slashes */ /* Divvy up the items separated by slashes */
AST_NONSTANDARD_APP_ARGS(args, tmp, '/'); AST_NONSTANDARD_APP_ARGS(args, tmp, '/');