Commit Graph

322 Commits

Author SHA1 Message Date
Mark Michelson
049fb8d98e The diff on this looks pretty big but all I did was remove a pointless if statement (always evaluates true).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75978 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-19 18:59:30 +00:00
Mark Michelson
1f9e2457dd Changes in handling return values of several functions in app_queue. This all started as a fix for issue #10008
but now includes all of the following changes:

1. Simplifying the code to handle positive return values from ast API calls.
2. Removing the background_file function.
3. The fix for issue #10008

(closes issue #10008, reported and patched by dimas)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75969 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-19 16:26:10 +00:00
Dwayne M. Hubbard
226a627244 Merged revisions 75657 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75657 | dhubbard | 2007-07-18 12:48:33 -0500 (Wed, 18 Jul 2007) | 1 line

removed the word 'pissed' from ast_log(...) function call for BE-90
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75658 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-18 17:56:30 +00:00
Jason Parker
05923bb562 Merged revisions 74427 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74427 | qwell | 2007-07-10 14:57:20 -0500 (Tue, 10 Jul 2007) | 6 lines

Fix an issue where it was possible to have a service level of over 100%
Between the time recalc_holdtime and update_queue was called, it was possible that the call could have been hungup.
Move both additions to the same place, so this won't happen.

Issue 10158, initial patch by makoto, modified by me.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 19:58:53 +00:00
Mark Michelson
5112357ae1 Forgot to get rid of an extraneous debug message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 18:38:28 +00:00
Mark Michelson
591f77fe14 The n option for Queue should make the queue exit immediately after failure to reach any members and should not
be dependent on the timeout value passed to Queue

(closes issue #10127, reported by bcnit, repaired by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74120 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 18:32:50 +00:00
Mark Michelson
60c9f69f20 Correcting a minor CLI bug I found. When issuing the queue show command, if you type
queue show and then press tab, you can continue pressing tab and it will keep auto-completing
queue names even though only 1 queue can be used as an argument.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73400 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-05 15:59:41 +00:00
Joshua Colp
6fec0a545f Merged revisions 73315 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r73315 | file | 2007-07-05 10:19:17 -0300 (Thu, 05 Jul 2007) | 2 lines

Reset ServicelevelPerf variable back to 0 if we are unable to calculate it each time... otherwise we will get previous values. (issue #10117 reported by noriyuki)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73316 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-05 13:22:13 +00:00
Joshua Colp
2c67ae6869 Merged revisions 72327 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r72327 | file | 2007-06-27 18:43:11 -0400 (Wed, 27 Jun 2007) | 2 lines

Fix issue where queue log events might be missing. (issue #7765 reported by mtryfoss)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@72328 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 22:45:49 +00:00
Russell Bryant
e7cb53e8b2 Fix loading persistent queue members when using realtime configuration for queues.
Also, remove an unneeded leading slash for the astdb family.
(issue #9911, patch by atis)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 21:16:07 +00:00
Russell Bryant
ece55e3de7 Merged revisions 65389 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r65389 | russell | 2007-05-22 08:07:03 -0500 (Tue, 22 May 2007) | 4 lines

Fix a memory leak that I just noticed in the device state handling in app_queue.
On most device state changes, it would leak roughly 8 to 64 bytes (the length of
the name of the device).

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-22 13:09:34 +00:00
Russell Bryant
88f6591b24 Fix a small bug I noticed while working on something else. app_queue did not
unregister its device state monitoring callback in unload_module().  So, this
would make Asterisk crash on the first device state change after you 
unload the module.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64868 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-18 02:48:51 +00:00
Jason Parker
15d34ea798 Merged revisions 61692 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r61692 | qwell | 2007-04-20 14:49:54 -0500 (Fri, 20 Apr 2007) | 5 lines

If the '* to hangup' option is not enabled, we don't need to disable * as a valid exit key.
  If it was enabled, this statement would've never been checked in the first place.

Issue #9552

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61694 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-20 19:51:49 +00:00
Jason Parker
7a8d30f3c3 Use the appropriate interface name with COMPLETECALLER.
Issue 9395.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61022 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 19:05:48 +00:00
Joshua Colp
acd37793b1 Allow app_queue to use MONITOR_EXEC even if MONITOR_OPTIONS is not set. (issue #9495 reported by cduffy)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60762 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-08 17:04:44 +00:00
Joshua Colp
7cec18d933 Add missing membername option to AddQueueMember documentation. (issue #9088 reported by seanbright)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55219 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-17 17:39:32 +00:00
Joshua Colp
fccaadad94 Make the 'i' option of Queue actually work. (issue #8986 reported by utis)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-17 02:59:50 +00:00
BJ Weschke
c71401e705 I'm baaaaaaaaaack. :)
Post a warning to the console that things might possibly be misconfigured when queue member's states are still 'Not in Use' when we're about to bridge them with a caller from queue. Also, put some documentation quoted from oej's queues.txt efforts started in /trunk today. 
 This commit puts #7433 into feedback state for 1.4, and pending no further negative feedback, it will finally be closed.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-02 21:26:45 +00:00
Olle Johansson
10f0da24c2 Change debug level for state change message that is not really informative when debugging app_queue
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53081 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-01 20:38:58 +00:00
Russell Bryant
9aab046002 Merged revisions 53045 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r53045 | russell | 2007-01-31 15:25:11 -0600 (Wed, 31 Jan 2007) | 3 lines

Fix a bunch of places where pthread_attr_init() was called, but
pthread_attr_destroy() was not.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53046 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 21:32:08 +00:00
Russell Bryant
ad254da05d Only changed the paused status in an existing queue member if the paused
column exists.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53037 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 17:39:28 +00:00
Russell Bryant
8dc0a7778f Instead of always creating a realtime queue member as unpaused, read the
"paused" column and use that value for the paused status of the member.
(issue #8949, jmls)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 17:34:22 +00:00
Joshua Colp
47f9dd508a Merged revisions 52415 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r52415 | file | 2007-01-26 21:09:10 -0500 (Fri, 26 Jan 2007) | 2 lines

Make COMPLETECALLER and COMPLETEAGENT output to queue_log follow documentation. (issue #7677 reported by amilcar)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52416 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-27 02:13:41 +00:00
Kevin P. Fleming
444adcb477 reduce stack consumption for AMI and AMI/HTTP requests by nearly 20K in most cases
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:16:33 +00:00
Kevin P. Fleming
cb2930ecb4 if adding a queue member is LOG_NOTICE, then removing them should be LOG_NOTICE, not LOG_DEBUG
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 16:36:49 +00:00
Kevin P. Fleming
88fb11d10b reflect addition/removal of dynamic queue members in queue_log, so that people using dialplan replacement for AgentCallbackLogin can still track login/logout (issue #7736, reported/patched by whoiswes but this commit was written by me and covers all three paths for AQM/RQM)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47432 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 16:34:04 +00:00
Tilghman Lesher
56a1e60c54 More changes making the CLI more consistent with "category verb arguments" (continuation of issue 8236)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 23:49:13 +00:00
Tilghman Lesher
e05a2752e8 Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 23:00:20 +00:00
Russell Bryant
28d9579584 update warning message to include "agi" option (issue #8225, jmls)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 19:08:18 +00:00
Kevin P. Fleming
ce4b0afb73 apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 14:32:08 +00:00
Kevin P. Fleming
ff05bf15c8 update thread creation code a bit
reduce standard thread stack size slightly to allow the pthreads library to allocate the stack+data and not overflow a power-of-2 allocation in the kernel and waste memory/address space
add a new stack size for 'background' threads (those that don't handle PBX calls) when LOW_MEMORY is defined


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-04 19:47:22 +00:00
Kevin P. Fleming
b4a673780a Merged revisions 44296 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r44296 | kpfleming | 2006-10-03 15:14:13 -0500 (Tue, 03 Oct 2006) | 2 lines

fix a logic error in my previous fix to the queue reload code

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 20:18:29 +00:00
Jason Parker
4be96dc8d3 Fix incorrect argument order for member names, on persisted members.
Issue 8047, patch by jmls.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43944 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 20:11:22 +00:00
Kevin P. Fleming
78e8232ef8 Merged revisions 43916 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r43916 | kpfleming | 2006-09-28 12:31:57 -0500 (Thu, 28 Sep 2006) | 2 lines

fix buggy (and overly complex) loop used during reload of app_queue for static member list updating

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43919 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 17:35:42 +00:00
BJ Weschke
1dd8d10aa9 Merged revisions 43897 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r43897 | bweschke | 2006-09-28 12:37:15 -0400 (Thu, 28 Sep 2006) | 3 lines

 app_queue is comparing the device names incorrectly while checking their statuses. It's internal list of interfaces includes the dial string, while the argument passed to this function does not have the dial string (/n for a local channel). This causes it to ignore the device state changes because it thinks it belongs to none of its members. (#8040 reported and patch by tim_ringenbach)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43899 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:41:05 +00:00
BJ Weschke
675749c706 Merged revisions 43871 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r43871 | bweschke | 2006-09-28 11:18:05 -0400 (Thu, 28 Sep 2006) | 3 lines

 Fix race condion crash with get_member_status (#7864 - tim_ringenbach reported and patched)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43873 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 15:29:21 +00:00
BJ Weschke
669bbb6784 Autopause not working for queue members. (#8042 - jmls reported and patch)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 13:24:10 +00:00
Tilghman Lesher
70af28270d Constify the result of a config retrieval function, to avoid mutilation (issue 7983).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43364 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 20:40:39 +00:00
Jason Parker
61e4465f49 Fix a segfault that was reported by jcmoore in #asterisk-bugs on IRC.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43357 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 19:46:18 +00:00
Jason Parker
50c1981780 We need to persist the member name also
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43322 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 06:14:05 +00:00
Jason Parker
a7119b522d Add a "member name" to queue members.
Add option to the various methods of adding a queue member, to add the "member name".

Member name is used in (most) queue log records, in place of the interface name.
This makes it consistent, so that you can log in from any device, and still be logged as "member name"


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43316 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 05:59:53 +00:00
Matt O'Gorman
d0a1a0033d similar patch for verbose vs debug with minor changes
bug 2617


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43272 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 16:23:45 +00:00
Kevin P. Fleming
fcb999c01c merge qwell's CLI verbification work
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 19:54:18 +00:00
BJ Weschke
c5c1d4579f This was added to app_dial a while back, and now it's in app_queue as well. Provide an option to prevent members of the queue from forwarding calls from the queue to somewhere else.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41901 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 19:32:51 +00:00
BJ Weschke
06b98dcc77 Merged revisions 41882 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r41882 | bweschke | 2006-09-03 13:38:22 -0400 (Sun, 03 Sep 2006) | 3 lines

 Make sure the forwarded channel inherits variables appropriately when we receive a call forward in the queue. (#7867 - raarts reported and patched)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:40:08 +00:00
BJ Weschke
91f4aa93bb Don't keep trying the same member in certain strategies when members of the queue are unavailable (#7278 - diLLec reported and patched)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41879 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:12:30 +00:00
BJ Weschke
b6ccca7566 Merged revisions 41827 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r41827 | bweschke | 2006-09-03 10:16:08 -0400 (Sun, 03 Sep 2006) | 3 lines

 Setting a retry of 0 is generally not a good idea and shouldn't be allowed. (#7574 - reported by regin)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41829 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:28:25 +00:00
BJ Weschke
e736c8a27b With the somewhat recent addition (from one of the Astridevcon Europe sessions) of more detailed device states, we need to change strategy in app_queue in how we determine whether a queue member is "in use" or not. Basically, instead of specifically looking for that device state as we did previously, now we're going to observe any other device state aside from the two that we know for sure are "not in use" as "in use". This will cause some other states to fall through that we know will never be available (eg - "INVALID","UNAVAILABLE",etc) but there's other code already within to handle those conditions. (#7433 - tgrman reporting)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41810 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-02 18:36:53 +00:00
Matt O'Gorman
05a695af72 everything that loads a config that needs a config file to run
now reports AST_MODULE_LOAD_DECLINE when loading if config file
is not there, also fixed an error in res_config_pgsql where it 
had a non static function when it should.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41633 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 21:00:20 +00:00
Kevin P. Fleming
0a27d8bfe5 merge new_loader_completion branch, including (at least):
- restructured build tree and makefiles to eliminate recursion problems
  - support for embedded modules
  - support for static builds
  - simpler cross-compilation support
  - simpler module/loader interface (no exported symbols)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-21 02:11:39 +00:00