Commit Graph

2774 Commits

Author SHA1 Message Date
Jeff Peeler
4e6d8d2774 Do not play goodbye prompt after timeout of message review.
ABE-2124


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@259664 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-04-28 17:13:29 +00:00
Jeff Peeler
5c5677868d Fix looping forever when no input received in certain voicemail menu scenarios.
Specifically, prompting for an extension (when leaving or forwarding a message)
or when prompting for a digit (when saving a message or changing folders).

ABE-2122
SWP-1268


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@258432 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-04-21 21:45:36 +00:00
Jeff Peeler
4af3d8699b Play correct prompt when voicemail store failure occurs after attempted forward.
If a user's mailbox was full and a message was attempted to be forwarded to
said box, warnings on the console would indicate failure. However, the played
prompt was that of success (vm-msgsaved). Now storage failure is taken into
account and the correct prompt (vm-mailboxfull) is played when appropriate.

ABE-2123
SWP-1262



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@258029 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-04-20 16:16:33 +00:00
Jeff Peeler
f5b5f848be make app_voicemail compile with IMAP_STORAGE
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@257856 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-04-19 19:09:46 +00:00
Dwayne M. Hubbard
4f19fa6fd0 Make the mixmonitor thread process audio frames faster
Mantis issue 17078 reports MixMonitor recordings have shorter durations than 
the call duration.  This was because the mixmonitor thread was not processing 
frames from the audiohook fast enough.  The mixmonitor thread would slowly fall 
behind the most recent audio frame and when the channel hangs up, the mixmonitor 
thread would exit without processing the same number of frames as the channel; 
leaving the mixmonitor recording shorter than actual call duration.

This revision fixes this issue by moving the ast_audiohook_trigger_wait() and 
the subsequent audiohook.status check into the block where the 
ast_audiohook_read_frame() function returns NULL.

(closes issue #17078)
Reported by: geoff2010
Patches:
      dw-M17078.patch uploaded by dhubbard (license 733)
Tested by: dhubbard, geoff2010

Review: https://reviewboard.asterisk.org/r/611/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@257686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-04-16 21:15:43 +00:00
Tilghman Lesher
91a8a41d8a When forwarding a message, ensure that prepending works correctly.
This is a regression in 1.4, only.

(closes issue #17103)
 Reported by: mglazer
 Patches: 
       20100408__issue17103.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@257266 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-04-14 23:08:11 +00:00
Tilghman Lesher
498d885133 Ensure line terminators in email are consistent.
Fixes an issue with certain Mail Transport Agents, where attachments are not
interpreted correctly.

(closes issue #16557)
 Reported by: jcovert
 Patches: 
       20100308__issue16557__1.4.diff.txt uploaded by tilghman (license 14)
       20100308__issue16557__1.6.0.diff.txt uploaded by tilghman (license 14)
       20100308__issue16557__trunk.diff.txt uploaded by tilghman (license 14)
 Tested by: ebroad, zktech
 
Reviewboard: https://reviewboard.asterisk.org/r/544/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@255591 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-31 19:09:46 +00:00
Leif Madsen
1d9be78f12 Add documentation clarifying when 't' and 'T' can be used.
(closes issue #17021)
Reported by: kovzol
Tested by: lmadsen, kovzol, davidw, ebroad

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@255503 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-31 17:42:58 +00:00
Russell Bryant
43393bd1a9 Resolve a number of FreeBSD build issues.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@253631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-20 19:17:28 +00:00
Leif Madsen
4deaae7482 Typo found while fixing issue #16961.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@253349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-18 17:57:31 +00:00
Sean Bright
85f79116ac Use ast_strlen_zero to avoid a crash when a Dial() string isn't passed to ParkAndAnnounce
(closes issue #16731)
Reported by: sebele67
Patches:
      issue16731_20100129.diff uploaded by seanbright (license 71)
Tested by: sebele67


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@251410 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-09 19:29:39 +00:00
Alec L Davis
3d3116e656 revert ability to exit echo app
caused a regression, as only supported VOICE, not VIDEO etc.
Left in small formatting change.

(issue #16880)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:36:20 +00:00
Alec L Davis
63e614d896 fixes ability to exit echo app
when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue #16880)
Reported by: alecdavis
Patches: 
      based on echo_exit_1-6-1.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249845 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 09:11:56 +00:00
Sean Bright
daf062ece8 Fix crash in app_voicemail related to message counting.
We were passing a 'struct inprocess **' and treating it like a 'struct inprocess *'
causing a segfault.

(closes issue #16921)
Reported by: whardier
Patches:
      20100301_issue16921.patch uploaded by seanbright (license 71)
Tested by: whardier


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249671 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 19:35:01 +00:00
Jeff Peeler
e896cc88cf Make deletion of temporary greetings work properly with IMAP_STORAGE
This same patch was merged in 220833, but was skipped in this branch
erroneously.

(closes issue #16170)
Reported by: francesco_r


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248668 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-24 22:58:54 +00:00
Olle Johansson
ef93e3343e Don't log to debug unless debug is turned on
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-22 13:52:34 +00:00
Mark Michelson
a01809c2c2 Make sure that when autofill is disabled that callers not in the front of the queue cannot place calls.
(closes issue #16834)
Reported by: kebl0155
Patches:
      app_queue_no_autofill.v1.patch uploaded by kebl0155 (license 356)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@247168 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-17 16:24:17 +00:00
David Vossel
47de4d5211 fixes random deadlock in app_queue with use_weight during reload
(closes issue #16677)
Reported by: tim_ringenbach
Patches:
      app_queue_use_weight_deadlock.diff uploaded by tim ringenbach (license 540)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@246115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-10 17:44:20 +00:00
Tilghman Lesher
277db8b69d Backup and restore original textfile, for prosthesis (gerund of prepend).
Also, fix menuselect such that changing voicemail build options correctly
causes rebuild.

(closes issue #16415)
 Reported by: tomo1657
 Patches: 
       prepention.patch uploaded by tomo1657 (license 484)
       (with modifications by me to backport to 1.4)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@244242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-01 23:13:44 +00:00
Jeff Peeler
e0704019cc Revert 243570, I should have looked at this closer. Will reopen the issue, but
am leaving the review closed as the change was pointless.

(issue #16488)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-27 20:35:56 +00:00
Jeff Peeler
d889f4c191 Extend announcement URL used with Queue from 80 chars to PATH_MAX.
(closes issue #16488)
Reported by: syspert
Patches: 
      soundfilelen.pacth-2 uploaded by syspert (license 938)

Review: https://reviewboard.asterisk.org/r/475/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243570 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-27 18:47:34 +00:00
Tilghman Lesher
fab5527451 Disallow leaving more than maxmsg voicemails.
This is a possibility because our previous method assumed that no messages are
left in parallel, which is not a safe assumption.  Due to the vmu structure
duplication, it was necessary to track in-process messages via a separate
structure.  If at some point, we switch vmu to an ao2-reference-counted
structure, which would eliminate the prior noted duplication of structures,
then we could incorporate this new in-process structure directly into vmu.
(closes issue #16271)
 Reported by: sohosys
 Patches: 
       20100108__issue16271.diff.txt uploaded by tilghman (license 14)
       20100108__issue16271__trunk.diff.txt uploaded by tilghman (license 14)
       20100108__issue16271__1.6.0.diff.txt uploaded by tilghman (license 14)
 Tested by: jsutton


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@240414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-15 20:52:27 +00:00
David Vossel
6c6a857e1c add silence gen to wait apps
asterisk.conf's 'transmit_silence' option existed before
this patch, but was limited to only generating silence
while recording and sending DTMF. Now enabling the
transmit_silence option generates silence during wait
times as well.
  
To achieve this, ast_safe_sleep has been modified to
generate silence anytime no other generators are present
and transmit_silence is enabled. Wait apps not using
ast_safe_sleep now generate silence when transmit_silence
is enabled as well.

(closes issue 0016524)
Reported by: kobaz

(closes issue 0016523)
Reported by: kobaz
Tested by: dvossel
  
Review: https://reviewboard.asterisk.org/r/456/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@239718 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-13 17:16:12 +00:00
Russell Bryant
d8cf7e6003 Resolve a crash due to an ast_frame not being fully initialized.
(closes issue #16531)
Reported by: john8675309

(closes SWP-615)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@238009 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-06 15:18:22 +00:00
Sean Bright
3d20d25e4c Avoid a crash with large numbers of MeetMe conferences.
Similar to changes made to Queue(), when we have large numbers of conferences in
meetme.conf (1000s) and we use alloca()/strdupa(), we can blow out the stack and
crash, so instead just use a single fixed buffer.

(closes issue #16509)
Reported by: Kashif Raza
Patches:
      20091223_16509.patch uploaded by seanbright (license 71)
Tested by: seanbright


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@236509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-28 12:43:36 +00:00
Jeff Peeler
d97debdbf5 Fix talking detection status after conference user is muted.
This patch ensures that when a conference user is muted that the accompanying
AMI Meetme talking off event is sent. Also, the meetme list output is updated
to show the muted user as unmonitored.

(closes issue #16247)
Reported by: dimas
Patches: 
      v3-16247.patch uploaded by dimas (license 88)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@234379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-11 22:37:21 +00:00
Leif Madsen
bee22ddbec Update chan_spy documentation.
Update the documentation in ChanSpy and ExtenSpy to reflect that only a
single group can be specified to the g() option.

(closes issue #16420)
Reported by: diatonic

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@234094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-10 15:49:12 +00:00
David Vossel
6efb416d91 document and rename strip_control() in app_voicemail
(closes issue #16291)
Reported by: wdoekes



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233116 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-04 17:21:34 +00:00
Tilghman Lesher
ca5867f707 Deprecate "cz" in favor of "cs".
Also, change the use of language codes so that language registers as a prefix,
rather than an exact match.
(closes issue #16272)
 Reported by: patrol-cz
 Patches: 
       20091203__issue16272.diff.txt uploaded by tilghman (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-03 20:10:19 +00:00
David Vossel
9482a6da39 fixes app_queue ao2 error
(closes issue #16369)
Reported by: vrban
Patches:
      queue_issue_1.4.diff uploaded by dvossel (license 671)
Tested by: dvossel



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232444 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 19:03:01 +00:00
Joshua Colp
32365fe106 Fix a bug where if you hung up very quickly after calling AMD it would overwrite the AMDSTATUS of HANGUP with TOOLONG.
(closes issue #16239)
Reported by: CGMChris


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232355 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 17:04:52 +00:00
Matthew Nicholson
6a680d9b28 Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.
(closes issue #15625)
Reported by: Shagg63
Tested by: mnicholson

Review: https://reviewboard.asterisk.org/r/429/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 21:11:44 +00:00
David Vossel
264a1a78a9 app_queue crashes randomly, often during call-transfers
In app_queue, it is possible for a call_queue to be destroyed
while another object still holds a pointer to it.  This patch
converts call_queue objects to ao2 objects allowing them to be
ref counted.  This makes it safe for the queue_ent object in
queue_exec() to reference it's parent call_queue even after it
has left the queue.

(closes issue #15686)
Reported by: Hatrix
Patches:
      v2_queue_ao2.diff uploaded by dvossel (license 671)
Tested by: dvossel, aragon

Review: https://reviewboard.asterisk.org/r/427/



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 16:32:58 +00:00
David Vossel
c79e242ada fixes solaris segfault on dial with verbosity >= 3
(closes issue #16193)
Reported by: asgaroth
Patches:
      bug_16193_1.4.21.2_vers.diff uploaded by snuffy (license 35)
Tested by: asgaroth, snuffy



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231235 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-25 21:38:32 +00:00
David Vossel
182c57ce17 fixes MixMonitor thread not exiting when StopMixMonitor is used
(closes issue #16152)
Reported by: AlexMS
Patches:
      stopmixmonitor_1.4.diff uploaded by dvossel (license 671)
Tested by: dvossel, AlexMS

Review: https://reviewboard.asterisk.org/r/424/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-19 21:22:46 +00:00
Joshua Colp
2ef94c5196 Document a limitation in the AVAILSTATUS variable from ChanIsAvail and provide
a workaround for it that does not change existing behavior.

(closes issue #14426)
Reported by: macli


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229965 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 17:19:59 +00:00
Matthew Nicholson
3c256882d6 This patch modifies the Dial application to monitor the calling channel for hangups while playing back announcements.
(closes issue #16005)
Reported by: falves11
Patches:
      dial-announce-hangup-fix1.diff uploaded by mnicholson (license 96)
Tested by: mnicholson, falves11

Review: https://reviewboard.asterisk.org/r/407/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@227827 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-04 20:52:27 +00:00
Joshua Colp
ed413ec76c Fix a bug where the recorded privacy introduction file would not get removed if the caller hung up
while the called party had not yet answered.

This was fixed by introducing an argument to the 'n' option which, when enabled, removes the introduction
file under all scenarios. This was done to preserve the behavior that has existed for quite some time.

(closes issue #14674)
Reported by: ulogic
Patches:
      bug14674.patch uploaded by jpeeler (license 325)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@226889 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-02 18:08:11 +00:00
Tilghman Lesher
6e8a455534 Fix documentation for ast_softhangup() and correct the misuse thereof.
(closes issue #16103)
 Reported by: majorbloodnok


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@225105 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-21 16:02:12 +00:00
Tilghman Lesher
8699a5f158 Suffix is not needed for a match
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@225103 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-21 15:45:54 +00:00
Joshua Colp
926a033bf9 Do not attempt early media bridging (ie: direct RTP setup) if options are enabled that should prevent it.
(closes issue #14763)
Reported by: cupotka


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@224565 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-19 19:47:50 +00:00
Jeff Peeler
e3464ac40a Ensure ringing continues for branched calls after progress is received
While waiting for an answer, don't send progress for branched calls
for which ringing was sent.

(closes issue #15028)
Reported by: fnordian


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@223804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-12 23:12:50 +00:00
Russell Bryant
6429db49ba Remove a duplicate ao2_iterator_destroy().
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@223550 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-11 18:34:37 +00:00
Mark Michelson
a9317f6cbe Fix potential memory leak in app_dial.c
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@223213 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-09 18:17:12 +00:00
Kevin P. Fleming
2ad7cb7e87 Fix ao2_iterator API to hold references to containers being iterated.
See Mantis issue for details of what prompted this change.

Additional notes:

This patch changes the ao2_iterator API in two ways: F_AO2I_DONTLOCK
has become an enum instead of a macro, with a name that fits our
naming policy; also, it is now necessary to call
ao2_iterator_destroy() on any iterator that has been
created. Currently this only releases the reference to the container
being iterated, but in the future this could also release other
resources used by the iterator, if the iterator implementation changes
to use additional resources.

(closes issue #15987)
Reported by: kpfleming

Review: https://reviewboard.asterisk.org/r/383/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@222152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-10-06 01:16:36 +00:00
Matthew Nicholson
5d982dda69 Avoid a deadlock in chanspy, just in case the spyee is masqueraded and chanspy_ds_chan_fixup() is called with the channel locked.
(closes issue #15965)
Reported by: atis
Patches:
      chanspy-deadlock-fix1.diff uploaded by mnicholson (license 96)
Tested by: atis



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@220907 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-29 20:14:29 +00:00
Tilghman Lesher
5cf26dcdac Implicitly sending a progress signal breaks some applications.
Call Progress() in your dialplan if you explicitly want progress to be sent.
(Reverts change 216430, closes issue #15957)
Reported by: Pavel Troller on the Asterisk-Dev mailing list
http://lists.digium.com/pipermail/asterisk-dev/2009-September/039897.html


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@220288 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-24 19:39:41 +00:00
Tilghman Lesher
f4837ecbef When IMAP variables were changed during a reload, Voicemail did not use the new values.
This change introduces a configuration version variable, which ensures that
connections with the old values are not reused but are allowed to expire
normally.
(closes issue #15934)
 Reported by: viniciusfontes
 Patches: 
       20090922__issue15934.diff.txt uploaded by tilghman (license 14)
 Tested by: viniciusfontes


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@219816 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-22 21:37:03 +00:00
Tilghman Lesher
cefd4b7b03 If the user enters the same password as before, don't signal an error when the change does nothing.
(closes issue #15492)
 Reported by: cbbs70a
 Patches: 
       20090713__issue15492.diff.txt uploaded by tilghman (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@218730 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-15 22:27:41 +00:00
Tilghman Lesher
3913dcbc40 Ensure FollowMe sets language in channels it creates.
Also, not in the original bug report, but related fields are accountcode and
musicclass, and the inheritance of datastores.
(closes issue #15372)
 Reported by: Romik
 Patches: 
       20090828__issue15372.diff.txt uploaded by tilghman (license 14)
 Tested by: cervajs


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@218577 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-15 16:01:17 +00:00