Commit Graph

30232 Commits

Author SHA1 Message Date
Joshua Colp
de5df002a0 AST-2018-004: Restrict the number of Accept headers in a SUBSCRIBE.
When receiving a SUBSCRIBE request the Accept headers from it are
stored locally. This operation has a fixed limit of 32 Accept headers
but this limit was not enforced. As a result it was possible for
memory outside of the allocated space to get written to resulting
in a crash.

This change enforces the limit so only 32 Accept headers are
processed.

ASTERISK-27640
Reported By: Sandro Gauci

Change-Id: I99a814b10b554b13a6021ccf41111e5bc95e7301
2018-02-21 14:29:26 +00:00
Jenkins2
4f166b9017 Merge "doc/lang/language-criteria.txt: Link to wiki." into 13 2018-02-20 14:45:55 -06:00
Jenkins2
450afe655c Merge "res_http_websocket: Don't leak memory on read failure" into 13 2018-02-20 13:48:36 -06:00
Joshua Colp
4da0e19b89 chan_sip: Emit a second ringing event to ensure channel is found.
When constructing a dialog-info+xml NOTIFY message a ringing channel
is found if the state is ringing and further information is placed into
the message. Due to the migration to the Stasis message bus this did
not always work as expected.

This change raises a second ringing event in such a way to guarantee
that the event is received by chan_sip and another lookup is done to
find the ringing channel.

ASTERISK-24488

Change-Id: I547a458fc59721c918cb48be060cbfc3c88bcf9c
2018-02-20 12:43:25 -04:00
Jenkins2
f49e5d3998 Merge "core: Rename sounds_index.c to sounds.c." into 13 2018-02-20 06:36:26 -06:00
Jenkins2
c45d266edd Merge "BuildSystem: Allow newer autotools on OpenBSD." into 13 2018-02-20 06:26:49 -06:00
Jenkins2
ee9bee7e05 Merge "config: Fix locking for extconfig reload." into 13 2018-02-20 05:57:52 -06:00
Corey Farrell
cacb72f5ae doc/lang/language-criteria.txt: Link to wiki.
This document is out of date and is superseded by content on the
Asterisk wiki.

ASTERISK-24386 #close

Change-Id: Idbf95b27b096c205251e1bbb560c79224ba81822
2018-02-20 05:31:26 -05:00
Jenkins2
4df75c8266 Merge "BuildSystem: Use single bootstrap.sh for Asterisk and menuselect." into 13 2018-02-19 20:17:10 -06:00
Jenkins2
21ff3c38c4 Merge "rtp_engine: Load format name / mime type in uppercase again." into 13 2018-02-19 19:48:00 -06:00
Jenkins2
b01f1d096b Merge "install_prereq: Update OpenBSD libraries." into 13 2018-02-19 18:58:12 -06:00
Jenkins2
cf6f0547c3 Merge "BuildSystem: Fix a typo related to ./configure --prefix=<path> on OpenBSD." into 13 2018-02-19 18:31:29 -06:00
Jenkins2
c0f7da277a Merge "BuildSystem: Enable IMAP storage on OpenBSD." into 13 2018-02-19 18:20:00 -06:00
Jenkins2
e35152b550 Merge "res_pjsip_header_funcs: Various cleanups" into 13 2018-02-19 17:56:31 -06:00
Jenkins2
e34db67cfb Merge "res_pjsip: Use pjsip_sip_uri.user_param instead of other_param" into 13 2018-02-19 11:58:01 -06:00
Sean Bright
5ebc94da02 res_http_websocket: Don't leak memory on read failure
Change-Id: Ic449ea832bc81a1671c0e910c5fbe8c683e3da89
2018-02-19 08:25:01 -05:00
Jenkins2
0fe38b7dfa Merge "res_pjsip: Endpoint destruction does not free DTLS configuration" into 13 2018-02-19 06:11:18 -06:00
Thomas Guebels
9325de11f8 res_rtp_asterisk: Fix ICE candidate nomination
If the ICE role is not set right away, we might have a role conflict
that stays undetected and ICE finishing with successful tests and no
candidate nominated. This was introduced by ASTERISK-27088.

To avoid this, we set the role as soon as before but only if the ICE
state permits it: still checking and not yet nominating candidates or
completed.

ASTERISK-27646

Change-Id: I5dbc69ad63cacbb067922850fbb113d479bd729c
2018-02-19 11:31:38 +01:00
Corey Farrell
e532b982b3 core: Rename sounds_index.c to sounds.c.
This will make the source filename match the 'module reload sounds'
command.  This will allow conversion to a built-in module in Asterisk 16
without needing to redefine AST_MODULE.

Change-Id: Ifb8e489575b27eb33d8c0b6a531f266670557f6e
2018-02-19 05:00:23 -05:00
Corey Farrell
9c8763e4d2 config: Fix locking for extconfig reload.
Expand locking to include full reload process for extconfig to ensure
nothing can read the config mappings between clearing and reloading.

Change-Id: I378316bad04f1b599ea82d0fef62b8978a644b92
2018-02-19 03:49:45 -05:00
Sean Bright
1a7ad4c9cf res_pjsip_header_funcs: Various cleanups
* Prefer strcasecmp() over stricmp()
 * Use a list with no lock since we never actually lock
 * Minor cleanups to error messages

Change-Id: I8446f44795ee8f3072e1c1f9193c6912dfc0c42b
2018-02-18 09:07:17 -05:00
Alexander Traud
6eb22964ba rtp_engine: Load format name / mime type in uppercase again.
This reverts a previous change partly.

ASTERISK-27689

Change-Id: Ia3d2f282db6995be8c1c253b5d52f6038761e8af
2018-02-17 08:49:48 -06:00
Corey Farrell
27d28116d9 BuildSystem: Use single bootstrap.sh for Asterisk and menuselect.
This causes the root bootstrap.sh script to generate configure scripts
for both Asterisk and menuselect.  This ensures that both configure
scripts are generated with the same version of autotools and avoids
situations where shared autoconf macros get modified without
regenerating the menuselect script.

Change-Id: I2bfd8537bbb63b3d46b11efabbb15eaaf9ef731a
2018-02-16 18:58:35 -05:00
Jenkins2
d09954b192 Merge "bridge_roles: Use a non-locking linked list where appropriate" into 13 2018-02-16 17:40:14 -06:00
Sean Bright
9ad9433257 res_pjsip: Endpoint destruction does not free DTLS configuration
ASTERISK-27679 #close
Reported by: Mak Dee

Change-Id: I89a2783a11be0763bf123d1619ed176b6225cf42
2018-02-16 14:38:17 -05:00
Alexander Traud
c5e34f0794 install_prereq: Update OpenBSD libraries.
deleted
 jack sqlite

renamed
 freetds-0.63p1-msdblib to freetds
 mysql-client to mariadb-client

added
 bison bzip2 c-client doxygen e2fsprogs graphviz gsm libical jansson libltdl
 lua neon net-snmp libsrtp portaudio-svn postgresql-client python speexdsp
 subversion uriparser xmlstarlet

ASTERISK-27684

Change-Id: I26bdcb0a1d0e484a8dad1052da97f194aefd3370
2018-02-16 19:44:53 +01:00
Alexander Traud
88ec9be78a BuildSystem: Allow newer autotools on OpenBSD.
ASTERISK-27683

Change-Id: I5ec9dafbb0c16b6f2740c641980bc2eaaf995624
2018-02-16 12:31:57 -06:00
Richard Mudgett
421d4e9c7d Merge "res_calendar: Specialized calendars depend on symbols of general calendar." into 13 2018-02-16 10:55:10 -06:00
Jenkins2
bbc0ba07b1 Merge "contrib/script/sip_to_pjsip: add support for realtime" into 13 2018-02-16 10:16:40 -06:00
Jenkins2
626b5a7948 Merge "BuildSystem: Enable system provided libedit on OpenBSD." into 13 2018-02-16 08:16:45 -06:00
Alexander Traud
0ba6337d32 BuildSystem: Fix a typo related to ./configure --prefix=<path> on OpenBSD.
Reported by: Stuart Henderson

Change-Id: Ieae8624f48b6ae78cf29930b9a45a3c842c7a764
2018-02-16 07:54:08 -06:00
Jenkins2
0e91eb23b2 Merge "BuildSystem: Remove chan_h323 leftovers." into 13 2018-02-16 07:48:53 -06:00
Jenkins2
ab4c3ea746 Merge "BuildSystem: Invoke ldconfig with previous path." into 13 2018-02-16 07:29:06 -06:00
Alexander Traud
58aa0d1014 BuildSystem: Enable IMAP storage on OpenBSD.
ASTERISK-27681
Reported by: Stuart Henderson

Change-Id: Ifb6b614acb251b695b9417d76510e73eb335b679
2018-02-16 06:42:28 -06:00
Alexander Traud
139dd38193 res_calendar: Specialized calendars depend on symbols of general calendar.
ASTERISK-27680

Change-Id: Ifb77912e424fe3710a025c18526fada673ec0b79
2018-02-16 05:59:15 -06:00
Alexander Traud
94ff290361 BuildSystem: Enable system provided libedit on OpenBSD.
ASTERISK-27677

Change-Id: I0854e3616d1361ae9b6907d3d3444a02784ac62b
2018-02-16 12:02:15 +01:00
Sean Bright
48acd5cd26 bridge_roles: Use a non-locking linked list where appropriate
Also explicitly initialize with the AST_LIST_HEAD_NOLOCK_INIT macro for
clarity.

Change-Id: I4bc39ec33bc3ff77e1a971a01ace87deb965be3f
2018-02-15 15:30:35 -05:00
Sean Bright
54efc0c637 res_pjsip: Use pjsip_sip_uri.user_param instead of other_param
There is a dedicated slot in the pjsip_sip_uri for the 'user'
parameter, so use that instead of adding to the list of generic URI
parameters.

Change-Id: I0a0ce8a60ecee27489735bf56fd707719d8c2ed6
2018-02-15 14:36:26 -05:00
Jenkins2
fdf988cd28 Merge "BuildSystem: Do not warn when bash is not installed." into 13 2018-02-15 06:12:39 -06:00
Jenkins2
8212fd6bf4 Merge "main/asterisk.c: Remove silly usage of RAII_VAR." into 13 2018-02-14 12:43:48 -06:00
Alexander Traud
4a5221cd43 BuildSystem: Remove chan_h323 leftovers.
ASTERISK-27670

Change-Id: I07a8ef8bbd6001e25711fa1bff152eb6c9efa729
2018-02-14 09:31:36 +01:00
Alexander Traud
eabe72a679 BuildSystem: Invoke ldconfig with previous path.
On OpenBSD, gmake uninstall{-all} registered only libraries from /usr/lib and
lost those from /usr/local/lib. Instead, invoke ldconfig on a path.

ASTERISK-27595

Change-Id: I4aa2c0b5e07119d1a556f8ff6349eaf09e986888
2018-02-13 14:02:25 -06:00
Alexander Traud
c2283fca21 BuildSystem: Do not warn when bash is not installed.
ASTERISK-27631

Change-Id: Iefdf268b0b98c3e7d8089ba87cf78136ac1d785b
2018-02-13 10:25:47 -06:00
Jenkins2
a81dfd5949 Merge "chan_sip.c: Fix crash processing CANCEL." into 13 2018-02-13 08:09:20 -06:00
Jenkins2
d9bf0de50e Merge "json: Add conditionals to avoid locking if Jansson is thread safe." into 13 2018-02-13 07:42:31 -06:00
Jenkins2
add4a70354 Merge "BuildSystem: Enable autotools in FreeBSD." into 13 2018-02-13 07:25:17 -06:00
Joshua Colp
f5e6a9a2d2 Merge "pjproject_bundled: Disable G.729 from Belledonne Communications." into 13 2018-02-13 06:38:11 -06:00
Jenkins2
58e9ed1c9c Merge "codecs: Add support for WebRTC iLBC 2.0." into 13 2018-02-13 06:29:17 -06:00
Corey Farrell
4e5d5b2ce2 main/asterisk.c: Remove silly usage of RAII_VAR.
Change-Id: I7e2996397fbd3c3a6a69dd805c38448ddfc34ae9
2018-02-12 23:04:26 -05:00
Richard Mudgett
ba63dad12d chan_sip.c: Fix crash processing CANCEL.
Check if initreq data string exists before using it when processing a
CANCEL request.

ASTERISK-27666

Change-Id: Id1d0f0fa4ec94e81b332b2973d93e5a14bb4cc97
2018-02-12 20:57:28 -06:00