Commit Graph

528 Commits

Author SHA1 Message Date
Mark Michelson
403ee9194c Patch allows for more seamless transition from file storage voicemail to ODBC storage voicemail.
If a retrieval of a greeting from the database fails, but the file is found on the file system, then
we go ahead an insert the greeting into the database. The result of this is that people who
switch from file storage to ODBC storage do not need to rerecord their voicemail greetings.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79906 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-17 19:14:05 +00:00
Mark Michelson
ec2f24b901 base_encode is not trying to open a log file, so we should not call it a log file in the warning.
(related to issue #10452, reported by bcnit)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79690 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-16 15:58:34 +00:00
Mark Michelson
176f95680b Fixed an error in the Russian language voicemail intro.
(issue #10458, reported and patched by Oleh)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79527 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-15 14:26:40 +00:00
Mark Michelson
7133eb1368 Improved a bit of logic regarding comma-separated mailboxes in has_voicemail. Also added some braces to some compound if statements
since unbraced if statements scare me in general.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78907 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-09 23:47:00 +00:00
Mark Michelson
48d9158cdd Removing some extra debug code I left in my last commit
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78860 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-09 22:03:48 +00:00
Mark Michelson
fd5f948092 Quite a few changes regarding IMAP storage.
1. instead of using inboxcount as the core message counting function, we use messagecount instead. This makes it possible to count messages in folders besides just INBOX and Old.
2. inboxcount and hasvoicemail now use messagecount as their means of determining return values.
3. Added a copy_message function for IMAP storage. Unfortunately I don't have the means to test it, but it seems like a pretty straightforward function.
4. Removed a #ifndef IMAP_STORAGE and matching #endif from leave_voicemail for a couple of reasons. One, we want to support copying mail to multiple IMAP boxes, and two, IMAP was
   broken because a STORE macro had been moved into this section of code.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78859 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-09 21:51:17 +00:00
Russell Bryant
f2bf48ce42 add a comment to indicate that inboxcount for ODBC_STORAGE needs to be fixed to support multiple mailboxes
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78778 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-09 17:58:31 +00:00
Russell Bryant
e019aff438 Fix subscriptions to multiple mailboxes for ODBC_STORAGE. Also, leave a
comment for this to be fixed for IMAP_STORAGE, as well.  I left IMAP alone
since I know MarkM was working on this code right now for another reason.

This is broken even worse in trunk, but for a different reason.  The fact
that the mailbox option supported multiple mailboxes is completely not obvious
from the code in the channel drivers.  Anyway, I will fix that in another
commit ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78749 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-09 17:24:40 +00:00
Mark Michelson
c97cdff67d Fixed some compiler warnings so that compiling with dev-mode and IMAP storage would not have any errors.
This section of code may get changed again shortly since my change uncovers a rather silly bit of logic.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78620 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-08 18:16:49 +00:00
Mark Michelson
dcfb651931 The logic behind inboxcount's return value was reversed in has_voicemail and message_count.
(closes issue #10401, reported by st1710, patched by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78450 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-07 19:43:57 +00:00
Tilghman Lesher
57996e930e Reconnection doesn't happen automatically when a DB goes down (fixes issue #9389)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-07 19:09:38 +00:00
Russell Bryant
76f4f0218c (closes issue #10194)
Reported by: blitzrage
Patches:
      bug0010194 uploaded by vovochka
Tested by: blitzrage

Fix a problem when you call Voicemail() with multiple mailboxes specified and 
ODBC_STORAGE is in use.  The audio part of the message was only given to the
first mailbox specified.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-03 20:14:06 +00:00
Tilghman Lesher
9b71e8eef2 Voicemail with ODBC_STORAGE defined does not compile cleanly (missing def)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77886 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-01 22:14:47 +00:00
Joshua Colp
68c221f69a Add some fixes for building on Solaris.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77869 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-01 17:56:59 +00:00
Tilghman Lesher
3630b5e477 It was our stated intention for 1.4 that files created in app_voicemail should
depend upon the umask.  Unfortunately, mkstemp() creates files with mode 0600,
regardless of the umask.  This corrects that deficiency.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@76708 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-23 22:38:06 +00:00
Tilghman Lesher
0b6bdf6bf3 Merged revisions 75748 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75748 | tilghman | 2007-07-18 15:31:36 -0500 (Wed, 18 Jul 2007) | 2 lines

Store prior to copy (closes issue #10193)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75749 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-18 20:40:18 +00:00
Joshua Colp
6d143d401f Backport GCC 4.2 fixes. Without these Asterisk won't build under devmode using GCC 4.2.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-18 20:00:23 +00:00
Mark Michelson
4ab675ca50 Forwarding a message with IMAP storage was storing the message in the sender's box instead of the forwarded mailbox.
(closes issue #10138, reported and patched by jaroth)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74476 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 23:32:52 +00:00
Jason Parker
53b44803ee Merged revisions 74316 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74316 | qwell | 2007-07-10 10:37:54 -0500 (Tue, 10 Jul 2007) | 4 lines

Fix a small typo in description in of Voicemail() application.

Issue 10170, patch by casper.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74317 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 15:38:32 +00:00
Mark Michelson
441d1bbdf5 Fixed a logic error in leave_voicemail. Pass the mailbox instead of the context to inbox_count when the context is "default."
(closes issue #10135, reported by yannj, repaired by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74047 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 14:57:41 +00:00
Mark Michelson
bf9d8ab999 Fixing a rare case which causes voicemail to crash when compiled with IMAP storage.
inboxcount has the possibility of finding an "interactive" vm_state when no persistent "non-interactive"
vm_state exists for that mailbox. If this should happen when someone attempts to leave a message, it results in
a crash. This patch, along with my commit in revision 72670 fix issue 10053, reported by jaroth.

closes issue #10053



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73727 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-06 16:36:17 +00:00
Jason Parker
04524392d3 Fix another problem in voicemail with missing symbols.
Issue 10074, patch by kryptolus, extended to include #if 0'd blocks (just in case)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@72182 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 18:36:56 +00:00
Mark Michelson
83fd6c08d2 Removing a pointless line. This variable was already set earlier and between then and this
line, there is no way that the values on the right side of the assignment could have changed.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@71953 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 23:02:09 +00:00
Mark Michelson
79332488f7 A few changes, the ultimate goal of which is to keep better track of the number of messages
that a mailbox currently has. A description of the changes:

1. Changed the "updated" field of the vm_state struct to act more as a binary semaphore than a
   counting semaphore, since its current implementation made the inboxcount function not work properly.
   This change falls in line with a change made by UPenn with their IMAP setup and helps to sync our changes with theirs.
2. Eliminated some redundant calls to get_vm_state_by_mailbox inside leave_voicemail
3. Use the play_folder variable to keep track of the number of old and new messages in a mailbox as the messages are deleted
4. Added an increment to the number of new messages that was not there previously in the leave_voicemail function



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@71877 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 19:00:05 +00:00
Mark Michelson
555dcbc021 Fixing bug where the authuser was mistakenly pulled from the mailbox string instead
of the IMAP user.
(closes issue 10054, reported and patched by jaroth)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@71796 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 15:47:31 +00:00
Tilghman Lesher
5da46f710e Merged revisions 71750 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r71750 | tilghman | 2007-06-26 07:25:58 -0500 (Tue, 26 Jun 2007) | 2 lines

Issue 10062 - Trying to move a message without selecting one first results in memory corruption

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@71751 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 12:27:47 +00:00
Joshua Colp
c7dc8d1735 Merged revisions 70898 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r70898 | file | 2007-06-21 17:37:55 -0400 (Thu, 21 Jun 2007) | 2 lines

Don't explode if the gain option is specified without a value. (issue #9274 reported by mfarver)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70899 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 21:40:19 +00:00
Mark Michelson
ac73d19138 When volgain is used don't leave a temporary file behind.
(Closes Issue 8514, Reported and patched by ulogic, code reviewed by Jason Parker)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70808 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 19:49:44 +00:00
Joshua Colp
ce4f92604a Fix building with ODBC storage enabled. (issue #10025 reported by denisgalvao)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70677 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 13:58:36 +00:00
Russell Bryant
cbdc6b5b2d To prevent 92138749238754 more reports of "I have unixodbc installed, but
still can't build *_odbc.so!", check for ltdl directly, instead of just listing
it as another library to include in the unixodbc check in the configure script.
This also makes ltdl show up as a dependency in menuselect so people know what
to go install.  (related to issue #9989, patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69702 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 16:35:02 +00:00
Kevin P. Fleming
ae82d97c6d use ast_localtime() in every place localtime_r() was being used
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 21:50:40 +00:00
Mark Michelson
9a68aa6d89 Contains a patch for fixing an encoding problem when using Outlook to view voicemail emails and attachments.
This fix has also been tested on Thunderbird, Evolution, Pine, and Mutt.
(Issue 9336, reported by marwick, patched by mutterc)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69181 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 19:41:13 +00:00
Jason Parker
30d9a8a20b Fix incorrect French syntax of "old messages".
Request for feedback was sent to asterisk-dev mailing list, with little response.

Issue 9118, patch by junky.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68326 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:00:01 +00:00
Jason Parker
1d704b2857 Merged revisions 68204 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68204 | qwell | 2007-06-07 15:02:50 -0500 (Thu, 07 Jun 2007) | 4 lines

Don't try to save voicemail greetings unless the user presses '1' to accept/save.

Issue 9904, patch by me.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68211 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:06:00 +00:00
Mark Michelson
878e480ff8 Submitting a fix for Issue 8016. Added a check to make sure that greetings get stored properly.
(Issue 8016, reported by edhorton, patched by alamantia with modification by me. Thanks to Jason Parker
for the advice on this).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:47:42 +00:00
Mark Michelson
e8900612be Fix for Issue 9810. There was a segfault under a specific set of circumstances:
1. VoiceMailMain was configured in the dialplan with an extension as its argument
2. A message was left for this mailbox
3. Tried to call VoiceMailMain but hung up before entering password.

This was fixed by checking that a pointer was non-null prior to trying to dereference it.
(Issue 9810, reported by xmarksthespot, patched by Corydon76 with modifications by me).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 19:26:55 +00:00
Mark Michelson
0a49a913ed Fix for bug number 9786, wherein voicemails saved to IMAP storage using extensions other than gsm were
unable to be played over the phone. (Issue 9786, reporter: xmarksthespot, Patched by xmarksthe spot with revisions by me,
reviewed by Russell Bryant).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 18:32:50 +00:00
Mark Michelson
a90cf2d802 Removing extraneous debugging lines from revision 66897. Sorry :)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66917 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 21:31:49 +00:00
Mark Michelson
c71ead7c52 Submitting a fix for voicemail with IMAP storage. Attachments with format specified as gsm were duplicated (i.e. two attachments) were left.
Thank you very much to xmarksthespot for submitting the patch that fixed this. (Issues 9787 and 8873, Reported by xmarksthespot and jerjer, patched by xmarksthespot)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 21:09:30 +00:00
Mark Michelson
48b438a0c3 Fixed seg-faults when recording greetings in voicemail with IMAP enabled. (Issue No. 9735, reported by xmarksthespot, patched by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66671 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 23:26:39 +00:00
Russell Bryant
c556cc222c List res_smdi as a dependency for app_voicemail and chan_zap
(Thanks to mnicholson for pointing it out)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65501 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-22 18:40:38 +00:00
Jason Parker
954f082462 Merged revisions 64758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r64758 | qwell | 2007-05-17 11:52:38 -0500 (Thu, 17 May 2007) | 4 lines

If we have a negative current message, we shouldn't go back even further...

Issue 9727.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64761 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-17 16:53:27 +00:00
Joshua Colp
5e41785d73 Fix authuser support. (issue #9740 reported by xmarksthespot)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64720 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-17 13:48:44 +00:00
Tilghman Lesher
dac8d487f7 Merged revisions 63359 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r63359 | tilghman | 2007-05-08 01:20:16 -0500 (Tue, 08 May 2007) | 2 lines

Issue 9527 - upon entering a folder, no message is selected (curmsg == -1), so deleting causes memory corruption (beyond bounds)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63360 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 06:22:37 +00:00
Tilghman Lesher
e5f56f776d Bug 9590 - Memory leaks around find_user() (found by rayjay, different fixes by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-01 21:34:43 +00:00
Russell Bryant
70eb19121e Fix the UpdateConfig manager action to properly treat "variables" and "objects"
differently (a=b versus a=>b).
(issue #9568, reported by pari, patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61690 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-20 18:19:18 +00:00
Russell Bryant
2ac2c7f64d Eliminate a compiler warning with ODBC_STORAGE enabled so that it will build
under dev-mode.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-13 17:10:19 +00:00
Steve Murphy
7d5a79a0b9 This is a big improvement over the current CDR fixes. It may still need refinement, but this won't have as many folks bothered.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 18:32:07 +00:00
Jason Parker
e658e931ca Merged revisions 60267 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r60267 | qwell | 2007-04-05 11:09:41 -0500 (Thu, 05 Apr 2007) | 5 lines

Just because we can't find the voicemail configuration file, doesn't
 mean that the module failed to load.  The user could be using realtime.

Issue #9473

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-05 16:10:48 +00:00
Joshua Colp
76dcc531f0 Merged revisions 59723 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r59723 | file | 2007-04-02 14:55:25 -0400 (Mon, 02 Apr 2007) | 2 lines

Increase the maximum size for a string of mailboxes to 1024. (issue #9270 reported by rtucker)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59724 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-02 18:58:24 +00:00