Commit Graph

3188 Commits

Author SHA1 Message Date
Leif Madsen
9baf979137 Merged revisions 292786 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r292786 | lmadsen | 2010-10-22 16:16:12 -0500 (Fri, 22 Oct 2010) | 13 lines
  
  Update the LDIF file for LDAP.
  The LDIF file asterisk.ldif was quite a bit out of date from the asterisk.ldap-schema file, so I've
  now updated that to be in sync. The asterisk.ldif file being out of sync was a problem on my systems
  where I was doing an ldapadd to import the schema into the LDAP database, and the existing file
  would cause problems and ERROR messages when registering.
  
  Additional documention has been added based on feedback in the issue I'm closing.
  
  (closes issue #13861)
  Reported by: scramatte
  Patches:
        ldap-update.txt uploaded by lmadsen (license 10)
  Tested by: lmadsen, jcovert, suretec, rgenthner
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@292787 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-22 21:28:43 +00:00
Terry Wilson
668d532d6b Add sip show peer info about crypto and remove dated comment
This patch adds information about the encryption setting to 'sip show
peers' and removes an out-of-date comment from res_srtp.c and instead
directs users to the proper documentation.

(closes issue #18140)
Reported by: chodorenko



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@292309 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-19 19:27:32 +00:00
David Vossel
3e3ea54864 Fixes peer's host port information being lost on sip reload.
(closes issue #18135)
Reported by: lmadsen
Patches:
      crazy_ports_v2.diff uploaded by dvossel (license 671)
Tested by: lmadsen


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@291942 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-15 20:12:04 +00:00
Paul Belanger
a37956721c Add the ability for ast_find_ourip to return IPv4, IPv6 or both.
While testing chan_gtalk I noticed jabber was using my IPv6 address
and not IPv4. When using bindaddr=0.0.0.0 it is possible for ast_find_ourip()
to return both IPv6 and IPv4 results.  Adding a family parameter gives you
the ablility to choose.

Since jabber/gtalk/h323 do not support IPv6, we should only return IPv4 results.

Review: https://reviewboard.asterisk.org/r/973/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@291758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-14 15:15:12 +00:00
Russell Bryant
ec05b242dd Merged revisions 291393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r291393 | russell | 2010-10-13 10:29:21 -0500 (Wed, 13 Oct 2010) | 13 lines
  
  Merged revisions 291392 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r291392 | russell | 2010-10-13 10:23:19 -0500 (Wed, 13 Oct 2010) | 6 lines
    
    Lock pvt so pvt->owner can't disappear when queueing up a frame.
    
    This fixes a crash due to a hangup race condition.
    
    ABE-2601
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@291394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-13 15:46:39 +00:00
Richard Mudgett
184d0e7f1b Move declaration closer to where now used.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@291113 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-11 18:51:13 +00:00
Richard Mudgett
a96796cc44 Merged revisions 291110-291111 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r291110 | rmudgett | 2010-10-11 13:34:22 -0500 (Mon, 11 Oct 2010) | 9 lines
  
  Merged revisions 291109 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r291109 | rmudgett | 2010-10-11 13:29:43 -0500 (Mon, 11 Oct 2010) | 1 line
    
    Add missing unlock to an exception condition in reload_config().
  ........
................
  r291111 | rmudgett | 2010-10-11 13:39:06 -0500 (Mon, 11 Oct 2010) | 1 line
  
  Make exit from handle_request_do() consistent.
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@291112 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-11 18:48:15 +00:00
Jeff Peeler
ddebf12b88 Merged revisions 289798 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r289798 | jpeeler | 2010-10-01 18:01:31 -0500 (Fri, 01 Oct 2010) | 22 lines
  
  Merged revisions 289797 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r289797 | jpeeler | 2010-10-01 17:58:38 -0500 (Fri, 01 Oct 2010) | 15 lines
    
    Change RFC2833 DTMF event duration on end to report actual elapsed time.
    
    The scenario here is with a non P2P early media session. The reported time
    length of DTMF presses are coming up short when sending to the remote side.
    Currently the event duration is a running total that is incremented when sending
    continuation packets. These continuation packets are only triggered upon
    incoming media from the remote side, which means that the running total probably
    is not going to end up matching the actual length of time Asterisk received
    DTMF. This patch changes the end event duration to be lengthened if it is
    detected that the end event is going to come up short.
    
    Review: https://reviewboard.asterisk.org/r/957/
    
    ABE-2476
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@289840 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-02 02:43:45 +00:00
Jeff Peeler
4f8d5448a6 Merged revisions 289700 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r289700 | jpeeler | 2010-10-01 11:21:04 -0500 (Fri, 01 Oct 2010) | 21 lines
  
  Merged revisions 289699 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r289699 | jpeeler | 2010-10-01 11:20:00 -0500 (Fri, 01 Oct 2010) | 14 lines
    
    Ensure user portion of SIP URI matches dialplan when using encoded characters.
    
    This commit takes a simliar approach to 288112 and checks the dialplan to
    determine the proper action for an incoming contact header as to whether or not
    it should be decoded or not. sip_new was blindly always decoding the extension,
    which also caused the outgoing contact header to be incorrect as well as failing
    to match the encoded extension in the dialplan.
    
    (closes issue #17892)
    Reported by: wdoekes
    Patches: 
          bug17892-1.patch uploaded by jpeeler (license 325)
    Tested by: wdoekes
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@289701 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-01 16:22:19 +00:00
Stefan Schmidt
097becdba1 don't iterate through all dialogs to find and delete old subscribes
On every incoming subscribe there is a iteration through all dialogs to find old subscribes and delete them. This is slow and not RFC conform. This was only needed in 1.2 cause a subscribe was not deleted when a dialog was destroyed, after 1.4 a subscribe get removed when its dialog is destroyed.

(closes issue #17950)
Reported by: schmidts
Tested by: schmidts

Review: https://reviewboard.asterisk.org/r/901/



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@289622 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-01 09:42:22 +00:00
Matthew Nicholson
ac5ac97178 Merged revisions 289553 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r289553 | mnicholson | 2010-09-30 14:51:27 -0500 (Thu, 30 Sep 2010) | 4 lines
  
  Properly handle channel allocation failures duing invites with replaces.
  
  ABE-2588
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@289554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-30 19:53:10 +00:00
Richard Mudgett
34b3615fff Break up long ast_manager_event_multichan() event lines.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@289054 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-28 00:32:18 +00:00
Tilghman Lesher
f2f15f7e04 Still build SIP, even if res_crypto cannot be built (use, not depend).
(closes issue #18062)
 Reported by: a user on the mailing list


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@288961 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-27 18:37:41 +00:00
David Vossel
6ba94c8639 Append Retry-After header on 500 error response to Re-INVITE according to RFC3261 section 14.2.
ABE-2301



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@288852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-24 17:58:57 +00:00
David Vossel
68751f8b26 Inspect Require header on BYE transaction according to RFC3261 section 8.2.2.3.
ABE-2293


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@288821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-24 17:05:12 +00:00
David Vossel
0f4fa2300a Merged revisions 288417 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r288417 | dvossel | 2010-09-22 12:49:05 -0500 (Wed, 22 Sep 2010) | 11 lines
  
  Merged revisions 288416 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r288416 | dvossel | 2010-09-22 12:48:15 -0500 (Wed, 22 Sep 2010) | 5 lines
    
    RFC3261 section 12.2 explicitly says out of order requests are responded with a 500 Server Internal Error response.
    
    ABE-2458
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@288418 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-22 17:49:56 +00:00
David Vossel
4cb567b461 Merged revisions 288344 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r288344 | dvossel | 2010-09-22 11:53:28 -0500 (Wed, 22 Sep 2010) | 9 lines
  
  Merged revisions 288343 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r288343 | dvossel | 2010-09-22 11:49:56 -0500 (Wed, 22 Sep 2010) | 2 lines
    
    During check_pendings, if the dialog is terminated with a CANCEL, change the invitestate to INV_CANCEL like in sip_hangup.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@288345 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-22 16:59:14 +00:00
Tilghman Lesher
913c6b39b4 Merged revisions 288113 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r288113 | tilghman | 2010-09-21 16:59:46 -0500 (Tue, 21 Sep 2010) | 22 lines
  
  Merged revisions 288112 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r288112 | tilghman | 2010-09-21 16:58:13 -0500 (Tue, 21 Sep 2010) | 15 lines
    
    Try both the encoded and unencoded subscription URI for a match in hints.
    
    When a phone sends an encoded URI for a subscription, the URI is not matched
    with the actual hint that is in decoded format.  For example, if we have an
    extension with a hint that is named: "#5601" or "*5601", the subscription will
    work fine if the phone subscribes with an already decoded URI, but when it's
    decoded like "%255601" or "%2A5601", Asterisk is unable to match it with the
    correct hint.
    
    (closes issue #17785)
     Reported by: ramonpeek
     Patches: 
           20100831__issue17785.diff.txt uploaded by tilghman (license 14)
     Tested by: ramonpeek
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@288159 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-21 22:57:22 +00:00
David Vossel
35d4d7fb48 Send a "415 Unsupported Media Type" after failure to process sdp due to unknown Content-Encoding header.
ABE-2258


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@287929 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-21 18:32:12 +00:00
Russell Bryant
d0581b8bbd Don't use ast_strdupa() from within the arguments to a function.
(closes issue #17902)
Reported by: afried
Patches:
      issue_17902.rev1.txt uploaded by russell (license 2)
Tested by: russell

Review: https://reviewboard.asterisk.org/r/927/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@287895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-21 15:43:33 +00:00
Tilghman Lesher
a39b2f5ed2 Anonymous callerid needs a "sip:" uri prefix.
(closes issue #17981)
 Reported by: avalentin
 Patches: 
       sip-anonymous-aastra.patch uploaded by avalentin (license 1107)
       (plus an additional fix by me)
 Tested by: avalentin


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@287893 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-21 15:24:47 +00:00
David Vossel
9cffa9cb3f Fixes issue with registrations not working properly with pedantic=yes.
(closes issue #18017)
Reported by: schmidts
Patches:
      issues_18017_v1.diff uploaded by dvossel (license 671)
Tested by: schmidts



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@287645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-20 21:34:15 +00:00
Jeff Peeler
c9bfde6afd Add parking extension for non-default parking lots.
This is a new feature that allows for parking to custom parking lots to be
accessed directly, rather than with channel variables or by changing the
default parking lot. The extension is set with the parkext option just as the
default parking lot is done. Also, the manager action has been updated to
optionally allow a specified parking lot.

(closes issue #14882)
Reported by: vmikhnevych
Patches: 
      patch_14882.txt uploaded by mnick (license 874)
      modified by me

Review: https://reviewboard.asterisk.org/r/884/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@286931 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-15 19:22:15 +00:00
Matthew Nicholson
ebe189365e Set tohost to the domain specified in the configuration file instead of the IP address of the host we are calling.
This fixes a regression introduced in r274783.

(closes issue #17960)
Reported by: adriavidal
Patches:
      sip-tohost-fix1.diff uploaded by mnicholson (license 96)
Tested by: mich, mnicholson, adriavidal

(closes issue #17676)
Reported by: outcast
Patches:
      sip-tohost-fix1.diff uploaded by mnicholson (license 96)
Tested by: mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@286868 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-15 13:05:52 +00:00
David Vossel
50d114dcd5 Sets subscribed type for outgoing MWI subscriptions so correct Event header is used.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@286834 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-14 21:57:35 +00:00
Matthew Nicholson
d028e9839e Merged revisions 286757 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r286757 | mnicholson | 2010-09-14 14:27:28 -0500 (Tue, 14 Sep 2010) | 20 lines
  
  Merged revisions 286756 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r286756 | mnicholson | 2010-09-14 14:26:18 -0500 (Tue, 14 Sep 2010) | 13 lines
    
    Don't clear the username from a realtime database when a registration expires.
    
    Non-realtime chan_sip does not clear the username from memory when a registration expiries so realtime probably shouldn't either.
    
    (closes issue #17551)
    Reported by: ricardolandim
    Patches:
          reg-expiry-username-1.4-fix1.diff uploaded by mnicholson (license 96)
          reg-expiry-username-1.6.2-fix1.diff uploaded by mnicholson (license 96)
          reg-expiry-username-1.8-fix1.diff uploaded by mnicholson (license 96)
          reg-expiry-username-trunk-fix1.diff uploaded by mnicholson (license 96)
    Tested by: ricardolandim, mnicholson
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@286758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-14 19:28:38 +00:00
Jason Parker
67c20662b7 Merged revisions 286456 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r286456 | qwell | 2010-09-13 14:38:35 -0500 (Mon, 13 Sep 2010) | 5 lines
  
  Remove "Internal IP" from sip show settings, as it's not at all useful to display.
  
  (closes issue #17840)
  Reported by: oej
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@286457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-13 19:40:05 +00:00
David Vossel
006435cc1f Merged revisions 285567 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r285567 | dvossel | 2010-09-08 17:11:28 -0500 (Wed, 08 Sep 2010) | 9 lines
  
  Merged revisions 285566 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r285566 | dvossel | 2010-09-08 17:07:31 -0500 (Wed, 08 Sep 2010) | 2 lines
    
    In retrans_pkt, do not unlock pvt until the end of the function on a transmit failure.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@285568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-08 22:14:19 +00:00
David Vossel
b452a0fc01 Merged revisions 285563 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r285563 | dvossel | 2010-09-08 16:47:29 -0500 (Wed, 08 Sep 2010) | 54 lines
  
  Fixes interoperability problems with session timer behavior in Asterisk.
  
  CHANGES:
  1. Never put "timer" in "Require" header.  This is not to our benefit
  and RFC 4028 section 7.1 even warns against it.  It is possible for one
  endpoint to perform session-timer refreshes while the other endpoint does
  not support them.  If in this case the end point performing the refreshing
  puts "timer" in the Require field during a refresh, the dialog will
  likely get terminated by the other end.
  
  2. Change the behavior of 'session-timer=accept' in sip.conf (which is
  the default behavior of Asterisk with no session timer configuration
  specified) to only run session-timers as result of an incoming INVITE
  request if the INVITE contains an "Session-Expires" header... Asterisk is
  currently treating having the "timer" option in the "Supported" header as
  a request for session timers by the UAC.  I do not agree with this.  Session
  timers should only be negotiated in "accept" mode when the incoming INVITE
  supplies a "Session-Expires" header, otherwise RFC 4028 says we should
  treat a request containing no "Session-Expires" header as a session with
  no expiration.
  
  Below I have outlined some situations and what Asterisk's behavior is.
  The table reflects the behavior changes implemented by this patch.
  
  SITUATIONS:
  -Asterisk as UAS
  1. Incoming INVITE: NO  "Session-Expires"
  2. Incoming INVITE: HAS "Session-Expires"
  
  -Asterisk as UAC
  3. Outgoing INVITE: NO  "Session-Expires". 200 Ok Response HAS "Session-Expires" header
  4. Outgoing INVITE: NO  "Session-Expires". 200 Ok Response NO  "Session-Expires" header
  5. Outgoing INVITE: HAS "Session-Expires".
  
  Active   - Asterisk will have an active refresh timer regardless if the other endpoint does.
  Inactive - Asterisk does not have an active refresh timer regardless if the other endpoint does.
  XXXXXXX  - Not possible for mode.
  ______________________________________
  |SITUATIONS | 'session-timer' MODES  |
  |___________|________________________|
  |           | originate  |  accept   |
  |-----------|------------|-----------|
  |1.         |   Active   | Inactive  |
  |2.         |   Active   |  Active   |
  |3.         | XXXXXXXX   | Active    |
  |4.         | XXXXXXXX   | Inactive  |
  |5.         |   Active   | XXXXXXXX  |
  --------------------------------------
  
  
  (closes issue #17005)
  Reported by: alexrecarey
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@285564 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-08 21:48:37 +00:00
Jason Parker
7e6f798329 Don't automatically add domains for wildcard bindaddrs.
(closes issue #17832)
Reported by: oej
Patches: 
      17832-wildcard.diff uploaded by qwell (license 4)
Tested by: qwell


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@285455 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-07 22:22:14 +00:00
Jason Parker
de7ee06771 Add note to 'sip show settings' regarding dual-stack support, and a :: bindaddress.
(closes issue #17831)
Reported by: oej
Patches: 
      17831-v6wildcardbind.diff uploaded by qwell (license 4)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@285369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-07 20:58:34 +00:00
Terry Wilson
4b9b342078 Call correct lock function as transferer is a sip_pvt not a channel
Both functions are #defined to ao2_lock, but still...


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@285017 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-03 23:19:54 +00:00
David Vossel
4c42713010 Disables auth_options_request option by default.
The auth_options_request option was created to do authentication
on OPTIONS request just like INVITES are done.  Since it has been
noted that some endpoints use OPTIONS requests as a way of qualifying
a peer and that a 401 authentication response could result in
interoperability issues, this option has been disabled by default.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@285006 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-03 22:21:50 +00:00
David Vossel
677c54d1f2 During OPTIONS authentication, the authpeer does not need to be returned for any reason.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@284952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-03 18:03:23 +00:00
David Vossel
125f089394 authenticate OPTIONS requests just like we would an INVITE
OPTIONS requests should be treated the same as an INVITE
This includes authentication.  This patch adds the ability for
incoming out of dialog OPTION requests to be authenticated
before providing a response indicating whether an extension
is available or not.  The authentication routine works the
exact same way as it does for incoming INVITEs.  This means
that if a peer has 'insecure=invite' in their peer definition,
the same will be true for the processing of the OPTIONS request.

Review: https://reviewboard.asterisk.org/r/881/



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@284950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-03 17:29:02 +00:00
David Vossel
b5f428dee5 Merged revisions 284704 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r284704 | dvossel | 2010-09-02 11:48:51 -0500 (Thu, 02 Sep 2010) | 13 lines
  
  Merged revisions 284703 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r284703 | dvossel | 2010-09-02 11:47:15 -0500 (Thu, 02 Sep 2010) | 7 lines
    
    Removed relatedpeer code from sip_autodestruct
    
    Handling of the relatedpeer structure associated with a
    sip_pvt should be done during the final sip_destruction
    function, not in sip_autodestruct.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@284705 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-02 16:56:43 +00:00
Tilghman Lesher
7e3f95e00a When optional_api is non-optional, force dependent modules to be loaded.
(closes issue #17707)
 Reported by: ira
 Patches: 
       20100819__issue17707__asterisk1.8.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman
 
Review: https://reviewboard.asterisk.org/r/876/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@284610 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-02 05:20:59 +00:00
David Vossel
ed423183d6 During request to dialog matching, verify init_ruri is present before comparing.
During request to dialog matching, we attempt a best effort routine for fork
detection which requires several elements to be in place.  The dialog's
initial request uri is one of those elements.  Since it is best effort,
if the init_ruri is not present for some reason we can not proceed with that
routine.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@284561 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-01 21:47:01 +00:00
Terry Wilson
8a112de270 Fix SRTP for changing SSRC and multiple a=crypto SDP lines
Adding code to Asterisk that changed the SSRC during bridges and masquerades
broke SRTP functionality. Also broken was handling the situation where an
incoming INVITE had more than one crypto offer. This patch caches the SRTP
policies the we use so that we can change the ssrc and inform libsrtp of the
new streams. It also uses the first acceptable a=crypto line from the incoming
INVITE.

(closes issue #17563)
Reported by: Alexcr
Patches: 
      srtp.diff uploaded by twilson (license 396)
Tested by: twilson

Review: https://reviewboard.asterisk.org/r/878/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@284477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-09-01 18:44:36 +00:00
Tilghman Lesher
b8dbf411e8 Merged revisions 284399 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r284399 | tilghman | 2010-08-31 15:18:32 -0500 (Tue, 31 Aug 2010) | 14 lines
  
  Merged revisions 284393 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r284393 | tilghman | 2010-08-31 15:13:21 -0500 (Tue, 31 Aug 2010) | 7 lines
    
    Don't send a devstate change on poke_noanswer if the state did not change.
    
    (closes issue #17741)
     Reported by: schmidts
     Patches: 
           chan_sip.c.patch uploaded by schmidts (license 1077)
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@284415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-31 20:22:10 +00:00
David Vossel
962f12b524 Merged revisions 284002 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r284002 | dvossel | 2010-08-27 17:27:50 -0500 (Fri, 27 Aug 2010) | 14 lines
  
  Merged revisions 283960 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r283960 | dvossel | 2010-08-27 17:17:26 -0500 (Fri, 27 Aug 2010) | 8 lines
    
    Parse all "Accept" headers for SIP SUBSCRIBE requests.
    
    (closes issue #17758)
    Reported by: ibc
    Patches:
          multiple_accept_headers_1.4.diff uploaded by dvossel (license 671)
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@284032 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-27 22:37:11 +00:00
David Vossel
9bb986156a Merged revisions 283691 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r283691 | dvossel | 2010-08-26 10:24:40 -0500 (Thu, 26 Aug 2010) | 25 lines
  
  Merged revisions 283690 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r283690 | dvossel | 2010-08-26 10:22:28 -0500 (Thu, 26 Aug 2010) | 19 lines
    
    Fixed how Asterisk destroys a dialog on channel hangup before invite receives a response.
    
    If an ast_channel with a SIP tech pvt hangs up before the sip dialog gets a response
    to its outgoing INVITE, Asterisk used to pretend_ack the INVITE.  This is not rfc
    compliant and results in confusion at the other endpoint.  sip_pretend_ack will ack
    and remove all the packets in the retransmit queue.  This means that the INVITE will
    stop retransmitting, and that any response to that INVITE that comes after the pretend_ack
    occurs will be ignored.
    
    Instead of faking any sort of acknowledgement for an outgoing INVITE during an internal
    hangup, we should let the protocol stack process the INVITE transaction and terminate
    the dialog properly.  This is achieved by setting the PENDING_BYE flag.  When this flag
    is used, once the dialog proceeds to an escapable state the transaction will either be
    canceled with a SIP_CANCEL or completed followed immediately by a BYE.  Attempting to do
    this any other way is incorrect.  If the endpoint is not responding to the INVITE request,
    the INVITE must continue to be retransmitted until it times out which will result in the
    dialog being destroyed.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@283692 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-26 15:26:37 +00:00
David Vossel
e781f27150 Merged revisions 283594 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r283594 | dvossel | 2010-08-25 17:56:42 -0500 (Wed, 25 Aug 2010) | 7 lines
  
  Add to and from tags to NOTIFY dialog-info xml body so pickup can occur.
  
  When pedantic mode is used, the dialog-info xml generated during a
  ringing event must contain the to and from tag values.  Otherwise if
  a pickup occurs using INVITE with replaces, Astrisk will not be able
  to locate the subscription.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@283595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-25 22:57:56 +00:00
David Vossel
8ae2b6a612 Merged revisions 283558 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r283558 | dvossel | 2010-08-25 10:52:54 -0500 (Wed, 25 Aug 2010) | 10 lines
  
  Asterisk will not advertise session timers are supported when 'session-timers=refuse' is used.
  
  Asterisk now dynamically builds the "Supported" header depending
  on what is enabled/disabled in sip.conf.  Session timers used
  to always be advertised as being supported even when they were disabled
  in the configuration.  This caused problems with some end points.
  
  (issue #17005)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@283559 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-25 15:54:11 +00:00
Russell Bryant
abca511f03 Convert ast_log(LOG_DEBUG, ...) to ast_debug(...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@283527 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-25 14:55:00 +00:00
Leif Madsen
5c82781efe Fix issue where TOS is no longer set on RTP packets.
Fix issue where the tos is no longer being set on RTP packets through res_rtp_asterisk.

(closes issue #17890)
Reported by: elguero
Patches:
      qos_18.diff uploaded by elguero (license 37)

Review: https://reviewboard.asterisk.org/r/868

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@283457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-24 18:56:29 +00:00
David Vossel
6f3a4b0511 Merged revisions 283381 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r283381 | dvossel | 2010-08-24 11:07:37 -0500 (Tue, 24 Aug 2010) | 18 lines
  
  Merged revisions 283380 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r283380 | dvossel | 2010-08-24 11:01:51 -0500 (Tue, 24 Aug 2010) | 11 lines
    
    This fix makes sure the ast_channel hangs up correctly when the dialog's PENDING_BYE flag is set.
    
    When the pending bye flag is used, it is possible that the dialog will terminate
    and leave the sip_pvt->owner channel up.  This is because we never hangup the
    ast_channel after sending the SIP_BYE request.  When we receive the response for
    the SIP_BYE we set need_destroy which we would expect to destroy the dialog on the
    next do_monitor loop, but this is not the case.  The dialog will only be destroyed
    once the owner is hungup even with the need_destroy flag set.  This patch sets the
    softhangup flag on the ast_channel when a SIP_BYE request is sent as a result of the
    pending bye flag.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@283382 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-24 16:11:18 +00:00
David Vossel
e9a51ba86b Merged revisions 282894 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r282894 | dvossel | 2010-08-19 16:05:54 -0500 (Thu, 19 Aug 2010) | 18 lines
  
  Merged revisions 282893 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r282893 | dvossel | 2010-08-19 16:03:24 -0500 (Thu, 19 Aug 2010) | 11 lines
    
    tos_sip option was not being set correctly
    
    When tos_sip is used, the tos of the sip socket is only set
    correctly if the socket binding changes on a reload.  If the binding
    stays the same but the TOS changes, the new tos value would not take
    into effect.  This patch fixes that.
    
    
    (closes issue #17712)
    Reported by: nickb
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@282895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-19 21:07:20 +00:00
David Vossel
af6e8a5abb Merged revisions 282890 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r282890 | dvossel | 2010-08-19 15:31:22 -0500 (Thu, 19 Aug 2010) | 5 lines
  
  fixes sip peer memory leaks in the peer_by_ip table
  
  (issue #17798)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@282891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-19 20:34:41 +00:00
Matthew Nicholson
d4cc26fa1e Merged revisions 282859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r282859 | mnicholson | 2010-08-19 14:44:00 -0500 (Thu, 19 Aug 2010) | 23 lines
  
  Merged revisions 277944 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r277944 | pabelanger | 2010-07-19 15:56:07 -0500 (Mon, 19 Jul 2010) | 16 lines
    
    Regression with T.38 negotiation
    
    Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
    of the reporter.  
    
    (issue #16852)
    Reported by: cfc
    
    (closes issue #16705)
    Reported by: mpiazzatnetbug
    Patches:
          issue16705_2.diff uploaded by ebroad (license 878)
    Tested by: vrban, ebroad, c0rnoTa, samdell3
    
    Review: https://reviewboard.asterisk.org/r/754/
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@282860 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-08-19 20:01:11 +00:00