Commit Graph

3945 Commits

Author SHA1 Message Date
Tilghman Lesher
759dc00599 Issue 10005 - Segfault with missing arguments, plus fix a missing define for SIP INFO channels
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69796 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 19:48:17 +00:00
Joshua Colp
a50bc6e3a8 Don't count RTP timeout when involved in a T38 fax session. (issue #9222 reported by ivoc)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69794 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 19:00:50 +00:00
Joshua Colp
f95038d97e Merged revisions 69765 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r69765 | file | 2007-06-18 14:13:03 -0400 (Mon, 18 Jun 2007) | 2 lines

Set the peer name on the dialog to the one configured in sip.conf and NOT the username to be used for authentication attempts. (issue #9967 reported by achauvin)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69775 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 18:18:12 +00:00
Joshua Colp
009f6f9112 Don't defer the BYE till later on a transfer when the transfer itself goes kaboom and has no hope of working.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69668 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 16:04:55 +00:00
Joshua Colp
3e29d89200 Few minor transfer tweaks. We can't unlock something we never locked, and better handle a specific scenario with doing an attended transfer between two non-bridged calls.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69661 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 15:46:32 +00:00
Joshua Colp
2c9ffadffb Fix issue where it would be possible for the negotiated codecs to get set back to nothing. (issue #9992 reported by yehavi)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69625 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 13:55:00 +00:00
Kevin P. Fleming
ae82d97c6d use ast_localtime() in every place localtime_r() was being used
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 21:50:40 +00:00
Joshua Colp
b86b8229c8 Whoops...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69222 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 21:19:27 +00:00
Joshua Colp
9604f04ed5 Let's make chan_iax2 media only native transfers actually work. (issue #9376 reported by simone cittadini)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 21:17:28 +00:00
Joshua Colp
7572eb866a Add TXMEDIA to list so that it is properly displayed during iax2 packet output.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69184 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 19:58:59 +00:00
Russell Bryant
93f3abb3e8 Move the logic for destroying a call when no response is received to a BYE
outside of the block that checks for FLAG_FATAL to be set.  This flag is only
set when the packet is transmitted with the reliability set to XMIT_CRITICAL
when the original packet is transmitted.  A BYE is always sent with it set
to XMIT_RELIABLE, meaning this code could never be encountered.  This resulted
in seeing some SIP channels that would never go away with the last packet
sent being a BYE.
(part of issue #9235, patch from jcmoore)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69183 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 19:57:38 +00:00
Russell Bryant
f56c3be8ad Clarify a bit of logic. This doesn't change behavior in any way, but it is
helpful when following the logic to debug problems like 9235.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 16:56:16 +00:00
Russell Bryant
0072ea9933 Fix a place where a chan_iax2 pvt struct was accessed without the lock held.
This issue was reported to me via email by Dmitry Mishchenko.  Thanks!


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 16:29:12 +00:00
Joshua Colp
200248f687 Change the full frame dropping log message to debug to avoid future bug reports.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69014 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:36:29 +00:00
Joshua Colp
9d7dae818f Schedule the sending of a PING packet a second later than previously so that it does not collide with the LAGRQ.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69012 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:26:38 +00:00
Christian Richter
48f8dc5340 Merged revisions 68732 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68732 | crichter | 2007-06-11 18:49:00 +0200 (Mo, 11 Jun 2007) | 1 line

added check for NULL Pointer when calling misdn_new. Asterisk does not allow us to create channels anymore when stop gracefully is used :). also modified the restart_indicator to 0
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68733 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 16:57:59 +00:00
Christian Richter
7d491a7c24 Merged revisions 68631 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68631 | crichter | 2007-06-11 11:18:01 +0200 (Mo, 11 Jun 2007) | 1 line

fixed problem that the dummybc chanels had no lock, checking for the lock now. Also fixed the channel restart stuff, we can now specify and restart particular channels too.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68644 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 10:29:18 +00:00
Kevin P. Fleming
f4b7a2c9cb actually remember the type/subclass of full frames that are in process
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68450 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 15:52:47 +00:00
Kevin P. Fleming
e816700d6e some improvements to the IAX2 full frame dropping logic recently added:
- use inaddrcmp(), since we have it
- output the type of frame and subclass being dropped, and the type/subclass that is already being processed (which caused the drop)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68313 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 22:14:35 +00:00
Russell Bryant
e7cb53e8b2 Fix loading persistent queue members when using realtime configuration for queues.
Also, remove an unneeded leading slash for the astdb family.
(issue #9911, patch by atis)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 21:16:07 +00:00
Jason Parker
51f1d28d2d Fix an issue with newer phones which require packets be padded out to the correct length.
Issue 9887, patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:25:18 +00:00
Olle Johansson
2d491b0eae Disable chan_features by default in menuselect
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:46:10 +00:00
Joshua Colp
b58a48d672 Merged revisions 67938 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67938 | file | 2007-06-06 20:09:13 -0400 (Wed, 06 Jun 2007) | 2 lines

Only notify the devicestate system of a peer state change when the peer is built from the config file. (issue #9900 reported by arkadia)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67941 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 00:10:48 +00:00
Russell Bryant
6595debbc5 Fix a crash when doing call pickups with SIP phones. The code unlocked the
channel when it should not have.
(issue #9652, reported by corruptor, fixed by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 21:14:46 +00:00
Russell Bryant
83744c244a Suppress a bunch of debug output unless option_debug is on
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 19:48:02 +00:00
Jason Parker
4a7ae2ebde Correctly update date/time on devices throughout the life of the device, instead of just at registration.
Issue 9152, yet another patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 18:18:24 +00:00
Christian Richter
619cdb016a Merged revisions 67307 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67307 | crichter | 2007-06-05 17:42:03 +0200 (Di, 05 Jun 2007) | 1 line

briding is a bool, fixed copy and paste issue.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67334 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 16:14:07 +00:00
Christian Richter
b0dd31cb52 Merged revisions 67306 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67306 | crichter | 2007-06-05 17:39:43 +0200 (Di, 05 Jun 2007) | 1 line

simplified the EVENT_SETUP handling in the cb_events function a lot. Commented the different possibilities a bit and made functions of shared code. When the dialed extension does not exist in the extensions.conf we'll jump into the 'i' extension if this does exist, else we disconnect the call with the cause:1 = No Route to Destination.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 16:11:57 +00:00
Joshua Colp
24922406f4 Only muck with the thread structure if an idle one was found/created.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67304 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 15:22:30 +00:00
Kevin P. Fleming
5a5d549b1d ensure that a burst of full frames (AST_FRAME_DTMF being the prime example) will not be processed out of order... this is a brute force fix, but seems to be the safest fix for now (thanks to the Digium PQ department for finding this bug)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67270 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 14:35:52 +00:00
Christian Richter
9f749257ef Merged revisions 67209 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67209 | crichter | 2007-06-05 12:05:45 +0200 (Di, 05 Jun 2007) | 1 line

added possibility to deactivate bridging per port
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67210 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 10:25:32 +00:00
Russell Bryant
3b5bd316ed Fix up a bunch of places where the iax2 pvt structure can disappear and the
code did not account for it and crashes.
(issues #9642, #9569, #9666, probably others ... based on the work by
 stevedavies and mihai, with additional changes from me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 23:31:40 +00:00
Jason Parker
0b7607ad55 Fix for skinny keepalives.
If there is no traffic from the phone for (keep_alive * 1100) ms (arbitrarily
 adding 10% for network issues, etc),  unregister the device.

Issue 8394, patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67156 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 23:26:28 +00:00
Jason Parker
6b150d7b9c Fixes for dtmf/dialing with mgcp (similar to the recent fix for chan_skinny)
Issue 9855, patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 22:36:57 +00:00
Russell Bryant
885d846739 Add comments for two functions that get called with the appropriate call locked,
but perform operations that could result in the pvt structure getting destroyed
before returning again, causing numerous seg faults all over the module.
(inspired by issues #9642, #9569, and #9666, and the work done by stevedavies
 and mihai)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67119 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 22:28:55 +00:00
Joshua Colp
01456184f9 Better handle SIP devices that say they have SDP content... but really don't. (issue #9398 reported by mthomasslo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67068 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 19:31:09 +00:00
Russell Bryant
0b7719e9a1 Resolve a deadlock in chan_iax2. When handling an implicit ACK to a frame that
was marked as the final transmission for a call, don't call iax2_destroy() for
that call while the global frame queue is still locked.  There is a very nice
explanation of the deadlock in the report.
(issue #9663, thorough report and patch from stevedavies, additional positive
 test reports from mihai and joff_oconnell)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67020 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:47:40 +00:00
Russell Bryant
0ecb2ecf42 Changes to the way DTMF is handled in the core broke dialing in chan_skinny.
This patch makes chan_skinny usable again.  I did not end up testing this,
but there are multiple positive test reports listed in the bug report.
(issue #9596, reported by pj, testing by pj and mvanbaak, and the fix was
 written by DEA)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66881 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-01 19:41:30 +00:00
Joshua Colp
c7112015ba Merged revisions 66764 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r66764 | file | 2007-05-31 12:12:39 -0400 (Thu, 31 May 2007) | 2 lines

It is now possible for this path of execution to have the frame pointer be NULL, therefore we need to check for it before trying to access it. (issue #9836 reported by barthpbx)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66768 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 16:14:48 +00:00
Joshua Colp
612f61a9b2 Silly me for having out of date source! Oh well... I'm still leaving my comment.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66639 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 17:28:12 +00:00
Joshua Colp
3d8d697e34 When calling some peer/host that may not exist/reply back... don't keep the dialog in memory for all of eternity.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66637 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 17:21:06 +00:00
Joshua Colp
7905fca326 Change how channel names are generated a bit. (issue #9825 reported by eldadran)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66602 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-30 16:06:37 +00:00
Olle Johansson
332eabcc07 Properly handle 408 request timeout - according to the RFC, the dialog dies if a request in a dialog gets this response.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66503 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 19:32:57 +00:00
Olle Johansson
8d06f379fe Don't issue hangup on hangup on hangup on hangup (for jcmoore)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66474 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 19:02:04 +00:00
Olle Johansson
9f15005143 Don't reset hangupcause if we already have one
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 16:07:44 +00:00
Olle Johansson
ff9e2751c6 Tracking down hanging channels, killing them one by one. Issue #9235 and related
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66404 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 16:02:50 +00:00
Olle Johansson
bab6473879 Merged revisions 66349 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r66349 | oej | 2007-05-29 09:53:14 +0200 (Tue, 29 May 2007) | 2 lines

Issue #9802 - Change inuse counter on CANCEL

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66363 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-29 09:41:40 +00:00
Joshua Colp
3a5a649415 Make the usedistinctiveringdetection option work again. (issue #9823 reported by premeau)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-28 23:16:56 +00:00
Jason Parker
a8ab3e5738 I don't know what this was trying to do, but it's clearly incorrect.
Issues 9808 and 9809.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66244 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-27 04:12:37 +00:00
Kevin P. Fleming
5f9897ba56 handle the GNUTLS library properly in the configure script and build system
don't build in OSP support unless we have found and are allowed to use SSL support


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66157 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-25 14:28:46 +00:00