Commit Graph

37 Commits

Author SHA1 Message Date
Kevin P. Fleming
add5ff5b05 fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@153337 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-01 18:22:39 +00:00
Sean Bright
0fa63ffb6f Use PATH_MAX for filenames
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@135597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-05 13:25:00 +00:00
Tilghman Lesher
1a73396c9d When showing an error message for a command, don't shorten the command output,
as it tends to confuse the user (it's fine for suggesting other commands,
however).
 Reported by: seanbright (on #asterisk-dev)
 Fixed by: me


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@118551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-27 19:15:27 +00:00
Jason Parker
3b966ed04e Correctly display a message if a command could not be found.
Also fix a comment which may have led to this happening.

Issue 11718, reported by kshumard.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97622 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 20:28:43 +00:00
Jason Parker
5583996b22 Fix some locking and return value funkiness. We really shouldn't be unlocking this lock inside of a function, unless we locked it there too.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97618 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 20:05:45 +00:00
Tilghman Lesher
1f14e0cf39 Allow filename completion on zero-length modules, remove a memory leak, remove
a file descriptor leak, and make filename completion thread-safe.
Patched and tested by tilghman.
(Closes issue #11681)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 00:44:14 +00:00
Russell Bryant
bad30446a6 Fix an issue with console verbosity when running asterisk -rx to execute a command
and retrieve its output.  The issue was that there was no way for the main Asterisk
process to know that the remote console was connecting in the -rx mode.  The way that
James has fixed this is to have all remote consoles muted by default.  Then, regular
remote consoles automatically execute a CLI command to unmute themselves when they
first start up.

(closes issue #10847)
Reported by: atis
Patches: 
      asterisk-consolemute.diff.txt uploaded by jamesgolovich (license 176)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85533 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-13 05:48:10 +00:00
Russell Bryant
6c18b111b9 Properly handle the case where read() may return the text for more than one
CLI command at once for a remote console.

(closes issue #10888)
Reported by: jamesgolovich
Patches: 
      asterisk-climultiple.diff.txt uploaded by jamesgolovich (license 176)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-13 05:24:33 +00:00
Joshua Colp
97885fed58 (closes issue #10351)
Reported by: ftarz
Some platforms don't like it when you pass NULL to vsnprintf so pass "" instead.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-01 18:08:51 +00:00
Joshua Colp
1d4adc0174 Merged revisions 61804 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r61804 | file | 2007-04-25 14:52:50 -0400 (Wed, 25 Apr 2007) | 2 lines

Merge rewritten group counting support. No more storing data on the variable list of the channels. That was bad, mmmk? (issue #7497 reported by sabbathbh)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61805 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-25 19:21:54 +00:00
Joshua Colp
58ce1edf27 Print out deprecation notice on usage output of CLI commands. (issue #8925 reported by blitzrage)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56008 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-22 00:35:55 +00:00
Paul Cadach
39d6429a35 Bring deprecated 'debug channel <x|all>' command back
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53878 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-10 09:04:47 +00:00
Jason Parker
65565ac74d Fix an issue with file name completion in "module load" and "load".
Issue 8846


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-18 18:42:00 +00:00
Jason Parker
281b1a890c Re-add CLI command that should have only been deprecated in 1.4.
Thanks kshumard!  (reported in person, so no associated issue #)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-09 17:11:53 +00:00
Jason Parker
52fb756adc Fix some deprecated commands.
Issue 8682, patch by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-28 21:26:04 +00:00
Tilghman Lesher
a78cc926d4 Double-unlock error (reported by blitzrage on IRC)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-01 19:38:59 +00:00
Luigi Rizzo
a9057b2c65 fix longest match search in find_cli.
Trunk already fixed.

1.2 not affected (well, i have no idea, the code is totally
different there).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 17:46:45 +00:00
Tilghman Lesher
6e4d0e50c8 Re-enable old deprecated commands
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47573 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:11:15 +00:00
Joshua Colp
6351e6bb2c Free full command string upon unregistering of CLI command. Backported from revision 47536 from rizzo.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 16:30:38 +00:00
Tilghman Lesher
f11ea0549d Discussion of these CLI changes resulted in more consistency (Bug 8236)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 16:51:55 +00:00
Russell Bryant
5654be2803 fix tab completion for "core debug channel" and "core no debug channel"
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47377 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 16:28:15 +00:00
Russell Bryant
795ba043e2 Fix "core show channel". Also, fix tab completion for both "core show channel"
and "core show channels".


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47375 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 16:24:02 +00:00
Russell Bryant
6609cebaf2 Fix "core debug channel <whatever>". I guess someone needs to go through and
audit every CLI command that changed number of arguments ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47372 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 16:18:33 +00:00
Russell Bryant
0b927d2208 Fix another CLI command, "core show uptime" ...
(issue #8323, reported by johnlange, fixed by myself)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47366 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-09 15:49:39 +00:00
Russell Bryant
c8ee894823 Fix another bug in "core set debug" ...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 18:10:22 +00:00
Russell Bryant
789234df2d Really fix the "core set debug" and "core set verbose" CLI commands.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 17:59:39 +00:00
Russell Bryant
da6cf383d4 fix the "atleast" option to the "core set verbose" and "core set debug"
CLI commands


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 17:38:24 +00:00
Tilghman Lesher
e05a2752e8 Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 23:00:20 +00:00
Kevin P. Fleming
ce4b0afb73 apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 14:32:08 +00:00
Jason Parker
2a5feb5485 Fix a bug with the removal of 'atleast' argument to 'core verbose' and 'core debug'.
Add that argument back in.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-29 22:35:09 +00:00
Kevin P. Fleming
c2475110cc proper fix for ast_group_t change
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43978 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-29 13:45:40 +00:00
Joshua Colp
cdf62550ed Warning be gone!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43913 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 17:14:07 +00:00
Kevin P. Fleming
81c8f6b539 Merged revisions 43895 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r43895 | kpfleming | 2006-09-28 11:32:44 -0500 (Thu, 28 Sep 2006) | 2 lines

eliminate compiler warning introduced by recent changes

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43898 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:38:25 +00:00
Joshua Colp
2862b777fe Merged revisions 43705 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r43705 | file | 2006-09-26 16:38:06 -0400 (Tue, 26 Sep 2006) | 2 lines

Use proper type to represent the group variable (issue #8025 reported by makoto)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43707 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:47:26 +00:00
Jason Parker
408d4b978f Make sure we explicitly set the CLI command to not be deprecated, if it isn't.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-22 17:25:05 +00:00
Kevin P. Fleming
fcb999c01c merge qwell's CLI verbification work
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 19:54:18 +00:00
Kevin P. Fleming
0a27d8bfe5 merge new_loader_completion branch, including (at least):
- restructured build tree and makefiles to eliminate recursion problems
  - support for embedded modules
  - support for static builds
  - simpler cross-compilation support
  - simpler module/loader interface (no exported symbols)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-21 02:11:39 +00:00