Commit Graph

11108 Commits

Author SHA1 Message Date
Kevin P. Fleming
e816700d6e some improvements to the IAX2 full frame dropping logic recently added:
- use inaddrcmp(), since we have it
- output the type of frame and subclass being dropped, and the type/subclass that is already being processed (which caused the drop)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68313 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 22:14:35 +00:00
Russell Bryant
e7cb53e8b2 Fix loading persistent queue members when using realtime configuration for queues.
Also, remove an unneeded leading slash for the astdb family.
(issue #9911, patch by atis)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 21:16:07 +00:00
Jason Parker
51f1d28d2d Fix an issue with newer phones which require packets be padded out to the correct length.
Issue 9887, patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:25:18 +00:00
Jason Parker
1d704b2857 Merged revisions 68204 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68204 | qwell | 2007-06-07 15:02:50 -0500 (Thu, 07 Jun 2007) | 4 lines

Don't try to save voicemail greetings unless the user presses '1' to accept/save.

Issue 9904, patch by me.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68211 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:06:00 +00:00
Mark Michelson
878e480ff8 Submitting a fix for Issue 8016. Added a check to make sure that greetings get stored properly.
(Issue 8016, reported by edhorton, patched by alamantia with modification by me. Thanks to Jason Parker
for the advice on this).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:47:42 +00:00
Olle Johansson
2d491b0eae Disable chan_features by default in menuselect
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:46:10 +00:00
Russell Bryant
452167fa3c Include stdarg.h for build issues on Solaris
(issue #9381)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:30:30 +00:00
Joshua Colp
ac65d7f143 Fix logic when doing a name based channel search for a structure when you want to start from a specific point in the channel list. (issue #9324 reported by slavon)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68157 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 18:39:52 +00:00
Joshua Colp
f07dfca43a Merged revisions 68070 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68070 | file | 2007-06-07 10:19:40 -0400 (Thu, 07 Jun 2007) | 2 lines

Allow the 'g' option to work if used with the 'S' option. (issue #9888 reported by gasparz)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 14:21:59 +00:00
Olle Johansson
64b3683dbe Adding a few Todo's to res_jabber so we don't forget.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68030 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 10:00:17 +00:00
Olle Johansson
b857aed39e Ok, we found out that this is not about if you have any *active* clients using TLS, but
if you have initialized TLS at all during the lifetime of the module. So if you reload
to disable TLS, it won't help.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:55:13 +00:00
Olle Johansson
dd7f6f8e21 If you have a jabber client that uses TLS, refuse unload. Bad fix, but will prevent
crashes while we are trying to find a workaround.

Iksemel development seems to have stalled and we might have to stop using the 
TCP/TLS connections in that library and use our own, which would scale better
from a poll/select perspective I guess. It would also make it easier to migrate
to OpenSSL and stop Asterisk from depending on both OpenSSL and GnuTLS.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:42:26 +00:00
Olle Johansson
ff2943dd59 Issue #9738 - Make sure we can unload res_jabber. Patch by phsultan - thanks!
Due to a bug in the iksemel library, this will not work if you are using GTLS
in the connection. That's being investigated. If you figure out a way to handle
that without us having to patch iksemel, let us know in the bug report. Thanks.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:00:44 +00:00
Joshua Colp
b58a48d672 Merged revisions 67938 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67938 | file | 2007-06-06 20:09:13 -0400 (Wed, 06 Jun 2007) | 2 lines

Only notify the devicestate system of a peer state change when the peer is built from the config file. (issue #9900 reported by arkadia)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67941 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 00:10:48 +00:00
Joshua Colp
928e69408e Properly handle cases where a stream can't be written to. (issue #9757 reported by junky)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67924 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 23:38:15 +00:00
Russell Bryant
b310d22e7c Disable reload functionality in res_snmp. It is not possible to initialize the
snmp library more than once without completely unloading the module and loading
it again.
(issue #9571, reported by hristo, additional helpful debug information from festr,
 patch from me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 22:08:02 +00:00
Russell Bryant
6595debbc5 Fix a crash when doing call pickups with SIP phones. The code unlocked the
channel when it should not have.
(issue #9652, reported by corruptor, fixed by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 21:14:46 +00:00
Mark Michelson
e8900612be Fix for Issue 9810. There was a segfault under a specific set of circumstances:
1. VoiceMailMain was configured in the dialplan with an extension as its argument
2. A message was left for this mailbox
3. Tried to call VoiceMailMain but hung up before entering password.

This was fixed by checking that a pointer was non-null prior to trying to dereference it.
(Issue 9810, reported by xmarksthespot, patched by Corydon76 with modifications by me).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 19:26:55 +00:00
Russell Bryant
e7dd69eea8 Merged revisions 67715 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67715 | russell | 2007-06-06 11:40:51 -0500 (Wed, 06 Jun 2007) | 5 lines

We have some bug reports showing crashes due to a double free of a channel.
Add a sanity check to ast_channel_free() to make sure we don't go on trying
to free a channel that wasn't found in the channel list.
(issue #8850, and others...)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 16:55:59 +00:00
Joshua Colp
1f6872a45e Merged revisions 67649 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67649 | file | 2007-06-06 09:28:34 -0400 (Wed, 06 Jun 2007) | 2 lines

Reinvite the RTP back to the Asterisk machine when the timeout happens. (issue #9888 reported by gasparz)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67650 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:30:25 +00:00
Joshua Colp
7fb76769a8 Fix plc_samples warning when registering a translator. (issue #9897 reported by xylome)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:18:39 +00:00
Joshua Colp
a4ebf8b608 Include macroexten while searching for a channel to pick up in case they are in a macro. (issue #9491 reported by jamesb63)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67626 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:16:34 +00:00
Joshua Colp
ed7775bc53 Make the new "agi debug off" CLI command work. (issue #9890 reported by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 12:34:06 +00:00
Joshua Colp
26268d3a9a Merged revisions 67593 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67593 | file | 2007-06-06 08:18:36 -0400 (Wed, 06 Jun 2007) | 2 lines

Revert channel name splitting fix for Zap. The moral of the story is don't use - in your user/peer names. (issue #9668 reported by stevedavies)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 12:20:27 +00:00
Russell Bryant
1a3e65a793 Fix some crashes related to the use of the "meetme" CLI command. The code for
this command was not locking the conference list at all.
(issue #9351, reported by and patch submitted by Junk-Y, committed patch
 is different and by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67558 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 23:01:44 +00:00
Steve Murphy
dc63d79143 this fixes bug 9883, wherein macros were not allowing the includes construct. fixed and tested, looks OK. Now includes can serve as an adjunct to catch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 21:30:18 +00:00
Russell Bryant
fe9a3bef4e This bug has been hanging over my head ever since I wrote this SLA code.
Every time I tried to go debug it by adding some debug output, the behavior
would change.  It turns out I wasn't crazy.  I had the following piece of code:

   if (remove)
      AST_LIST_REMOVE_CURRENT(...);

Well, AST_LIST_REMOVE_CURRENT was not wrapped in braces, so my conditional
statement didn't do much good at all.  It always ran at least all of the
macro minus the first statement, so I was seeing list entries magically
disappear when they weren't supposed to.

After many hours of debugging, I have come to this extremely irritating fix. :)

(issues #9581, #9497)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 20:53:28 +00:00
Russell Bryant
83744c244a Suppress a bunch of debug output unless option_debug is on
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 19:48:02 +00:00
Mark Michelson
0a49a913ed Fix for bug number 9786, wherein voicemails saved to IMAP storage using extensions other than gsm were
unable to be played over the phone. (Issue 9786, reporter: xmarksthespot, Patched by xmarksthe spot with revisions by me,
reviewed by Russell Bryant).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 18:32:50 +00:00
Jason Parker
4a7ae2ebde Correctly update date/time on devices throughout the life of the device, instead of just at registration.
Issue 9152, yet another patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 18:18:24 +00:00
Steve Murphy
b698ff265b Added code to automatically add a default case to switches that don't have one. In some cases, rather than fall thru, it results in a goto with -1 result, which terminates the extension; a sort of dialplan seqfault, sort of. This was required to fix bug reported in 9881
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 18:17:28 +00:00
Russell Bryant
9dd7be2f58 Handle a failure in malloc() in ast_safe_string_alloc()
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67372 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 17:07:30 +00:00
Russell Bryant
6d6cd29a87 Fix a problem that showed itself by causing Zap channel names to be completely
bogus on my machine.  ast_safe_string_alloc() was broken.  It called 
vsnprintf() on a va_args list twice without re-initializing it.  After the first
usage, va_end() and va_start() must be called again.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67360 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 16:56:36 +00:00
Christian Richter
619cdb016a Merged revisions 67307 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67307 | crichter | 2007-06-05 17:42:03 +0200 (Di, 05 Jun 2007) | 1 line

briding is a bool, fixed copy and paste issue.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67334 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 16:14:07 +00:00
Christian Richter
b0dd31cb52 Merged revisions 67306 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67306 | crichter | 2007-06-05 17:39:43 +0200 (Di, 05 Jun 2007) | 1 line

simplified the EVENT_SETUP handling in the cb_events function a lot. Commented the different possibilities a bit and made functions of shared code. When the dialed extension does not exist in the extensions.conf we'll jump into the 'i' extension if this does exist, else we disconnect the call with the cause:1 = No Route to Destination.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 16:11:57 +00:00
Russell Bryant
d5fd0cff73 When shutting down "gracefully", go through and run the unload() callbacks for
all of the modules.  "stop now" is considered a non-graceful shutdown and will
not go through this process.
(issue #9804, reported by chrisost, patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67308 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 15:51:53 +00:00
Joshua Colp
24922406f4 Only muck with the thread structure if an idle one was found/created.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67304 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 15:22:30 +00:00
Kevin P. Fleming
5a5d549b1d ensure that a burst of full frames (AST_FRAME_DTMF being the prime example) will not be processed out of order... this is a brute force fix, but seems to be the safest fix for now (thanks to the Digium PQ department for finding this bug)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67270 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 14:35:52 +00:00
Christian Richter
9f749257ef Merged revisions 67209 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67209 | crichter | 2007-06-05 12:05:45 +0200 (Di, 05 Jun 2007) | 1 line

added possibility to deactivate bridging per port
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67210 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 10:25:32 +00:00
Tilghman Lesher
cb8813a250 Merged revisions 67161 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67161 | tilghman | 2007-06-04 18:41:49 -0500 (Mon, 04 Jun 2007) | 2 lines

According to MATH, 0+1181000386 = 1181000448.  Oops.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67162 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 23:43:01 +00:00
Russell Bryant
3b5bd316ed Fix up a bunch of places where the iax2 pvt structure can disappear and the
code did not account for it and crashes.
(issues #9642, #9569, #9666, probably others ... based on the work by
 stevedavies and mihai, with additional changes from me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 23:31:40 +00:00
Jason Parker
0b7607ad55 Fix for skinny keepalives.
If there is no traffic from the phone for (keep_alive * 1100) ms (arbitrarily
 adding 10% for network issues, etc),  unregister the device.

Issue 8394, patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67156 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 23:26:28 +00:00
Jason Parker
6b150d7b9c Fixes for dtmf/dialing with mgcp (similar to the recent fix for chan_skinny)
Issue 9855, patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 22:36:57 +00:00
Russell Bryant
885d846739 Add comments for two functions that get called with the appropriate call locked,
but perform operations that could result in the pvt structure getting destroyed
before returning again, causing numerous seg faults all over the module.
(inspired by issues #9642, #9569, and #9666, and the work done by stevedavies
 and mihai)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67119 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 22:28:55 +00:00
Steve Murphy
7609f70e20 This typo has been here since 1.4 forked. It has been the source of heartburn to many a dialplan/CDR programmer.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67073 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 21:59:34 +00:00
Russell Bryant
9074935852 Add a missing \n. (pointed out by jcmoore on IRC)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 21:47:36 +00:00
Joshua Colp
01456184f9 Better handle SIP devices that say they have SDP content... but really don't. (issue #9398 reported by mthomasslo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67068 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 19:31:09 +00:00
Joshua Colp
1317920054 Initialize cidname variable to nothing since it may be used without having been touched. (issue #9661 reported by dimas)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 17:59:14 +00:00
Joshua Colp
26038a4b77 Returning a value that indicates the parking of a call was a success when it really wasn't (because the parking slot selected was in use) is the wrong thing to do. (issue #9723 reported by mdu113)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67064 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 17:41:59 +00:00
Tilghman Lesher
85779f9c3a Merged revisions 67060 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67060 | tilghman | 2007-06-04 12:10:30 -0500 (Mon, 04 Jun 2007) | 2 lines

Add revision Id tags (by request of tzafrir)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67061 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 17:11:43 +00:00