Commit Graph

8 Commits

Author SHA1 Message Date
Sean Bright
509c3ebaf7 app_queue: Support persisting and loading of long member lists.
Greenlight in #asterisk brought up that he was receiving an error message "Could
not create persistent member string, out of space" when running app_queue in
Asterisk 10.  dump_queue_members() made an assumption that 8K would be enough to
store the generated string, but with queues that have large member lists this is
not always the case.  This patch removes the limitation and uses ast_str instead
of a fixed sized buffer.

The complicating factor comes from the fact that ast_db_get requires a buffer
and buffer size argument, which doesn't let us pull back more than what we pass
in, so I introduced a new ast_db_get_allocated() which returns an ast_strdup()'d
copy of the value from astdb.

As an aside, I did some testing on the maximum size of data that we can store in
the BDB library we distribute and was able to store a 10MB string and retrieve
it with no problems, so I feel this is a safe patch.

Review: https://reviewboard.asterisk.org/r/2136/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@374108 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2012-10-01 16:45:53 +00:00
Jason Parker
23acd67877 Test modules have a support level of core.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@338551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-09-29 20:54:13 +00:00
Jason Parker
529ab3ad50 Add support levels to non-module sections of menuselect (cflags, utils, etc).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@338227 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-09-28 20:52:47 +00:00
Paul Belanger
1fc32a652e Flag test modules as 'core'
Review: https://reviewboard.asterisk.org/r/1369/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@332176 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-08-16 20:10:13 +00:00
Terry Wilson
78705b5922 Remove now-useless cast of ARRAY_LEN
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@323866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-06-15 20:03:58 +00:00
Terry Wilson
ae4997f3f6 Fix more ARRAY_LEN format string issues
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@323859 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-06-15 19:45:20 +00:00
Terry Wilson
fcf2c4c6a2 Cast ARRAY_LEN to size_t for ast_logging
32-bit and 64-bit machines return different types for ARRAY_LEN(), so cast
it before using in a format string.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@323672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-06-15 17:09:51 +00:00
Terry Wilson
7ba8589b33 Add some astdb unit tests
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@322923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-06-10 02:33:23 +00:00