Commit Graph

5685 Commits

Author SHA1 Message Date
Mark Michelson
4d983e34cf INVITES with proxy auth were sent with a different branch
than what was in the invite_branch of a sip_pvt, meaning
that if a CANCEL were sent later, the branch in the CANCEL
would not match the branch in the latest INVITE sent out, leading
to some endpoints responding to the CANCEL with a 481.

(closes issue #13714)
Reported by: fnordian
Patches:
      invite_branch.patch uploaded by fnordian (license 110)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150207 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 20:57:18 +00:00
Richard Mudgett
de9c5d4c42 Merged revisions 150124 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r150124 | rmudgett | 2008-10-16 10:56:06 -0500 (Thu, 16 Oct 2008) | 1 line
  
  Fix memory leak found by customer
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 16:04:45 +00:00
Kevin P. Fleming
2f3193ec70 ensure that type=peer entries are only matched on IP/port, not on name (after oej audits all the calls to find_peer() to make sure that forcenamematch is set correctly in each case)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 15:02:10 +00:00
Olle Johansson
11a94d5b01 Doxygen addition
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 15:00:30 +00:00
Olle Johansson
1d2ef991e2 Add some notes on problems with the TCP/TLS implementation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150008 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 13:52:23 +00:00
Kevin P. Fleming
4ca2b3836a return this logic to where it used to be, *after* the dialog->needdestroy flag has been determined to be set; otherwise, we generate these debug messages every time we inspect every active dialog
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149981 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 13:28:56 +00:00
Kevin P. Fleming
1e56eb7e87 some additional debugging tools added at SIPit23:
- move all setting of 'needdestroy' on dialog structures into the history

- report all tags involved when a pedantic check fails on a REFER



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 13:23:23 +00:00
Mark Michelson
e701f8ee2d Make the sip_proxy struct reference counted. This is
necessary to allow for a sip_pvt to maintain a reference
to a sip_peer's outboundproxy even after the peer has
been freed.

(closes issue #13700)
Reported by: fnordian
Patches:
      13700.patch uploaded by putnopvut (license 60)
Tested by: fnordian



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 20:55:42 +00:00
Olle Johansson
216673ad76 Adding a note about a missing part of "kill-the-user" - I got lost in the Ao2 world...
We're going to try to get time to fix this and kpfleming believes that there's code in ao2 
so that we can solve it...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 13:52:13 +00:00
Kevin P. Fleming
f00735b317 Merged revisions 149452 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r149452 | kpfleming | 2008-10-15 12:30:40 +0200 (Wed, 15 Oct 2008) | 3 lines
  
  fix some problems when parsing SIP messages that have the maximum number of headers or body lines that we support
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 11:26:36 +00:00
Olle Johansson
7fa8f65425 Fixing sytax errors ;-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149342 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 07:45:09 +00:00
Mark Michelson
63b894e391 Merged revisions 149266 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r149266 | mmichelson | 2008-10-14 18:43:58 -0500 (Tue, 14 Oct 2008) | 4 lines

Change this warning to an error message. Suggestion
comes from Sean Bright. Thanks Sean!


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149271 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 23:44:44 +00:00
Mark Michelson
83663de0ed Merged revisions 149207 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r149207 | mmichelson | 2008-10-14 18:10:26 -0500 (Tue, 14 Oct 2008) | 9 lines

Call register_peer_exten even in the case that the peer's
IP/port does not change.

(closes issue #13309)
Reported by: dimas
Patches:
      v2-13309.patch uploaded by dimas (license 88)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149208 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 23:15:04 +00:00
Tilghman Lesher
d5837ba8c2 Add additional memory debugging to several core APIs, and fix several memory
leaks found with these changes.
(Closes issue #13505, closes issue #13543)
Reported by: mav3rick, triccyx
 Patches: 
       20081001__bug13505.diff.txt uploaded by Corydon76 (license 14)
 Tested by: mav3rick, triccyx


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 22:38:06 +00:00
Mark Michelson
c6caf2a06f Merged revisions 149130 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r149130 | mmichelson | 2008-10-14 15:49:02 -0500 (Tue, 14 Oct 2008) | 7 lines

Don't allow reserved characters to be used in register
lines in sip.conf.

(closes issue #13570)
Reported by: putnopvut


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149131 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 21:08:48 +00:00
Mark Michelson
4d9965856b Merged revisions 148912 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r148912 | mmichelson | 2008-10-14 12:33:38 -0500 (Tue, 14 Oct 2008) | 9 lines

Deadlock prevention in chan_local.

(closes issue #13676)
Reported by: tacvbo
Patches:
      13676.patch uploaded by putnopvut (license 60)
Tested by: tacvbo


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148913 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 17:38:06 +00:00
Joshua Colp
f230048cd3 Fix reference count issue that Russell brought up in SIP MWI NOTIFY support. Bump the reference count up before we add it to the scheduler, duh.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 15:00:41 +00:00
Kevin P. Fleming
6ccc37dec9 fix some references to the owner of a private structure that may not be present
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 11:31:40 +00:00
Kevin P. Fleming
b616f924c6 this structure should be static
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148737 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 10:32:01 +00:00
Kevin P. Fleming
90e01fcb0b ensure that *all* fields in the req structure are cleared out before reusing it; has_to_tag was not cleared, which caused the second incoming call over a TCP socket to fail if pedantic checking was enabled
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 09:31:50 +00:00
Olle Johansson
7877ed93bb Adding some clarifications
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148679 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 09:16:59 +00:00
Olle Johansson
c3e6dbb72f - Doxygen formatting. (tss tss)
- Fixing language


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148474 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-13 15:56:33 +00:00
Olle Johansson
32d93bbc0e Highlightning even more bugs in the current tcp/tls implementation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148473 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-13 15:49:01 +00:00
Olle Johansson
1ec31a5f93 Sending a 403 after a 200 is considered very bad.
(found at SIPit)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-13 15:32:55 +00:00
Mark Michelson
399d82541a The logic used when checking a peer got changed subtly
in the "kill the user" commit and caused calls relying
on the insecure setting to not work properly. I changed
for finding a peer back to how it was prior to that 
commit.

(closes issue #13644)
Reported by: pj
Patches:
      13644_trunkv2.patch uploaded by putnopvut (license 60)
Tested by: pj



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148376 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-10 21:21:45 +00:00
Mark Michelson
1d4bb1ce59 Make sure that the inUse and inRinging fields for
a sip peer cannot go below zero. This is a regression
from 1.4 and so it will be applied to 1.6.0 as well.

(closes issue #13668)
Reported by: mjc



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148373 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-10 21:18:10 +00:00
Tilghman Lesher
8b14e5f493 Reverting format addition for now
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 21:47:02 +00:00
Tilghman Lesher
f5d5eb5e19 Fudges for wav16, just like wav49
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 21:37:23 +00:00
Michiel van Baak
5232acb8c0 fix some CLI commands we borked during devcon2008
Thanks rmudget for letting me know and providing hints on how to fix it best.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147853 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 17:01:24 +00:00
Steve Murphy
e235a07376 (closes issue #13557)
Reported by: nickpeirson
Patches:
      pbx.c.patch uploaded by nickpeirson (license 579)
      replace_bzero+bcopy.patch uploaded by nickpeirson (license 579)
Tested by: nickpeirson, murf

1. replaced all refs to bzero and bcopy to memset and memmove instead.
2. added a note to the CODING-GUIDELINES
3. add two macros to asterisk.h to prevent bzero, bcopy from creeping
   back into the source
4. removed bzero from configure, configure.ac, autoconfig.h.in




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147807 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 14:17:33 +00:00
Joshua Colp
cebd2c1df2 Add support for subscribing to a voice mailbox on a remote SIP server and making the new/old message count available to local devices. (issue #AST-77)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147760 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 01:40:49 +00:00
Kevin P. Fleming
5651afcdaa Merged revisions 147681 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r147681 | kpfleming | 2008-10-08 17:22:09 -0500 (Wed, 08 Oct 2008) | 3 lines
  
  when parsing a text configuration option, ensure that the buffer on the stack is actually large enough to hold the legal values of that option, and also ensure that sscanf() knows to stop parsing if it would overrun the buffer (without these changes, specifying "buffers=...,immediate" would overflow the buffer on the stack, and could not have worked as expected)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147689 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-08 22:26:55 +00:00
Sean Bright
d1f257ba53 Move the DAHDI-to-DAHDI operator mode check from app_dial into chan_dahdi
so we don't have to hardcode anything.

(closes issue #13636)
Reported by: seanbright
Patches:
      13636.diff uploaded by seanbright (license 71)
Reviewed by: russellb, putnopvut


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147388 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 21:34:44 +00:00
Michiel van Baak
c69a3b96b2 make this work on OpenBSD
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 19:26:09 +00:00
Terry Wilson
cfaef11e0f A blind transfer to the parking thread would cause a segfault because copy_request accesses dst->data w/o being able to tell whether it is proerly initialized
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146970 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-07 00:02:19 +00:00
Tilghman Lesher
63b165dbb9 Merged revisions 146799 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r146799 | tilghman | 2008-10-06 15:52:04 -0500 (Mon, 06 Oct 2008) | 8 lines
  
  Dialplan functions should not actually return 0, unless they have modified the
  workspace.  To signal an error (and no change to the workspace), -1 should be
  returned instead.
  (closes issue #13340)
   Reported by: kryptolus
   Patches: 
         20080827__bug13340__2.diff.txt uploaded by Corydon76 (license 14)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 21:09:05 +00:00
Tilghman Lesher
8a457d94e2 Merged revisions 146711 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r146711 | tilghman | 2008-10-06 11:51:21 -0500 (Mon, 06 Oct 2008) | 9 lines
  
  Check whether an extension exists in the _call method, rather than the _alloc
  method, because we need to evaluate the callerid (since that data affects
  whether an extension exists).
  (closes issue #13343)
   Reported by: efutch
   Patches: 
         20080915__bug13343.diff.txt uploaded by Corydon76 (license 14)
   Tested by: efutch
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146713 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-06 16:52:14 +00:00
Jason Parker
b37300a4a5 Recorded merge of revisions 146448 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r146448 | qwell | 2008-10-05 16:17:44 -0500 (Sun, 05 Oct 2008) | 1 line
  
  Fix silly formatting.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@146449 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-05 21:21:03 +00:00
Jeff Peeler
81415abc21 (closes issue #13337)
Reported by: pj
Tested by: pj

Set transport to SIP_TRANSPORT_UDP mode if not specified which fixes calls to get_transport returning UNKNOWN.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-30 22:21:19 +00:00
Russell Bryant
f1dd1fe1c7 Add support for call pickup on Snom phones. Asterisk now includes a magic
call-id in the dialog-info event package used with extension state subscriptions
on Snom phones.  Then, when the phone sends an INVITE with Replaces for the
special callid, Asterisk will perform a pickup on the extension that was
subscribed to.

The original code on this issue was submitted by xylome.  However, contributions
have been made by (at least) mgernoth and pkempgen.  The final patch was written
by seanbright, and includes the necessary logic to allow this work in a
technology independent way.

(closes issue #5014)
Reported by: xylome
Patches:
      issue5014-trunk.diff uploaded by seanbright (license 71)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145226 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-30 21:32:53 +00:00
Richard Mudgett
e3311c9875 * Miscellaneous formatting changes to make v1.4 and trunk
more merge compatible in the mISDN area.

channels/chan_misdn.c
*  Eliminated redundant code in cb_events() EVENT_SETUP



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-30 21:00:54 +00:00
Michiel van Baak
90751b16ca Merge the cli_cleanup branch.
This work is done by lmadsen, junky and mvanbaak
during AstriDevCon.

This is the second audit the CLI got, and
this time lmadsen made sure he had _ALL_ modules
loaded that have CLI commands in them.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-28 23:32:14 +00:00
Kevin P. Fleming
de6656902d rename chandup() and clarify its usage
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-28 17:08:12 +00:00
Michiel van Baak
f1b673eef0 fix a couple of CLI commands that did not have a help description.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@144879 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-27 00:49:24 +00:00
Steve Murphy
e74584ca3c (closes issue #13557)
Reported by: nickpeirson

The user attached a patch, but the license is not yet
recorded. I took the liberty of finding and replacing
ALL index() calls with strchr() calls, and that
involves more than just main/pbx.c;

chan_oss, app_playback, func_cut also had calls
to index(), and I changed them out. 1.4 had no
references to index() at all.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@144569 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-25 22:21:28 +00:00
Christian Richter
1c2cbc926b Merged revisions 144238 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r144238 | crichter | 2008-09-24 10:20:52 +0200 (Mi, 24 Sep 2008) | 1 line

improved helptext of misdn_set_opt.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@144257 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-24 08:42:55 +00:00
Mark Michelson
ad859c943e Fix a conflict in flag values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@144149 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-23 23:33:33 +00:00
Mark Michelson
8625eb9d2a When a promiscuous redirect contained both a user and
host portion in the Contact URI and specifies a 
transport, the parsing done in parse_moved_contact
resulted in a malformed URI.

This commit fixes the parsing so that a proper
Dial string may be formed when the forwarded
call is placed.

(closes issue #13523)
Reported by: mattdarnell
Patches:
      13523v2.patch uploaded by putnopvut (license 60)
Tested by: mattdarnell



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@144025 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-23 15:37:00 +00:00
Michiel van Baak
d1ee16cd9a make 'module unload chan_skinny.so' actually work.
(closes issue #13524)
Reported by: wedhorn
Patches:
      unload.diff uploaded by wedhorn (license 30)
	  With small tweak by me to prevent a crash


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@143799 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-20 10:39:20 +00:00
Mark Michelson
02a0855e57 We should only unsubscribe to the device state event
subscription if we have previously subscribed. Otherwise
a segfault will occur.

(closes issue #13476)
Reported by: jonnt
Patches:
      13476.patch uploaded by putnopvut (license 60)
Tested by: jonnt



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@143609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-19 15:43:28 +00:00