Commit Graph

43 Commits

Author SHA1 Message Date
Russell Bryant
c67d152525 Don't use free() directly. This caused a crash since ast_filestream is now an ao2 object.
Reported by JunK-Y on IRC, #asterisk-dev


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@167541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-01-07 22:03:59 +00:00
Mark Michelson
6a632a5a2b There was an issue when attempting to reference an embedded
frame in a freed ast_filestream. This patch makes use of the
ao2 functions to make sure that we do not free an ast_filestream
structure until the embedded ast_frame has been "freed" as well.

(closes issue #13496)
Reported by: fst-onge
Patches:
      filestream_frame_1_4.diff uploaded by putnopvut (license 60)
Tested by: putnopvut

Closes AST-89



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@158126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-20 18:06:48 +00:00
Kevin P. Fleming
18df35a2c1 somehow missed a bunch of gcc 4.3.x warnings in this branch on the first pass
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@153823 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 13:01:18 +00:00
Kevin P. Fleming
add5ff5b05 fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@153337 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-01 18:22:39 +00:00
Tilghman Lesher
8dfa8b6d0e Don't return a free'd pointer, when a file cannot be opened.
(closes issue #13462)
 Reported by: wackysalut


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@142740 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-12 16:27:32 +00:00
Kevin P. Fleming
75c6f9ab0f a whole pile of Zaptel/DAHDI compatibility work, with lots more to come... this tree is not yet ready for users to be easily upgrading or switching, but it needs to be :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@130298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-11 22:12:26 +00:00
Jeff Peeler
f9818af8dd Adds DAHDI support alongside Zaptel. DAHDI usage favored, but all Zap stuff should continue working. Release announcement to follow.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@122314 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-12 19:08:20 +00:00
Russell Bryant
b3a211bdc3 I thought I was going to be able to leave 1.4 alone, but that was not the case.
I ran into some problems with G.722 in 1.4, so I have merged in all of the fixes
in this area that I have made in trunk/1.6.0, and things are happy again.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114550 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-22 21:14:55 +00:00
Jason Parker
6d08d42e0e Only try to prefix language if we are not using an absolute path (suffix it otherwise).
en/var/lib/asterisk/sounds/blah.gsm is a very silly path.

(closes issue #12379)
Reported by: kuj
Patches:
      12379-absolutepath.diff uploaded by qwell (license 4)
Tested by: kuj, qwell


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-10 17:26:10 +00:00
Jason Parker
4501c61d73 Backport revision 106439 from trunk. I didn't realize this was broken in 1.4 as well.
Closes issue #12222.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@109057 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-17 15:15:56 +00:00
Joshua Colp
cd703523db Add a control frame to indicate the source of media has changed. Depending on the underlying technology it may need to change some things.
(closes issue #12148)
Reported by: jcomellas


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@106235 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-05 22:32:10 +00:00
Mark Michelson
45079917ec Bump a couple of more buffers up by 2 so that annoying warnings aren't generated
like crazy on every fileexists_core call.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-27 20:36:26 +00:00
Joshua Colp
451ee5b1d4 Bump up the buffer by 2.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104665 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-27 17:41:40 +00:00
Kevin P. Fleming
8a9e7e213b fallback to standard English prompts properly when using new prompt directory layout
(closes issue #11831)
Reported by: IgorG
Patches:
      fallbacken.v1.diff uploaded by IgorG (license 20) (modified by me to improve code and conform rest of function to coding guidelines)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104593 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-27 16:53:06 +00:00
Russell Bryant
e4ee2274a1 Fix a couple of places where ast_frfree() was not called on a frame that came
from a translator.  This showed itself by g729 decoders not getting released.
Since the flag inside the translator frame never got unset by freeing the frame
to indicate it was no longer in use, the translators never got destroyed, and
thus the g729 licenses were not released.

(closes issue #11892)
Reported by: xrg
Patches:
      11892.diff uploaded by russell (license 2)
Tested by: xrg, russell


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101601 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 23:10:06 +00:00
Tilghman Lesher
7060a6888d When deleting a task from the scheduler, ignoring the return value could
possibly cause memory to be accessed after it is freed, which causes all
sorts of random memory corruption.  Instead, if a deletion fails, wait a
bit and try again (noting that another thread could change our taskid
value).
(closes issue #11386)
 Reported by: flujan
 Patches: 
       20080124__bug11386.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76, flujan, stuarth`


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100465 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-27 21:59:53 +00:00
Tilghman Lesher
2c11f7d18e Use of "private" as a field name in a header file messes with C++ projects
Reported by: chewbacca
Patch by: casper
(Closes issue #11401)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90155 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-29 17:29:59 +00:00
Russell Bryant
1380790b60 Merge a change from team/russell/chan_refcount ...
This makes ast_stopstream() thread-safe.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90142 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-29 00:06:08 +00:00
Russell Bryant
d6b8fb4dc0 gcc 4.2 has a new set of warnings dealing with cosnt pointers. This set of
changes gets all of Asterisk (minus chan_alsa for now) to compile with gcc 4.2.
(closes issue #10774, patch from qwell)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83432 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-21 14:37:20 +00:00
Russell Bryant
aa3b7e22f5 Fix an issue that can occur when you do an attended transfer to parking. If
you complete the transfer before the announcement of the parking spot finishes,
then the channel being parked will hear the remainder of the announcement.
These changes make it so that will not happen anymore.

Basically, res_features sets a flag on the channel is playing the announcement
to so that the file streaming core knows that it needs to watch out for a
channel masquerade, and if it occurs, to abort the announcement.

(closes BE-182)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81599 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 20:53:41 +00:00
Joshua Colp
c3ba2c8fc6 Don't bother having the core pass through or emulate begin DTMF frames when in an ast_waitstream. It only cares about the end of DTMF.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78955 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-10 14:15:53 +00:00
Jason Parker
e107da04b4 Merged revisions 71065 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r71065 | qwell | 2007-06-22 09:52:18 -0500 (Fri, 22 Jun 2007) | 4 lines

Fix a few silly usages of ast_playstream() - it only ever returns 0...

Issue 10035

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@71068 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 15:00:30 +00:00
Joshua Colp
928e69408e Properly handle cases where a stream can't be written to. (issue #9757 reported by junky)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67924 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 23:38:15 +00:00
Olle Johansson
d48415f678 Stop the video stream when you stop playback of all streams for a call
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-06 12:28:38 +00:00
Tilghman Lesher
f32fa7f2ee Merged revisions 60660 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r60660 | tilghman | 2007-04-07 20:39:25 -0500 (Sat, 07 Apr 2007) | 2 lines

Bug 9486 - memory leak when opening a filestream

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60661 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-08 01:40:47 +00:00
Russell Bryant
5a9cd3d235 Return the correct digit that interrupted the stream. This fixes exiting the
Background application when using the m option.
(issue #9176, mjagdis)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@57396 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-02 00:20:44 +00:00
Joshua Colp
bc43c82f05 Fix core show file formats CLI command.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52335 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-26 23:46:47 +00:00
Jason Parker
897e4b5eaa Display more useful output when streaming files.
Include the channel name to which the file is being played.

Issue 8828, patch by junky.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-16 17:36:53 +00:00
Kevin P. Fleming
a299485952 since these variables all have static duration, none of them need initializers (they default to zero anyway)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49006 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 22:06:56 +00:00
Kevin P. Fleming
3307ae060a move extern declaration for this option to a header file where it belongs
provide an initial value for 'languageprefix' option, instead of relying on randomness to provide a useful value


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48998 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 21:08:30 +00:00
Kevin P. Fleming
3302cbea3e don't try to call fclose() if fopen() failed
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47701 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 20:50:06 +00:00
Tilghman Lesher
e05a2752e8 Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 23:00:20 +00:00
Joshua Colp
1a5c679e51 Merged revisions 44580 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r44580 | file | 2006-10-06 12:52:14 -0400 (Fri, 06 Oct 2006) | 2 lines

Even more frames to treat as though the remote side disappeared (issue #8097 reported by eldadran)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 16:53:48 +00:00
Joshua Colp
dba3dae7f8 Merged revisions 44501 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r44501 | file | 2006-10-05 15:55:41 -0400 (Thu, 05 Oct 2006) | 2 lines

Treat busy control frames as hangup in the file streaming core (issue #8097 reported by eldadran)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44502 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 19:57:16 +00:00
Paul Cadach
13663f59cf Don't warn on HOLD/UNHOLD control frames
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43844 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 06:02:45 +00:00
Paul Cadach
8d881f8be0 Don't treat unknown control frames as voice
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43843 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 06:01:37 +00:00
Kevin P. Fleming
fcb999c01c merge qwell's CLI verbification work
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 19:54:18 +00:00
Joshua Colp
b4d0f26d2b You see nothing...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41696 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-01 16:50:02 +00:00
Joshua Colp
043a01e6bd 0 is indeed considered a valid file descriptor (issue #7861 reported by PCadach)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41694 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-01 16:40:18 +00:00
Joshua Colp
faf4975122 Ignore DTMF begin frames in the waitstream core so that we don't get duplicate digits in our extension match
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41611 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 19:03:13 +00:00
Joshua Colp
c6977b9983 Merge in VLDTMF support with Zaptel/Core done by the ever great Darumkilla Russell Bryant and the RTP portion done by myself, Muffinlicious Joshua Colp. This has gone through so many discussions/revisions it's not funny but we finally have it!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41507 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 01:59:02 +00:00
Joshua Colp
3f7b10eab6 Free the filename so we don't have a memory leak. (reported by PCadach in #asterisk-bugs)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40953 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-23 20:22:18 +00:00
Kevin P. Fleming
0a27d8bfe5 merge new_loader_completion branch, including (at least):
- restructured build tree and makefiles to eliminate recursion problems
  - support for embedded modules
  - support for static builds
  - simpler cross-compilation support
  - simpler module/loader interface (no exported symbols)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-21 02:11:39 +00:00