Commit Graph

48 Commits

Author SHA1 Message Date
Tilghman Lesher f82f12d6b2 Properly escape cdr->src and cdr->dst and ensure we use thread-safe escaping
(Fixes AST-2007-026)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90166 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-29 19:48:10 +00:00
Tilghman Lesher 34f8812c64 Portability fix for devmode compiling (closes bug #10382)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-05 14:18:00 +00:00
Joshua Colp c28511d8ba (closes issue #10310)
Reported by: prashant_jois
Patches:
      cdr_pgsql.patch uploaded by prashant (license 114)
Finish the Postgresql connection after the log messages are printed so we don't access invalid memory.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77540 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-27 17:04:08 +00:00
Mark Michelson e9c7f6f4f2 Two consecutive calls to PQfinish could occur, meaning free gets called on the same variable twice.
This patch sets the connection to NULL after calls to PQfinish so that the problem does not occur.
Also in this patch, prashant_jois informed me that it is safe to pass a null pointer to PQfinish, so
I have removed the check for conn's existence from my_unload_module.

(closes issue 10295, reported by junky, patched by me with input from prashant_jois)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77318 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-26 18:30:29 +00:00
Jason Parker b035606357 Fix some potential memory leaks in cdr_pgsql.
Issue 10020, patch by my, with credit to prashant_jois for pointing out the problem.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70612 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 23:32:39 +00:00
Jason Parker b7447818de Fix a stupid mistake in my last cdr_pgsql race condition fix
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70560 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 22:55:21 +00:00
Jason Parker 6fd76e7bc3 Fix a race condition in cdr_pgsql that can occur when reloading the module.
Issue 10022, patch by me, with credit to prashant_jois for finding the bug.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@70554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 22:31:35 +00:00
Kevin P. Fleming ae82d97c6d use ast_localtime() in every place localtime_r() was being used
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 21:50:40 +00:00
Russell Bryant 5aea57eed1 Fix a memory leak pointed out by prashant_jois in #asterisk-bugs. PQclear() was
not called on the result structure after doing a PQexec().  Also, fix up some
formatting in passing.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69016 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:40:17 +00:00
Joshua Colp 595f01984f Merged revisions 47583 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47583 | file | 2006-11-13 16:26:36 -0500 (Mon, 13 Nov 2006) | 2 lines

Initialize global pointers for connection and result to NULL. (issue #8356 reported by james)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 21:28:57 +00:00
Joshua Colp e8b820e743 Magical eightball says warnings be gone.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 21:03:37 +00:00
Matt O'Gorman 05a695af72 everything that loads a config that needs a config file to run
now reports AST_MODULE_LOAD_DECLINE when loading if config file
is not there, also fixed an error in res_config_pgsql where it 
had a non static function when it should.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41633 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 21:00:20 +00:00
Kevin P. Fleming 0a27d8bfe5 merge new_loader_completion branch, including (at least):
- restructured build tree and makefiles to eliminate recursion problems
  - support for embedded modules
  - support for static builds
  - simpler cross-compilation support
  - simpler module/loader interface (no exported symbols)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-21 02:11:39 +00:00
Kevin P. Fleming 472c1ca282 simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 18:54:56 +00:00
Russell Bryant d8f4a04acc remove an unused variable, and default the user to asterisk if not specified
in the config file (issue #7153, Mithraen)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28936 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 01:35:12 +00:00
Russell Bryant f1a97c3b3f various fixes regarding coding guidelines issues
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28935 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 01:29:08 +00:00
Russell Bryant 0523e82f46 if a hostname is not specified, connect over a unix socket instead of
connecting to localhost (issue #7145, Mithraen)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@28897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 00:57:04 +00:00
Kevin P. Fleming 574e14cbea Thanks to the fine work of Russell Bryant and Dancho Lazarov, we now have autoconf and menuselect tools for Asterisk!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22267 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-24 17:11:45 +00:00
Kevin P. Fleming 2229586d71 more module loader related fixes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20963 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 16:42:21 +00:00
Kevin P. Fleming f10f427d49 since the module API is changing, it's a good time to const-ify the description() and key() return values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 22:01:19 +00:00
Tilghman Lesher c6f691fbcc Merged revisions 11503 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r11503 | tilghman | 2006-03-01 11:41:52 -0600 (Wed, 01 Mar 2006) | 2 lines

Bug 6615 - Fix 64bit conversion errors by using a long int

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@11504 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-01 17:53:05 +00:00
Olle Johansson aad2331375 - Adding whitespace that I found unused outside
- Adding "if (option_debug)" before outputting to DEBUG channel


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8524 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-24 11:46:29 +00:00
Olle Johansson fe1366c201 Declaring conn and result static to avoid collission with realtime driver (issue 6336, pressureman)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@8523 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-24 11:42:09 +00:00
Kevin P. Fleming 2c65582b66 remove extraneous svn:executable properties
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-29 18:24:39 +00:00
Russell Bryant 31a804b97c issue #5605
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-06 15:09:47 +00:00
Russell Bryant 6324072247 more doxygenification (issue #5513)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-26 13:03:17 +00:00
Kevin P. Fleming b8f23573fa more license/copyright header updates (thanks Ian!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6618 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 15:44:26 +00:00
Kevin P. Fleming 5da915dcfd update MANY more files with proper copyright/license info (thanks Ian!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 20:46:50 +00:00
Kevin P. Fleming be9d72b11d remove complex malloc-avoidance (bug #4601)
remove resetting of variables during unload that will only be freed or set to known values on reload


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6085 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-11 21:06:27 +00:00
Kevin P. Fleming 2b8338cb52 more file version tags
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 22:12:19 +00:00
Kevin P. Fleming 005e436b57 another round of version tag updates, along with 'show version files' pattern filtering
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 21:09:59 +00:00
Kevin P. Fleming 8634ef9e4a don't use '%i' at all, since we have no current use cases that need non base-10 parsing (bug #4110)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5533 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-29 17:00:33 +00:00
Kevin P. Fleming 1f9ab2380a use double-quotes instead of angle-brackets for non-system include files (bug #4058)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-21 06:02:45 +00:00
Mark Spencer 0f10f4119f Make cdr_pgsql gracefully handle restarts (bug #3628)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5056 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-02-19 20:10:52 +00:00
Mark Spencer 5f726ad8c7 Merge config updates (bug #3406)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4889 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-01-25 06:10:20 +00:00
Mark Spencer 7d6a43c2bb Fix PGSQL CDR issue (bug #3028)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4440 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-12-12 23:34:24 +00:00
Mark Spencer 9f1a7379cc Make table for PGSQL CDR's configurable (bug #2951)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4412 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-12-09 20:34:35 +00:00
Mark Spencer dccc0214c1 Fix missing ast_destroy's in PGSQL (bug #2944)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@4365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-12-01 05:27:18 +00:00
Mark Spencer 5733f64bdd Only Call PQfinish if conn isn't NULL (bug #2162)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3528 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-07-28 18:42:35 +00:00
Mark Spencer 044ad2e2e7 Merge remaining audit patch (save dlfcn.c)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-07-14 13:57:15 +00:00
James Golovich 9e0e3799bf Fixes from bkw_. Formatting in app_db.c and handle start right in cdr_pgsql.c
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-07-09 16:19:00 +00:00
Mark Spencer 727abcdec7 Merge FreeBSD locking fixes (bug #1411)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@3176 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-06-09 01:45:08 +00:00
Mark Spencer 6a6814379f Release pgsql on failure (bug #891)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@2055 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-01-22 17:03:11 +00:00
Jeremy McNamara 6b5c11548e should be != :)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1954 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-01-11 19:34:04 +00:00
Jeremy McNamara 275f0ed037 Add userfield logging
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1948 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2004-01-11 18:23:33 +00:00
Mark Spencer 89aadcec48 Harden PGSQL against dead connections (bug #481)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1694 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2003-11-05 05:56:27 +00:00
Mark Spencer b016beaeb1 Fix extraneous include from MySQL
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2003-10-01 21:06:15 +00:00
Mark Spencer 8cd100de39 Add PGSQL support
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@1594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2003-10-01 15:03:30 +00:00