Commit Graph

30864 Commits

Author SHA1 Message Date
Joshua Colp
e3e45a86f6 Merge "dialplan_functions: wrong srtp use status report of a dialplan function" into 13 2018-08-06 08:34:12 -05:00
Joshua Colp
80567a67d9 Merge "pjproject_bundled: Find shared libraries in root --with-ssl=PATH." into 13 2018-08-06 05:28:59 -05:00
Alexander Traud
819842f7fb pjproject_bundled: Fix for Solaris builds. Do not undef s_addr.
The authors of PJProject undef s_addr because of some issue in Microsoft
Windows. However in Oracle Solaris, s_addr is not a structure member, but
defined to map to the real structure member.

Updates the patch from ASTERISK_20366

ASTERISK-27997

Change-Id: I8223026d4d54e2a46521085fcc94bfa6ebe35b11
2018-08-03 16:52:48 -05:00
Richard Mudgett
1f97ea7e2c res_pjsip: Make pjlib.h consistently included.
* Don't include pjlib.h twice in res_pjsip.h
* Consistently use #include <> form for pjproject includes.
(pjsip.h and pjlib.h)

Change-Id: I3f7b42044840de64edf7e9d7695cb60c45990dc7
2018-08-03 16:00:47 -05:00
Kevin Harwell
d3358a8c84 Merge "BuildSystem: Enable ncurses for menuselect in Solaris 11." into 13 2018-08-03 13:28:34 -05:00
Kevin Harwell
d71cf6dc35 Merge "pjsip_wizard.conf.sample: Update remote_hosts description." into 13 2018-08-03 13:27:36 -05:00
Kevin Harwell
4dee592608 Merge "res_pjsip_endpoint_identifier_ip.c: Added regex support to match_header" into 13 2018-08-03 13:26:00 -05:00
Alexander Traud
0d880fac93 pjproject_bundled: Find shared libraries in root --with-ssl=PATH.
The script configure from Teluu expects shared libraries (.so) in a subfolder
called 'lib', when --with-xyz=PATH is specified. However for OpenSSL, the
default location is the root of the source folder = PATH. Furthermore, Asterisk
supports both, 'lib' and root. For consistency and because Asterisk is using
(only) OpenSSL in PJProject, it is enhanced to support both locations, just
like Asterisk.

ASTERISK-27995

Change-Id: I8eb916a88b6b8c22e29bb40bee8faaca6c73406f
2018-08-03 09:19:47 -05:00
Joshua Colp
a5ce9b6c4b res_pjsip_registrar: Improve performance on inbound handling.
This change removes a sorcery lookup for retrieving all
contacts at the end of the registration process by keeping
track of the contacts that are added/updated/deleted.

This ensures at the end of the process the container of
contacts we have is the current state.

Pool usage has also been reduced by allocating one for
usage throughout the handling of a REGISTER and resetting
it to a clean state. This ensures that in most cases
we allocate once and just reuse it.

ASTERISK-28001

Change-Id: I1a78b2d46f9a2045dbbff1a3fd6dba84b612b3cb
2018-08-03 06:09:33 -03:00
Salah Ahmed
4aa91c6f11 dialplan_functions: wrong srtp use status report of a dialplan function
If asterisk offer an endpoint with SRTP and that endpoint respond
with non srtp, in that case channel(rtp,secure,audio) reply wrong
status.

Why delete flag AST_SRTP_CRYPTO_OFFER_OK while check identical remote_key:
Currently this flag has being set redundantly. In either case identical
or different remote_key this flag has being set. So if we
don't set it while we receive identical remote_key or non SRTP SDP
response then we can take decision of srtp use by using that flag.

ASTERISK-27999

Change-Id: I29dc2843cf4e5ae2604301cb4ff258f1822dc2d7
2018-08-02 16:58:47 -05:00
Joshua Colp
37085a0cb7 Merge "thirdparty/pjproject: fix deadlock in response retransmissions" into 13 2018-08-02 06:53:53 -05:00
Jenkins2
2c89bba900 Merge "BuildSystem: Enable Jansson in Solaris 11." into 13 2018-08-02 05:12:51 -05:00
Torrey Searle
ff94fcb6f1 thirdparty/pjproject: fix deadlock in response retransmissions
The tdata containing the response can be shared by both the dialog
object and the tsx object.  In order to prevent the race condition
between the tsx retransmission and the dialog sending a response,
clone the tdata before modifying it for the dialog send response.

ASTERISK-27966 #close

Change-Id: Ic381004a3a212fe1d8eca0e707fe09dba4a6ab4e
2018-08-01 11:08:51 -05:00
Joshua Colp
904095833e Merge "res_rtp_asterisk: In Developer Mode, do not require OpenSSL." into 13 2018-08-01 04:23:23 -05:00
Joshua Colp
465546fbe4 Merge "res_pjsip_pubsub: Use ast_true for "prune_on_boot"." into 13 2018-07-31 16:10:57 -05:00
Richard Mudgett
75131c9e1c pjsip_wizard.conf.sample: Update remote_hosts description.
Remove the note that SRV records are not supported as that is no longer
true.

ASTERISK-27993

Change-Id: Id0dd6ef40e52702be9727a2b6122216cb00bb4ca
2018-07-31 11:24:08 -05:00
George Joseph
7f203d2bd8 CI: Add optional uninstall step before installing asterisk
Change-Id: I7dedf1e925eafc3a0adf01dd9dfbe44eb642aab7
2018-07-30 08:44:12 -05:00
Alexander Traud
4aa1a42159 BuildSystem: Enable ncurses for menuselect in Solaris 11.
The check for the library ncurses should use not use the header <curses.h> but
<ncurses.h>, because on some platforms <curses.h> is not a drop-in replacement
for <ncurses.h>: For example in Solaris, the symbol initscr is a typedef in
<curses.h> to a symbol which does not exist in the library ncurses (initscr32).
Simply use <ncurses.h> when you link to ncurses.

Furthermore in Solaris, the header <ncurses.h> is in a subdirectory
/usr/include/ncurses and not available via pkg-config.

ASTERISK-15331
ASTERISK-14935
ASTERISK-12382
ASTERISK-9107

Change-Id: Ife367776b0ccf17d3fefed868245376bfb93745d
2018-07-29 03:20:56 -05:00
Alexander Traud
d9da161b5c BuildSystem: Enable Jansson in Solaris 11.
In Solaris, the header <jansson.h> is in /usr/include/jansson. To find
Jansson even in such a subdirectory, the tool pkg-config is queried via
AST_PKG_CONFIG_CHECK. For those platforms, which do not list Jansson via
pkg-config, the previous check remains and is executed thereafter.

Because the check for the NetBSD Editline library uses the tool pkg-config
conditionally PKG_PROG_PKG_CONFIG must be used. Because that check happens
earlier than Jansson, it must be placed in front of that.

The script configure does some pre-checks for the script configure of the
Asterisk internal NetBSD Editline library. The check for the library ncurses
should use not use the header <curses.h> but <ncurses.h>, because on some
platforms <curses.h> is not a drop-in replacement for <ncurses.h>: For example
in Solaris, the symbol initscr is a typedef in <curses.h> to a symbol which
does not exist in the library ncurses (initscr32). Simply use <ncurses.h> when
you link to ncurses.

ASTERISK-27991

Change-Id: I69ea0f379f87a50049654b2487c76ee1c04fa53a
2018-07-28 15:08:40 +02:00
Joshua Colp
edddcb3dc6 res_pjsip_pubsub: Use ast_true for "prune_on_boot".
Change-Id: Iedec4e7390b3e821987681da24d0298632b9873d
2018-07-28 13:00:40 +00:00
Richard Mudgett
8baedc2204 res_pjsip_endpoint_identifier_ip.c: Added regex support to match_header
This patch adds regular expression support to make the identify section's
match_header option more useful when attempting to match complex headers
like the 'To' or 'From' headers.  The 'From' header has variable
components such as the tag parameter that you cannot predict.  To specify
a regular expression put slashes around the regular expression in place of
the header value.

[identify-alice]
type=identify
endpoint=alice
match_header=From: /<sip:alice@127\\.0\\.0\\.1>/

* Added regex support to match_header so you could match a 'To' header
among other complex headers.

Fixed reported crashes when trying to match special headers like 'Contact'.
The identify section's match_header method used code that assumed you were
matching a generic header.  Any other type of header could cause a crash
if the header structure variant did not match the generic header enough.

* Made use code that will work for any header type instead of code
specific to generic headers.

Other fixes while in the area:

* Made check all headers of the requested name.
* Added some more sanity checks to the configured identify matching
options when applying the configuration.

ASTERISK-27548

Change-Id: I27dfd4ff5e2259b906640e3c330681b76b4ed1f1
2018-07-27 10:58:06 -05:00
Joshua Colp
d33ed08afc res_pjsip_pubsub: Treat "prune_on_boot" as a yes / no.
The alembic for the PJSIP subscription persistence table has the
"prune_on_boot" field as a boolean. While in Asterisk we are
tolerant of many different definitions of true and false in the
database we only accept "yes" and "no". This change makes the
field treated as a yes/no instead of an integer, thus storing
"yes" and "no" instead of "1" and "0".

Change-Id: Ic8b9211b36babefe78f70def6828a135a6ae7ab6
2018-07-27 15:46:12 +00:00
Alexander Traud
a4b105c99b res_rtp_asterisk: In Developer Mode, do not require OpenSSL.
OpenSSL is an optional external library and should stay optional even when
Developer Mode is configured.

ASTERISK-27990

Change-Id: Ia68a4cd5474b26d45e0f43b04032ad598022853b
2018-07-27 15:54:11 +02:00
Jenkins2
111cde6026 Merge "devicestate: Don't create topic when change isn't cached." into 13 2018-07-27 06:09:18 -05:00
Joshua Colp
bb5e2f3c71 Merge "Build System: Create 'make install-configs' target." into 13 2018-07-27 05:51:51 -05:00
Joshua Colp
ef647cc31e Merge "res_rtp_asterisk: Avoid merging command and regular T.140 text packets" into 13 2018-07-27 05:35:08 -05:00
George Joseph
2b0d003a35 CI: Fix placement of job summary statments
Change-Id: Iace19e718f4e8fb48eb7dc9f98af53b115cc45f3
2018-07-26 17:56:04 -06:00
George Joseph
5fbf2ce248 CI: Add docker info to job summary
Change-Id: I45d52005a9b692ad303c11792f226ace1e449901
2018-07-26 10:35:08 -06:00
Corey Farrell
eacf8fe96c Build System: Create 'make install-configs' target.
This target requires specifying CONFIG_SRC=path_to_configs.  This can be
used to install custom configs for the Asterisk build while still
performing directory replacements on asterisk.conf.

Modify internal INSTALL_CONFIGS so first argument requires full path to
the config sources relative to Asterisk source root.

Change-Id: Idcd841df3c8d5bfe23d566bb9e2e448e9df4f8ab
2018-07-26 10:19:34 -05:00
Kevin Harwell
059e1e3bc8 json.c: improve ast_json_to_ast_variables performance
When converting from a json object to an ast variables list the conversion
algorithm was doing a complete traversal of the entire variables list for
every item appended from the json structure.

This patch makes it so the list is no longer traversed for each new ast
variable being appended.

Change-Id: I8bf496a1fc449485150d6db36bfc0354934a3977
2018-07-25 15:33:22 -05:00
Joshua Colp
dd1b4b38cf devicestate: Don't create topic when change isn't cached.
When publishing a device state the change can be marked as being
cachable or not. If it is not cached the change is just published
to all interested and not stored away for later query. This was not
fully taken into account when publishing in stasis. The act of
publishing would create a topic for the device even if it may be
ephemeral.

This change makes it so messages which are not cached won't create
a topic for the device. If a topic does already exist it will be
published to but otherwise the change will only be published to
the device state all topic.

ASTERISK-27591

Change-Id: I18da0e8cbb18e79602e731020c46ba4101e59f0a
2018-07-25 19:20:35 +00:00
George Joseph
a34ef4dcd9 Merge "Build System: Silence build of bundled jansson." into 13 2018-07-25 13:59:50 -05:00
Joshua Colp
cdf6e93b6d Merge "res_pjsip: Change log message from error to warning for valid use cases" into 13 2018-07-25 13:59:04 -05:00
Jenkins2
efa53816ef Merge "CI: Explicitly pass BRANCH_NAME to buildAsterisk and installAsterisk" into 13 2018-07-25 12:48:51 -05:00
Jenkins2
b91ea7a726 Merge "CI: Add options to initialize and cleanup database to runTestsuite.sh" into 13 2018-07-25 12:48:20 -05:00
George Joseph
21168ba931 CI: Explicitly pass BRANCH_NAME to buildAsterisk and installAsterisk
Change-Id: I652f4a0ea5107c778e27a78bccb67b18b0c4e087
2018-07-25 09:20:43 -06:00
George Joseph
9b4fb9d1aa CI: Add options to initialize and cleanup database to runTestsuite.sh
Change-Id: I352333233bab5377723bf37d490ba84fc55bc853
2018-07-25 09:12:30 -06:00
Corey Farrell
90325f0569 CI: Do not mkdir 2.
Change-Id: Ib7377d26a6c98b38bad463f47c84f1875ac84eb7
2018-07-25 09:08:41 -05:00
Corey Farrell
3ed6abcc1f Build System: Silence build of bundled jansson.
Change-Id: I7392c79c0173057f5378010bf1fe65e300e8fc56
2018-07-25 07:35:06 -05:00
George Joseph
b971faf740 CI: RefDebug: Fix reference to testsuite URL
Change-Id: I0ee41d95a87f0d97b01f2757012b846bcfe6443d
2018-07-25 06:14:09 -06:00
Corey Farrell
ab103d66db Build System: Fix bundled jansson install.
Update the bundled jansson Makefile to do nothing during Asterisk
install, use a target that is not phony to initiate the jansson make and
install.

Change-Id: I7643cc3d39af9feba8fc0da676b646efc5f8b3bb
2018-07-24 14:45:13 -05:00
Jenkins2
b876d624d7 Merge "Enable bundling of jansson." into 13 2018-07-24 10:06:51 -05:00
George Joseph
54364318b5 Merge "res_pjsip: Update default keepalive interval to 90 seconds." into 13 2018-07-24 08:30:46 -05:00
Florian Floimair
fd1b8c57e9 res_pjsip: Change log message from error to warning for valid use cases
If a SIP MESSAGE is triggered for an endpoint that is currently not registered
- and therefore has no valid contact associated - an error message was logged.
Since this is a valid request in a valid use cases this is now changed to a
warning, as discussed with Matt Fredrickson on the asterisk-dev mailing list.

Change-Id: I55eb62d2712818a58c7532119dec288bd98cf0c0
2018-07-24 07:19:28 -05:00
Jenkins2
6dac6e0ab8 Merge "CI: Add --privileged flag to docker options" into 13 2018-07-24 06:03:05 -05:00
Jenkins2
990ac404f4 Merge "CI: Set correct user:group when publishing docs" into 13 2018-07-24 06:03:03 -05:00
George Joseph
b3060d5ccf Merge "build_tools/make_version: Get MAINLINE_BRANCH from .gitreview." into 13 2018-07-24 05:40:56 -05:00
George Joseph
eccd5886c3 CI: Add --privileged flag to docker options
Change-Id: If92d55f15306e55dd7091ac3c47b13ebbbb03488
2018-07-24 04:39:30 -06:00
George Joseph
32ae565da2 CI: Set correct user:group when publishing docs
Change-Id: Ibabeb9ac730d9755cf54318d0da74771c939b86b
2018-07-24 04:22:57 -06:00
Jenkins2
7b84eabb1d Merge "CI: Split --test-command argument." into 13 2018-07-23 13:45:18 -05:00