Commit Graph

986 Commits

Author SHA1 Message Date
Russell Bryant
083a9198ea Merged revisions 52903 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r52903 | russell | 2007-01-30 11:12:04 -0600 (Tue, 30 Jan 2007) | 9 lines

The SIGHUP handler was implemented to allow admins to send SIGHUP to a running
Asterisk process to reload the configuration.  However, doing the actual reload
in the signal handler itself is a very bad thing to do, because the reload
process includes calling non-reentrant functions such as malloc/calloc/etc.
If Asterisk is running in the background, then the reload will happen
immediately.  However, if running in console mode, the reload doesn't work
until something is typed at the console.  That sort of defeats the purpose,
but I don't see an easy way to get around it at this point.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52904 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-30 17:19:39 +00:00
Russell Bryant
4bc823f540 Add a missing quotation mark. This was pointed out by jcmoore on #asterisk-dev.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 22:58:09 +00:00
Russell Bryant
771be23a9c Remove a recursive lock of the manager session. This was pointed out by
zandbelt in issue #8711.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52688 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 22:55:41 +00:00
Russell Bryant
108085ed2d ASTLDFLAGS needs to be passed to the editline configure script as LDFLAGS.
(issue #8928, zandbelt)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 21:36:56 +00:00
Russell Bryant
06a3110ed8 Fix a problem with packet-to-packet bridging and DTMF mode translation. P2P
bridging can only be used when the DTMF modes don't match if the core is
monitoring DTMF in both directions.  Then, the core will handle the translation.
Otherwise, this bridging method can not be used.
(issue #8936)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 21:26:27 +00:00
Russell Bryant
ce753cf0d9 The session lock can not be held while calling action callbacks. If so, then
when the WaitEvent callback gets called, then no event can happen because the
session can't be locked by another thread.  Also, the session needs to be
locked in the HTTP callback when it reads out the output string.  This fixes
the deadlock reported in both 8711 and 8934.
Regarding issue 8711, there still may be an issue.  If there is a second action
requested before the processing of the first action is finished, there could
still be some corruption of the output string buffer used to build the result.
(issue #8711, #8934)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52611 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 20:39:20 +00:00
Steve Murphy
f2fab700c3 this is for 8778 (pt_BR backport to 1.4). It was committed to trunk via 7663. But it wasn't so much an enhancement as a fix for the bad language output for portuguese in Brazil, so, after a lot of prodding from patient Brazilians, here is the same fix for 1.4
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52535 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 17:57:08 +00:00
Russell Bryant
824bed6260 Clean up a few things in the last commit to the adaptive jitterbuffer code.
- Specifically indicate to the compiler that the "dropem" variable only
   needs one but.
 - Change formatting to conform to coding guidelines.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52506 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 16:54:27 +00:00
Jim Dixon
2132e4f865 Fixed problem with jitterbuf, whereas it would not complain about, and
would allow itself to be overfilled (per the max_jitterbuf parameter). Now
it rejects any data over and above that size, and complains about it.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52494 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 04:18:36 +00:00
Joshua Colp
9c289fe01b Have the manager interface send back an "Already logged in" message instead of "Invalid/Unknown Command" when the client authenticates for a second time. (issue #8509 reported by pari)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52373 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-27 00:44:51 +00:00
Joshua Colp
bc43c82f05 Fix core show file formats CLI command.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52335 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-26 23:46:47 +00:00
Joshua Colp
3b44625323 Merged revisions 52264 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r52264 | file | 2007-01-25 14:15:29 -0500 (Thu, 25 Jan 2007) | 2 lines

Allow dequeueing of frames with negative timestamp by moving jitterbuffer frames check to jb_next. (issue #8546 reported by harmen)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-25 19:18:33 +00:00
Joshua Colp
8acccb9254 Merge in dialing API and the app_page that uses it. (issue #BE-118)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52049 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-24 18:20:05 +00:00
Russell Bryant
9440d428a0 Merged revisions 51843 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r51843 | russell | 2007-01-23 18:57:28 -0600 (Tue, 23 Jan 2007) | 6 lines

Fix an issue related to synchronization of recordings when using Monitor().
The bug is a miscalculation of the amount to seek the stream for writing to
disk when the number of samples coming in and out of a channel do not match up.
(issue #8298, #8887, report and patch by guillecabeza, patch files created and
 testing done by whoiswes)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51848 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-24 00:59:58 +00:00
Russell Bryant
2a37a53c57 Fix some bugs in process_message(). The manager session lock needs to be held
when sending some sort of response, or calling one of the manager action
callbacks.  This resolves an issue where people using the GUI would get random
crashes when they start clicking around a lot.
(issue #8711, reported and debugged by zandbelt)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51781 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-23 22:04:01 +00:00
Russell Bryant
86f8e0a527 Fix setting the default port of 8088 on 64-bit or big-endian machines.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-23 21:52:52 +00:00
Russell Bryant
3d5e9fa43c When traversing the list of manager actions, the iterator needs to be
initialized to the list head *after* locking the list.  Also, lock the actions
list in one place it is being accessed where it was not being done.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-23 21:33:15 +00:00
Steve Murphy
ec2c64c81b via 8748 (callerid.c loses name when returning PRIVATE_NUMBER flag), the user suggested this mod, saying it would allow 'WITHHELD' to appear in the name field, which would be useful
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51683 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-23 18:58:27 +00:00
Russell Bryant
33235b40d6 Merge the changes from the /team/group/vldtmf_fixup branch.
The main bug being addressed here is a problem introduced when two SIP
channels using SIP INFO dtmf have their media directly bridged.  So, when a
DTMF END frame comes into Asterisk from an incoming INFO message, Asterisk
would try to emulate a digit of some length by first sending a DTMF BEGIN
frame and sending a DTMF END later timed off of incoming audio.  However,
since there was no audio coming in, the DTMF_END was never generated.  This
caused DTMF based features to no longer work.

To fix this, the core now knows when a channel doesn't care about DTMF BEGIN
frames (such as a SIP channel sending INFO dtmf).  If this is the case, then
Asterisk will not emulate a digit of some length, and will instead just pass
through the single DTMF END event.

Channel drivers also now get passed the length of the digit to their digit_end
callback.  This improves SIP INFO support even further by enabling us to put
the real digit duration in the INFO message instead of a hard coded 250ms.
Also, for an incoming INFO message, the duration is read from the frame and
passed into the core instead of just getting ignored.

(issue #8597, maybe others...)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-19 17:49:38 +00:00
Russell Bryant
879a71e921 Merged revisions 51300 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r51300 | russell | 2007-01-19 10:44:09 -0600 (Fri, 19 Jan 2007) | 4 lines

Fix a memory leak on command line tab completion.  The container for the
matches was freed, but the individual matches themselves were not.
(issue #8851, arkadia)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51302 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-19 16:56:17 +00:00
Jason Parker
76eb4e76dc Add some more checks for option_debug before ast_log(LOG_DEBUG, ...) calls.
Issue 8832, patch(es) by tgrman


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-18 22:50:23 +00:00
Russell Bryant
eedd121fbc Ensure that the locations given to the Asterisk configure script for ncurses,
curses, termcap, or tinfo are further passed along to the editline configure
script.  This fixes some cross-compilation environments.
(issue #8637, reported by ovi, patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-18 21:54:23 +00:00
Tilghman Lesher
8d59d5173a Merged revisions 51255 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r51255 | tilghman | 2007-01-18 15:11:34 -0600 (Thu, 18 Jan 2007) | 2 lines

If a timezone is not specified, assume localtime (instead of gmtime) (Issue #7748)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51256 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-18 21:14:24 +00:00
Jason Parker
65565ac74d Fix an issue with file name completion in "module load" and "load".
Issue 8846


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-18 18:42:00 +00:00
Jason Parker
eab59cabdb Fix an issue with deprecated commands
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51241 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-18 18:28:29 +00:00
Russell Bryant
c5a3194042 Make the "hasmanager" option in users.conf actually have an effect.
(issue #8740, LnxPrgr3)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51233 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-18 17:18:43 +00:00
Joshua Colp
9461aa0027 Pass data as well for hold/unhold/vidupdate frames. (issue #8840 reported by mdu113)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51211 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-18 00:18:44 +00:00
Tilghman Lesher
0baf4aa941 Merged revisions 51194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r51194 | tilghman | 2007-01-17 14:52:21 -0600 (Wed, 17 Jan 2007) | 4 lines

When ast_strip_quoted was called with a zero-length string, it would treat a
NULL as if it were the quoting character (and would thus return the string
in memory immediately following the passed-in string).

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-17 20:56:15 +00:00
Joshua Colp
9f0ad6093e Return the correct result when directly writing out a packet so that the core doesn't then decide to handle it the regular way again. (issue #8833 reported by rcourtna)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51182 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-17 06:36:41 +00:00
Jason Parker
1825fc3ee2 Fix issue with dtmf continuation packets when the dtmf digit is 0...
Issue 8831


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51170 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-17 00:20:56 +00:00
Jason Parker
897e4b5eaa Display more useful output when streaming files.
Include the channel name to which the file is being played.

Issue 8828, patch by junky.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-16 17:36:53 +00:00
Russell Bryant
de14e3d549 It is possible for the config pointer to be NULL here, so it needs to be
checked before dereferencing it.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51057 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-16 01:15:44 +00:00
Jason Parker
9d49164921 re-add deprecated "show version" CLI command.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-15 18:23:21 +00:00
Joshua Colp
caa099357b Move event processing into do_message so that it gets executed again when events are tripped.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-15 16:36:07 +00:00
Kevin P. Fleming
dd357a71a7 use the ACX_PTHREAD macro from the Autoconf macro archive for setting up compiler pthreads support... should improve portability to platforms with unusual pthreads requirements
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-15 15:03:06 +00:00
Joshua Colp
50f951764f Add missing newlines for two memory CLI commands.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-14 21:59:05 +00:00
Tilghman Lesher
3fb08d4e9d Merged revisions 50781 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r50781 | tilghman | 2007-01-13 23:01:16 -0600 (Sat, 13 Jan 2007) | 2 lines

Bug 8814 - db should look for its header using a relative path, instead of the system path (Fixes FreeWRT)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50782 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-14 05:13:47 +00:00
Joshua Colp
e4de85c4f5 Only write a frame out to the channel if one exists. There are cases where one may not and would therefore cause the channel driver to segfault. (issue #8434 reported by slimey)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50727 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-13 06:00:24 +00:00
Joshua Colp
5fe88c5f88 We need to check for res being 0 in do_message itself, otherwise our headers will get lost.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50602 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-12 16:42:33 +00:00
Kevin P. Fleming
34b5a7c8ae Merged revisions 50561 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r50561 | kpfleming | 2007-01-12 08:34:15 -0600 (Fri, 12 Jan 2007) | 2 lines

minor documentation clarification

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50562 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-12 14:42:24 +00:00
Joshua Colp
240ca25bea Add support to see whether NAT was detected (yay symmetric RTP) and also add a check in chan_sip so that if NAT has been detected and the reinvite behind nat option has been turned off, then just do partial bridge. (issue #8655 reported by mnicholson)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-11 05:19:39 +00:00
Joshua Colp
c4d1757329 Fix parsing when using something like ldap settings. (done by anthonyl)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-10 19:46:29 +00:00
Joshua Colp
59432b9e21 Ensure data's existence before trying to access it. (issue #8774 reported by rcourtna)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50266 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-10 03:51:29 +00:00
Jason Parker
281b1a890c Re-add CLI command that should have only been deprecated in 1.4.
Thanks kshumard!  (reported in person, so no associated issue #)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-09 17:11:53 +00:00
Joshua Colp
46700b62af Disable the more intense packet2packet bridging until the bugs can be worked out.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50032 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-08 18:21:31 +00:00
Jason Parker
9e621e99a5 Save 1 whopping byte of allocated memory!
This looks like it may have been a chicken/egg scenario..

You had to call a cleanup func, because everything was allocated.
Then since you had to call a cleanup func, you were forced to allocate - ie; strdup("").


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49742 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-06 00:24:38 +00:00
Kevin P. Fleming
d2d50d7a8e ast_func_read() needs a writable copy of the function name to be passed
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 23:31:38 +00:00
Kevin P. Fleming
c56f17425c don't 'consume' the params list before we try to use it again
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49680 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:52:37 +00:00
Kevin P. Fleming
444adcb477 reduce stack consumption for AMI and AMI/HTTP requests by nearly 20K in most cases
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:16:33 +00:00
Joshua Colp
ac75028a50 Don't keep repeating the warning over and over when the end of the call is reached. (issue #8724 reported by xrg)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49675 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:14:47 +00:00