Commit Graph

241 Commits

Author SHA1 Message Date
Jason Parker 9e621e99a5 Save 1 whopping byte of allocated memory!
This looks like it may have been a chicken/egg scenario..

You had to call a cleanup func, because everything was allocated.
Then since you had to call a cleanup func, you were forced to allocate - ie; strdup("").


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49742 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-06 00:24:38 +00:00
Kevin P. Fleming d2d50d7a8e ast_func_read() needs a writable copy of the function name to be passed
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 23:31:38 +00:00
Kevin P. Fleming c56f17425c don't 'consume' the params list before we try to use it again
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49680 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:52:37 +00:00
Kevin P. Fleming 444adcb477 reduce stack consumption for AMI and AMI/HTTP requests by nearly 20K in most cases
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:16:33 +00:00
Joshua Colp ac75028a50 Don't keep repeating the warning over and over when the end of the call is reached. (issue #8724 reported by xrg)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49675 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:14:47 +00:00
Kevin P. Fleming 46d91e71c5 add support for tracking thread-local-storage objects that exist via 'threadstorage' CLI commands
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49553 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-04 22:51:01 +00:00
Joshua Colp 3d460e5a68 Only free comments and line buffer once we reach the first level. (issue #8678 reported by ssokol, fixed by anthonyl)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-04 22:28:29 +00:00
Kevin P. Fleming 24bb7d865e don't mark these allocations as 'cache' allocations when caching has been disabled
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-04 21:58:42 +00:00
Kevin P. Fleming fa5de60c6e don't do frame header caching in the core if LOW_MEMORY is defined
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-04 18:17:01 +00:00
Steve Murphy 49cce60e51 This is a slight modification to Josh's edits for #8579; both files edited were the produced by flex; so the source files need to be changed instead, and the generated files regenerated.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49237 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-02 22:30:53 +00:00
Jason Parker 0b50088366 Allow fractions of a second in the Wait() application, like it says it allows.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49189 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-02 17:33:02 +00:00
Joshua Colp 156a6cf5db If the Packet2Packet bridge is being broken because of a masquerade then attempt to read a frame in so the masquerade actually happens. Otherwise weirdness will occur. (issue #8696 reported by kjotte)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-30 05:46:57 +00:00
Jason Parker 52fb756adc Fix some deprecated commands.
Issue 8682, patch by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-28 21:26:04 +00:00
Jason Parker c38c990bc7 saw this in passing... fix a small typo
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49032 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-28 20:40:23 +00:00
Jason Parker c2f688d2fd make the uris_lock a rwlock instead of a mutex lock - needs to be forward ported to trunk
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-28 19:52:46 +00:00
Steve Murphy 4d6a91eef0 removed <err.h> as in trunk from the ael stuff. Also, threw in a minor fix to frame.c to avoid build-killing compiler warnings.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49020 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-28 19:21:56 +00:00
Joshua Colp 6d582d75c7 ast_copy_string is not available when LOW_MEMORY is used and things are being built in the utils directory, so we need to resort to the old method of strncpy. (issue #8579 reported by mottano)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49009 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 22:28:46 +00:00
Kevin P. Fleming a299485952 since these variables all have static duration, none of them need initializers (they default to zero anyway)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49006 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 22:06:56 +00:00
Kevin P. Fleming 3307ae060a move extern declaration for this option to a header file where it belongs
provide an initial value for 'languageprefix' option, instead of relying on randomness to provide a useful value


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48998 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 21:08:30 +00:00
Kevin P. Fleming b2c8abbc6d allow 'show memory' and 'show memory summary' to distinguish memory allocations that were done for caching purposes, so they don't look like memory leaks
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48987 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 18:29:13 +00:00
Joshua Colp 9cc04e026d Add an API call that initializes an RTP structure. We need this because chan_sip is cheeky and uses a temporary RTP structure for codec purposes, and the API calls that are used rely on the lock. (Pointed out on asterisk-dev by Andy Wang)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-26 04:31:58 +00:00
Russell Bryant 395db9ea8b Implement locking for the list of URI handlers to make it thread-safe.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48931 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-23 20:22:52 +00:00
Jason Parker d017436015 Minor fixes for Solaris.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48906 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-22 22:33:46 +00:00
Kevin P. Fleming 9a78e1f90e remove some now-unnecessary explicit includes of autoconfig.h
clean up per-file dependencies during 'make clean'


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-18 11:59:24 +00:00
Kevin P. Fleming 0509ca82b4 simplify dependency tracking system, using the compiler's built-in method for generating them, and only doing dependency tracking if developer mode is enabled via the configure script
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48525 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-16 21:14:34 +00:00
Kevin P. Fleming be1b5dab06 since we really, really have to have autoconfig.h included before all other headers (especially system headers), the Makefile will now force it to happen (this will fix build problems with files like ast_expr2f.c, where we can't control the inclusion order in the file itself)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48521 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-16 20:12:41 +00:00
Joshua Colp 8df2c7228f Turn payload_lock into bridge_lock and make it encompass all RTP structure contents that may relate to bridge information, including who we are bridged to.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48506 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-15 19:55:28 +00:00
Joshua Colp 0995fb8aeb Payload values on the RTP structure can change AFTER a bridge has started. This comes from the packet handling of the SIP response when indication that it was answered has been sent. Therefore we need to protect this data with a lock when we read/write. (issue #8232 reported by tgrman)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48472 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-14 17:36:12 +00:00
Joshua Colp 87a03da072 Remove direct RTCP bridging. I've come to the conclusion that we should handle this through the core and not just forward it on. Should solve a few bugs.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-14 03:33:30 +00:00
Joshua Colp c866263f50 Merge in my latest RTP changes. Break out RTP and RTCP callback functions so they no longer share a common one.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48381 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 05:36:45 +00:00
Steve Murphy 0ab411f2ed Here lies the fixes that killed bug 8423 -- OriginateSuccess and OriginateError incomplete channel name. May it rest in peace.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-07 15:33:32 +00:00
Olle Johansson f89143bd13 - Disable RTP hold timers while T.38 fax transmission happens
- Encapsulate RTP timers in the rtp structure so we have one for video and one for audio
   The video one is not used in 1.4, really. Will be used for RTP keepalives when we can send
   something that video phones support in the RTP stream.
   I now this is a big architectual change at this stage for 1.4, but decided it was needed
   to avoid future bug reports.
- Document the RTP NAT keepalive option in sip.conf.sample

Issue 7679 in the bug tracker. Please test.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-02 11:32:51 +00:00
Tilghman Lesher a78cc926d4 Double-unlock error (reported by blitzrage on IRC)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-01 19:38:59 +00:00
Joshua Colp b2b70adede Do not do a partial bridge for Google Talk since we need to handle STUN. (issue #8448 reported by phsultan)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48168 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-30 21:18:24 +00:00
Joshua Colp 191c129b4f Merged revisions 48151 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48151 | file | 2006-11-30 13:42:45 -0500 (Thu, 30 Nov 2006) | 2 lines

Print certain CDR messages out at the NOTICE level versus WARNING since they can occur when used with the CDR applications and are perfectly fine. (issue #8367 reported by dartvader)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-30 18:47:40 +00:00
Joshua Colp 558639ff6a Merged revisions 48106 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48106 | file | 2006-11-29 11:47:10 -0500 (Wed, 29 Nov 2006) | 2 lines

If the frame was duplicated before writing out then we need to free it. (issue #8429 reported by edguy3)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48107 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-29 16:50:33 +00:00
Russell Bryant a569bfd1f2 Remove a couple of unused variables (issue #8380, casper)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48046 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-27 17:17:40 +00:00
Steve Murphy e6ce5ce979 bug 8189 posted this fix for main/translate.c for PLC
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-24 17:17:07 +00:00
Joshua Colp 090c412c27 Video will never reach Packet2Packet bridging and can do more harm then good.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47944 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-22 21:47:43 +00:00
Joshua Colp 8c0f4c8711 If we have the non standard G726-32 setting turned on we want to return G726-32 to the SDP, not our AAL2 string. (issue #8330 reported by voipgate)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-21 17:32:27 +00:00
Joshua Colp 0e684abd82 Merged revisions 47859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47859 | file | 2006-11-20 14:50:21 -0500 (Mon, 20 Nov 2006) | 2 lines

Don't forget to byte swap if we are exiting the smoother feed early. (issue #8287 reported by arturs)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47860 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 19:51:36 +00:00
Joshua Colp b42279c142 Only remove/destroy the RTCP I/O item if it exists.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 15:58:50 +00:00
Joshua Colp cb11263607 We need to ensure timelimit stuff is included as well so warnings get played. (issue #8050 reported by KNK)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47707 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 21:33:41 +00:00
Kevin P. Fleming 3302cbea3e don't try to call fclose() if fopen() failed
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47701 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 20:50:06 +00:00
Kevin P. Fleming 7a5771161e Merged revisions 47686,47688-47689 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47686 | kpfleming | 2006-11-15 13:42:05 -0600 (Wed, 15 Nov 2006) | 2 lines

clear the category's variable tail pointer as well when variables are detached from it

........
r47688 | kpfleming | 2006-11-15 13:47:43 -0600 (Wed, 15 Nov 2006) | 2 lines

when appending a list of variable to a category, ensure the tail pointer points to the last variable in the list

........
r47689 | kpfleming | 2006-11-15 13:58:46 -0600 (Wed, 15 Nov 2006) | 2 lines

when re-writing the config file, don't repeat the path if it hasn't changed

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47690 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 20:01:22 +00:00
Kevin P. Fleming cb4ed839c3 Merged revisions 47682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47682 | kpfleming | 2006-11-15 12:39:47 -0600 (Wed, 15 Nov 2006) | 2 lines

ouch... don't use printf, use ast_log/ast_verbose

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47684 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 18:43:30 +00:00
Luigi Rizzo a9057b2c65 fix longest match search in find_cli.
Trunk already fixed.

1.2 not affected (well, i have no idea, the code is totally
different there).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 17:46:45 +00:00
Joshua Colp bc6cff37bc If NAT detection is turned on or already detected then say NAT is active when setting the remote RTP peer when doing early bridging. (issue #8365 reported by marcelbarbulescu)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 04:45:24 +00:00
Kevin P. Fleming 8dc804fafe more formatting cleanup, and avoid running off the end of the string
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 00:19:05 +00:00
Joshua Colp 708b84da2f Turn notice about unknown RTCP packet type into a debug message instead.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47639 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 00:14:07 +00:00