Commit Graph

146 Commits

Author SHA1 Message Date
Tilghman Lesher
f7a787c757 Issue 10043 - There is a legitimate need to be able to set variables to the empty string.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71288 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-24 17:32:21 +00:00
Russell Bryant
c5a87ff71d Don't crash if a manager connection provides a username that exists in
manager.conf but does not have a password, and also requests MD5 
authentication. (ASA-2007-012)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61786 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-24 21:33:59 +00:00
Russell Bryant
2bed78a613 It is valid to redirect channels via the manager interface that are not in the
UP state.  Instead of checking for that to prevent to ensure a dead channel
doesn't get redirected, just use the ast_check_hangup() API call.
(issue #9457, reported by Callmewind, patch by me)
(related to issue #8977)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@60134 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-04 17:38:47 +00:00
Russell Bryant
6f098541d0 Fix a misplaced block of code in the 1.2 version of the patch to fix issue #8977
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@58167 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-07 00:27:04 +00:00
Russell Bryant
7c9bc7fd0d If the channels acquired using the manager Redirect action are not up, then
don't attempt to do anything with them.  It could lead to weird behavior,
including crashes.  (issue #8977)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@58164 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-07 00:20:13 +00:00
Tilghman Lesher
4fa9370412 Issue 8987 - Status could return two responses (mnicholson)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-06 06:58:28 +00:00
Russell Bryant
f9db7779f0 Fix a bunch of places where pthread_attr_init() was called, but
pthread_attr_destroy() was not.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53045 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 21:25:11 +00:00
Russell Bryant
e27d844918 now that CDR is a loadable module, don't depend on it elsewhere (issue #6460)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@9581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-11 18:15:00 +00:00
Russell Bryant
18429f2a69 backport fix for unnecessary unlock (issue #6171)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7870 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-09 04:52:16 +00:00
Kevin P. Fleming
a563eab49a remove extraneous svn:executable properties
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-29 18:24:39 +00:00
Russell Bryant
685e88645f don't crash on setvar (issue #5760)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-15 18:35:30 +00:00
Josh Roberson
15705f94a7 Issue #5737
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7097 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-15 01:33:31 +00:00
Russell Bryant
d8dfa4434d finish merging doxygen updates from issue #5605
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7096 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-14 19:00:38 +00:00
Kevin P. Fleming
a4be983a63 issue #5571
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 03:35:40 +00:00
Kevin P. Fleming
00d3c31496 issue #5585
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7012 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 02:11:42 +00:00
Russell Bryant
3332a8acd1 clean up a lot of doxygen errors and warnings (issue #5522)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-26 23:11:36 +00:00
Russell Bryant
a736096e0b change ast_strlen_zero to also check for the string to be defined
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-26 18:54:24 +00:00
Russell Bryant
6324072247 more doxygenification (issue #5513)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-26 13:03:17 +00:00
Russell Bryant
3453e3efa5 Doxygen documentation update from oej (issue #5505)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-24 20:12:06 +00:00
Mark Spencer
0aec4ef713 Fix carefulwrite and its usage within manager (bug #5355, maybe)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6792 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-14 20:37:40 +00:00
Kevin P. Fleming
7c936b8826 don't try to send events to dead sessions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6776 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-13 23:29:24 +00:00
Russell Bryant
dee30a519e allow manager getvar action to retrieve global variables as well as
channel variables (issue #5429)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6763 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-13 20:30:39 +00:00
Kevin P. Fleming
6f869da9b0 correct variable header documentation (issue #5397)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6734 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-05 21:12:57 +00:00
Kevin P. Fleming
f7d567fe85 allow write timeout to be set on a per-user basis in AMI (issue #5352)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-04 22:25:15 +00:00
Kevin P. Fleming
e67a6e0344 allow manager actions to properly close the session again (issue #5350)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6715 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-04 22:15:28 +00:00
Kevin P. Fleming
d4bf5408a7 fix 'invalid command' logic
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-03 21:01:29 +00:00
Kevin P. Fleming
d167235344 don't build manager event output until it is needed
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6709 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-03 19:40:03 +00:00
Kevin P. Fleming
9835bc4330 add ast_build_string_va(), which accepts a varargs list directly
ensure the _entire_ manager_event() output is either queued or sent via ast_carefulwrite()


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6708 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-01 15:41:27 +00:00
Kevin P. Fleming
44a7b88d82 don't take session lock in astman_send_error() and astman_send_response(), since it is no longer needed
don't build authority string and event string for every session in manager_event(), do it only once


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6704 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-30 23:52:04 +00:00
Kevin P. Fleming
a08f3f75ff tell the user about invalid/unknown commands before sending queued events
s->challenge does not need to be protected by the lock, since only process_message() (and functions it calls) ever use it, and process_message() is a blocking operation by definition


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6703 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-30 23:44:12 +00:00
Kevin P. Fleming
9d1fc454d4 properly clear out manager header structure between actions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6701 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-30 16:27:14 +00:00
Mark Spencer
2b883819be Fix manager bug (can't destroy a session while a thread is using it!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6698 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-29 20:37:01 +00:00
Mark Spencer
ea215f5b7d Remove possibility of manager deadlocks from manager actions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6687 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-28 23:10:14 +00:00
Mark Spencer
9804f96c0f Fix manager EINTR issue (bug #5247)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6644 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-25 16:58:56 +00:00
Mark Spencer
96286be0ee Fix GetVar manager action result (bug #5275)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-25 03:49:22 +00:00
Kevin P. Fleming
5da915dcfd update MANY more files with proper copyright/license info (thanks Ian!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 20:46:50 +00:00
Kevin P. Fleming
601e4bb78a ensure that 'Events: On' enables all event types (issue #5016)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6429 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-26 23:04:20 +00:00
Mark Spencer
195a36afac Fix poll error condition causing memory corruption (bug #4915)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6303 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-07 22:59:04 +00:00
Russell Bryant
52594b6b12 fix a bunch of gcc4 warnings realted to pointer signedness
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-05 16:29:30 +00:00
Russell Bryant
c2b31d45df fix seg fault if no variable is specified (bug #4907)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6289 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-05 15:19:51 +00:00
Russell Bryant
0d695659ca don't set the event mask if the given eventmask was not valid
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6215 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-25 23:01:39 +00:00
Russell Bryant
eb7f5e8d0b make sure a reponse is sent when setting the EventMask to on (bug #4799)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6214 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-25 22:58:34 +00:00
Russell Bryant
a9c7f50a09 Allow manager originate to specifiy more than one variable to be set.
Allow manager originate and spool files to set writable dialplan functions,
including those that use the pipe symbol to seperate arguments.
Allow CDR dialplan function to be able to set the account code and userfield.
This deprecates the use of the Account header in manager originate and spool
files, as well as the SetAccount and SetCDRUserField applications.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6147 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-15 23:24:51 +00:00
Kevin P. Fleming
22b0f5d306 add a library of timeval manipulation functions, and change a large number of usses to use the new functions (bug #4504)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-15 23:00:47 +00:00
Russell Bryant
edbc500b77 more ast_copy_string conversions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6073 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-10 22:56:21 +00:00
Kevin P. Fleming
8c6c774ab6 fix channel walking problems from recent changes (bug #4494)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-09 19:27:19 +00:00
Kevin P. Fleming
2b8338cb52 more file version tags
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 22:12:19 +00:00
Kevin P. Fleming
0e6762dd5f remove experimental module version tags
add per-file revision tags and 'show version files' CLI command


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 20:27:51 +00:00
Kevin P. Fleming
1bac31d6bd more efficient (and understandable) ast_channel_walk_locked, and vastly more efficient ast_channel_by_name_locked (bug #4265)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5853 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 02:29:18 +00:00
Russell Bryant
f03896d1fc remove call to pall on unitialied fds
This function assumes that the fd is nonblocking (bug #4053)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-17 18:30:44 +00:00