Jason Parker
01480eb1fb
Finish up on transferee channel before return on failure.
...
Issue 10821, patch by Ivan
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84410 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-02 18:52:55 +00:00
Russell Bryant
f741decf40
Use snprintf instead of sprintf in one place. There is no vulnerability here
...
due to various buffer sizes around the code, but I still didn't like seeing a
non length-limited copy of data coming off of the wire into a stack buffer, as
this would be a problem in the future if buffer sizes elsewhere got changed or
size limitations removed ...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-02 14:12:35 +00:00
Christian Richter
e6b3384b48
terminate USERUSER String with 0
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84345 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-02 09:48:09 +00:00
Jason Parker
cf8f092d98
Add dist-clean support for subdirs.
...
Change h323 to only remove the Makefile on a dist-clean, rather than a clean.
This fixes a bug I found with trying to run make after a make clean
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84291 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 21:52:45 +00:00
Dwayne M. Hubbard
bae4135759
moved get_base_channel() code from action_redirect to ast_channel_masquerade() for issue 7706 and BE-160
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 21:25:37 +00:00
Steve Murphy
8bf81e2bac
Anything to keep gcc 4.2 happy...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84273 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 21:18:40 +00:00
Russell Bryant
5fdc354155
Fulfull a feature request from Qwell on the "core show locks" output. It will
...
now note the lock type for each lock that a thread holds.
(mutex, rdlock, or wrlock)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84271 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 21:07:06 +00:00
Steve Murphy
b7f66e48e8
closes issue #10777 -- by returning a null for the parse tree when there's really nothing there, and making sure we don't try to do checking on a null tree.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 20:27:52 +00:00
Russell Bryant
63217678cb
Add another sanity check in the AGI read loop. We really don't care about
...
EAGAIN unless we didn't read an entire line. If there is a newline at the
end if the read buffer, break, because we got the whole thing.
(reported and patched by bmd)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84236 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 19:56:28 +00:00
Russell Bryant
2cc21a3e83
Show rwlocks in the "core show locks" output. Before, it only showed mutexes.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84206 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 19:34:12 +00:00
Russell Bryant
b34251422c
Remove another file in "make clean".
...
(closes issue #10814 , paravoid)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84170 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 15:00:56 +00:00
Russell Bryant
db1ab4db58
Simplify the CAN_EARLY_BRIDGE macro a bit.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84166 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 14:24:49 +00:00
Joshua Colp
40b0f97a6c
Remove chan_usbradio config file from tree, it is not present in here.
...
(closes issue #10839 )
Reported by: casper
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84163 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 14:10:47 +00:00
Joshua Colp
27a869e423
Fix randomness. save_pos was being set to 0 initially instead of -1, causing it to jump to position 0 when moh started.
...
(closes issue #10859 )
Reported by: jamesgolovich
Patches:
asterisk-mohpos2.diff.txt uploaded by jamesgolovich (license 176)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84160 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 13:57:42 +00:00
Joshua Colp
e7f6101587
Only attempt early bridging if the options given to Dial() permit it.
...
(closes issue #10861 )
Reported by: peekyb
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 13:49:36 +00:00
Russell Bryant
2ef9410363
Fix the AST_MODULE_INFO macro for C++ modules. The load and reload parameters
...
were in the wrong place.
(closes issue #10846 , alebm)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-30 20:02:16 +00:00
Steve Murphy
fce1741a01
This is a regression update that matches what I did in 84134 for AEL regressions.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84135 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-29 23:00:37 +00:00
Steve Murphy
0ffda2d201
This issue sort of closes 10786; All config files support #include with globbing (you know, *,[chars],?,{list,list},etc), so I've updated the AEL system to support this also.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-29 21:47:53 +00:00
Tilghman Lesher
b1f26cfcdf
Correct pronunciations of numbers for .nl (Closes issue #10837 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84078 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-28 14:13:47 +00:00
Tilghman Lesher
253a34b756
Avoid a deadlock with ALL of the locks in the masquerade function, not just the
...
pairs of channels. (Closes issue #10406 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84049 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-28 05:30:22 +00:00
Dwayne M. Hubbard
7c4e477fde
if an Agent is redirected, the base channel should actually be redirected. This was causing multiple issues, especially issue 7706 and BE-160
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84018 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-27 23:12:25 +00:00
Russell Bryant
a4dcd03dcb
remove a todo item that has been completed
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83976 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-27 00:01:29 +00:00
Kevin P. Fleming
e690ff69da
avoid the weird usage of assert() in the ALSA header files that gcc 4.2 wants to complain about
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83974 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-26 23:53:03 +00:00
Russell Bryant
a8ec2e2356
I changed my mind ... I think this should be a LOG_NOTICE.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83943 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-26 21:35:23 +00:00
Russell Bryant
f77e615e9f
Add a log message that was requested by the masses in the developer tutorial
...
session at Astricon. chan_sip did not output any message when a call was
rejected because the extension was not found. This adds a verbose message
(at verbose level 3) to note when this happens.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83941 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-26 21:15:15 +00:00
Russell Bryant
d2186a55c0
Fix building chan_misdn under dev-mode. (please run the configure script
...
with --enable-dev-mode so this doesn't happen again ...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83910 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-26 20:50:09 +00:00
Tilghman Lesher
51601e2e1f
Remove unused 4k of memory on the program stack (closes issue #10827 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83879 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-26 18:35:56 +00:00
Tilghman Lesher
20e50a731b
jmls pointed out that unsetting the group and setting the group to the blank string aren't quite the same.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-25 14:13:25 +00:00
Tilghman Lesher
596cc77c99
In the source, keys are relative to the datadir, not varlib (which is the same
...
in most cases, but it's good to be accurate).
Closes issue #10811
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-24 17:22:08 +00:00
Tilghman Lesher
3c16b38d0e
Oops. Removed the unworkable workaround. This note should never have been in the release.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83653 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-24 16:37:52 +00:00
Tilghman Lesher
8c95942b7f
Making change to group splitting, as discussed on the -dev list. The main
...
effect of this will be to permit Set(GROUP([cat])=), i.e. unsetting a group.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83637 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-24 15:17:06 +00:00
Christian Richter
b0012671db
fixed round_robin group dial method, this never worked well on BRI Ports (2 channels)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83620 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-24 07:54:18 +00:00
Steve Murphy
4cd59ff447
This closes issue #10788 -- The exact same fixes are made here for the first arg in the for(arg1; arg2; arg3) {} statement, as were done for the 3rd arg. It can now be an assignment that will embedded in a Set() app, or a macro call, or an app call.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83589 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-22 19:39:16 +00:00
Steve Murphy
eef551c063
This closes issue #10788 -- the 3rd arg in the for statement is now wrapped in Set() only if there's an '=' in that string. Otherwise, if it begins with '&', then a Macro call is generated; otherwise it is made into an app call. A bit more accomodating, keeps the new guys happy, and the guys with ael-1 code should be happy, too
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83558 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-22 16:41:43 +00:00
Russell Bryant
d6b8fb4dc0
gcc 4.2 has a new set of warnings dealing with cosnt pointers. This set of
...
changes gets all of Asterisk (minus chan_alsa for now) to compile with gcc 4.2.
(closes issue #10774 , patch from qwell)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83432 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-21 14:37:20 +00:00
Joshua Colp
9ffb2fe0cf
Fix video under certain circumstances. It would have been possible for the formats on the channel to not contain the video format.
...
(closes issue #10782 )
Reported by: cwhuang
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83400 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-21 13:34:32 +00:00
Russell Bryant
578c1d0c8a
When daemonizing, don't change working directory to "/". It makes it not be
...
able to do a core dump when not running as uid=root.
(closes issue #10766 , xrg)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83348 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 21:16:48 +00:00
Russell Bryant
3a561b499a
Change safe_asterisk to explicitly ask for /bin/bash, as it uses bashisms.
...
(closes issue #10772 , reported by culrich)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83316 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 21:01:20 +00:00
Jason Parker
f1467addf7
If # is pressed after dialing an extension in DISA, stop trying to collect more digits.
...
(issue #10754 )
Reported by: atis
Patches:
app_disa.c.branch.patch uploaded by atis (license 242)
app_disa.c.trunk.patch uploaded by atis (license 242)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 17:09:14 +00:00
Joshua Colp
00000995f3
Make sure the minimum T1 timer value is obeyed in all cases.
...
(closes issue #10768 )
Reported by: flefoll
Patches:
chan_sip.c.trunk.83071.retrans-patch uploaded by flefoll (license 244)
chan_sip.c.br14.83070.retrans-patch uploaded by flefoll (license 244)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83232 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 16:25:30 +00:00
Joshua Colp
a39ed78af6
Fix a minor spelling error.
...
(closes issue #10769 )
Reported by: flefoll
Patches:
chan_sip.c.trunk.83071.inita-patch uploaded by flefoll (license 244)
chan_sip.c.br14.83070.inita-patch uploaded by flefoll (license 244)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83230 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 16:17:24 +00:00
Russell Bryant
47dc1101eb
The System() and TrySystem() applications can take a substantial amount of
...
time to execute while not servicing the channel. So, put the channel in
autoservice while the command is being executed.
(closes issue #10726 , reported by mnicholson)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 19:50:48 +00:00
Russell Bryant
f59ad2a3ed
Using curl can take a substantial amount of time, so the channel should be
...
autoserviced while waiting for it to complete.
(closes issue #10725 , reported by mnicholson)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83177 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 19:34:25 +00:00
Russell Bryant
1b242b87ff
When handling a reload of chan_iax2, don't use an ao2_callback() to POKE all
...
peers. Instead, use an iterator. By using an iterator, the peers container
is not locked while the POKE is being done. It can cause a deadlock if the
peers container is locked because poking a peer will try to lock pvt structs,
while there is a lot of other code that will hold a pvt lock when trying to
go lock the peers container.
(reported to me directly by Loic Didelot. Thank you for the debug info!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83175 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 19:13:29 +00:00
Russell Bryant
df5599d598
Fix up another potential race condition. Do the loop decrementing use count
...
on events with the eventq protected from being changed.
(reported on IRC by Ivan)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 15:10:14 +00:00
Joshua Colp
2187f79e54
Protect the CDR record from modification by pbx_exec so that the application data contains the Queue data.
...
(closes issue #10761 )
Reported by: snar
Patches:
app-queue-mixmonitor.patch uploaded by snar (license 245)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83074 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 13:47:59 +00:00
Joshua Colp
4be09d967e
(closes issue #10760 )
...
Reported by: dimas
Patches:
chan_sip.patch uploaded by dimas (license 88)
Read in subscribecontext option in general to be the default.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 13:18:22 +00:00
Christian Richter
a779f3cbf5
removed comment which violates the coding guidelines.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 09:32:42 +00:00
Christian Richter
63122bb677
added 'astdtmf' option to allow configuring the asterisk dtmf detector instead of the mISDN_dsp ones. also added the patch from irroot #10190 , so that dtmf tones detected by the asterisk detector are passed outofband to asterisk, to make any use of dtmf tones at all.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83023 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 09:31:55 +00:00
Russell Bryant
0728297127
Change the description of app_flash to note how it can be a useful tool instead
...
of just saying that it is generally a worthless feature.
(Thanks to Jim Van Meggelen for pointing it out and providing the proposed text)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 00:19:49 +00:00