Commit Graph

20 Commits

Author SHA1 Message Date
Matthew Jordan
0e488d7cc4 Fix a variety of potential buffer overflows
* chan_mobile: Fixed an overrun where the cind_state buffer (an integer array
  of size 16) would be overrun due to improper bounds checking. At worst, the
  buffer can be overrun by a total of 48 bytes (assuming 4-byte integers),
  which would still leave it within the allocated memory of struct hfp.  This
  would corrupt other elements in that struct but not necessarily cause any
  further issues.

* app_sms: The array imsg is of size 250, while the array (ud) that the data
  is copied into is of size 160.  If the size of the inbound message is 
  greater then 160, up to 90 bytes could be overrun in ud.  This would corrupt
  the user data header (array udh) adjacent to ud.

* chan_unistim: A number of invalid memmoves are corrected.  These would move
  data (which may or may not be valid) into the ends of these buffers.

* asterisk: ast_console_toggle_loglevel does not check that the console log
  level being set is less then or equal to the allowed log levels of 32.

* frame: In ast_codec_pref_prepend, if any occurrence of the specified codec
  is not found, the value used to index into the array pref->order would be
  one greater then the maximum size of the array.

* jitterbuf: If the element being placed into the jitter buffer lands in the
  last available slot in the jitter history buffer, the insertion sort attempts
  to move the last entry in the buffer into one slot past the maximum length
  of the buffer.  Note that this occurred for both the min and max jitter
  history buffers.

* tdd: If a read from fsk_serial returns a character that is greater then 32,
  an attempt to read past one of the statically defined arrays containing the
  values that character maps to would occur.

* localtime: struct ast_time and tm are not the same size - ast_time is larger,
  although it contains the elements of tm within it in the same layout.  Hence,
  when using memcpy to copy the contents of tm into ast_time, the size of tm
  should be used, as opposed to the size of ast_time.

* extconf: this treats ast_timing's minmask array as if it had a length of 48,
  when it has defined the size of the array as 24.  pbx.h defines minmask as
  having a size of 48.

(issue ASTERISK-19668)
Reported by: Matt Jordan



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@362485 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2012-04-19 02:08:44 +00:00
Kinsey Moore
4148e51555 Add missing newlines to CLI logging
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@361471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2012-04-06 18:09:19 +00:00
Kevin P. Fleming
3bfed7039f Correct some 'set-but-not-used' variable warnings.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@350789 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2012-01-14 15:23:32 +00:00
Richard Mudgett
97959f3e9a Fix deadlock potential of chan_mobile.c:mbl_ast_hangup().
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@333784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-08-29 21:05:43 +00:00
Leif Madsen
d4938a111e Introduce <support_level> tags in MODULEINFO.
This change introduces MODULEINFO into many modules in Asterisk in order to show
the community support level for those modules. This is used by changes committed
to menuselect by Russell Bryant recently (r917 in menuselect). More information about
the support level types and what they mean is available on the wiki at
https://wiki.asterisk.org/wiki/display/AST/Asterisk+Module+Support+States

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@328209 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-07-14 20:13:06 +00:00
Terry Wilson
5427820aaf Cast data as char * before using S_OR
This is required for compiling successfully under dev mode


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@320716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-05-25 00:49:10 +00:00
Matthew Nicholson
aa0351aac9 Fix the cmgr parser.
(closes issue 0018152)
Reported by: menschentier


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@292122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-10-18 17:15:24 +00:00
Tilghman Lesher
b4e18d5660 Add load priority order, such that preload becomes unnecessary in most cases
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@278132 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-20 19:35:02 +00:00
Tzafrir Cohen
c613897d1c Fix various typos reported by Lintian
(Also fix the typos in the comments)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@273641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-02 15:57:02 +00:00
Matthew Nicholson
57d9f8e42d Don't free written frames in chan_mobile's mbl_write() function.
(closes issue #16430)
Reported by: azbest
Tested by: azbest



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@273312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-07-01 12:57:18 +00:00
Matthew Nicholson
546416ff4b Fix support for multiline SMS messages in chan_mobile.
(closes issue #16278)
Reported by: Artem
Patches: 
      multiline-sms-fix2.diff uploaded by mnicholson (license 96)
Tested by: Artem


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@232580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 21:37:18 +00:00
Matthew Nicholson
6c926bca38 Do something with the service indicator so that asterisk does not attempt to use a chan_mobile endpoint that does not have service.
(closes issue #16132)
Reported by: nikkk
Patches: 
      service-indicator2.diff uploaded by mnicholson (license 96)
Tested by: nikkk


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@232544 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 21:13:02 +00:00
Tilghman Lesher
c17525391b Missed these two channel drivers on the codec_bits merge
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@228616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-06 19:38:33 +00:00
Matthew Nicholson
d0664ba6af Add an 'sms' option to mobile.conf to manually enable or disable SMS support.
(closes issue #15071)
Reported by: ughnz
Patches:
      optional-sms1.diff uploaded by mnicholson (license 96)
Tested by: ughnz, mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-03 14:01:39 +00:00
Matthew Nicholson
6568cd6aa8 This patch adds the ability to send a CUSD command to a bluetooth device.
(closes issue #15278)
Reported by: Artem
Patches:
      cusd5.patch uploaded by Artem (license 800)
Tested by: mnicholson, Artem

Review: https://reviewboard.asterisk.org/r/274/


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-29 21:46:17 +00:00
Matthew Nicholson
0cff13075f Fixed a comment for hfp_parse_clip
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209453 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-29 21:13:42 +00:00
David Brooks
d81d6d3415 Fixing typos. Replaces "recieved" with "received" and "initilize" with "initialize"
(closes issue #15571)
Reported by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@209098 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-27 16:33:50 +00:00
Matthew Nicholson
f9d62e3c32 Fix mbl_fixup() in chan_mobile to update newchan->tech_pvt instead of oldchan.
(closes issue #15299)
Reported by: nikkk


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@205700 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-09 21:32:31 +00:00
Russell Bryant
564b7aa848 Rename mobile.conf to chan_mobile.conf, make module support old name, too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204423 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 17:16:56 +00:00
Russell Bryant
c511a26749 Move Asterisk-addons modules into the main Asterisk source tree.
Someone asked yesterday, "is there a good reason why we can't just put these
modules in Asterisk?".  After a brief discussion, as long as the modules are
clearly set aside in their own directory and not enabled by default, it is
perfectly fine.

For more information about why a module goes in addons, see README-addons.txt.

chan_ooh323 does not currently compile as it is behind some trunk API updates.
However, it will not build by default, so it should be okay for now.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@204413 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-06-30 16:40:38 +00:00