Mark Michelson 0b74f727d7 Prevent a crash from occurring when a jitter buffer interpolated frame is ...

removed from a slinfactory

slinfactory used the "samples" field of an ast_frame in order to determine
the amount of data contained within the frame. In certain cases, such as
jitter buffer interpolated frames, the frame would have a non-zero value for
"samples" but have NULL "data"

This caused a problem when a memcpy call in ast_slinfactory_read would attempt
to access invalid memory. The solution in use here is to never feed frames into
the slinfactory if they have NULL "data"

(closes issue #13116)
Reported by: aragon
Patches:
      13116.diff uploaded by putnopvut (license 60)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@171621 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2009-01-27 20:06:01 +00:00

..

db1-ast

the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.

2008-11-19 21:34:47 +00:00

editline

Simple fix for Ctrl-C not immediately exiting Asterisk, but also add a

2008-12-12 22:03:10 +00:00

stdtime

the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.

2008-11-19 21:34:47 +00:00

abstract_jb.c

Merging the issue11259 branch.

2008-08-06 00:25:10 +00:00

acl.c

Merged revisions 127466 via svnmerge from

2008-07-02 19:47:15 +00:00

aescrypt.c

…

aeskey.c

…

aesopt.h

…

aestab.c

…

alaw.c

This patch solves problem 1 in 8126; it should not slow down the alaw codec, but should prevent signal degradation via multiple trips thru the codec. Fossil estimates the twice thru this codec will prevent fax from working. 4-6 times thru would result hearable, noticeable, voice degradation.

2007-08-21 16:36:34 +00:00

app.c

Revert unnecessary indications API change from rev 122314

2009-01-13 19:13:05 +00:00

ast_expr2.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

ast_expr2.fl

improve header inclusion process in a few small ways:

2008-09-27 15:00:48 +00:00

ast_expr2.h

Removing expr floating patch from 1.4; too much of a behavior change. If you want this fix, try trunk instead. bug 9508.

2007-07-03 20:17:31 +00:00

ast_expr2.y

improve header inclusion process in a few small ways:

2008-09-27 15:00:48 +00:00

ast_expr2f.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

asterisk.c

Extra NULLs in the output cause some terminal types to abort in the middle of

2009-01-21 21:02:32 +00:00

astmm.c

fix some minor issues with rev 144924

2008-09-27 15:13:30 +00:00

astobj2.c

Merged revisions 161421 via svnmerge from

2008-12-05 21:02:20 +00:00

audiohook.c

Backport of AUDIOHOOK_INHERIT for Asterisk 1.4

2008-12-19 23:34:57 +00:00

autoservice.c

Resolve issues that could cause DTMF to be processed out of order.

2008-12-12 13:44:08 +00:00

buildinfo.c

…

callerid.c

Fix a callerid parsing issue. If someone formatted callerid like the

2008-12-04 16:44:18 +00:00

cdr.c

(closes issue #12694)

2008-11-25 22:41:10 +00:00

channel.c

When a channel is answered make sure any indications currently playing stop. Usually the phone would do this but if the channel was already answered then they are being generated by Asterisk and we darn well need to stop them.

2009-01-23 20:16:39 +00:00

chanvars.c

…

cli.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

coef_in.h

…

coef_out.h

…

config.c

Fix the logic in config_text_file_save so that if an

2008-08-25 15:52:59 +00:00

cryptostub.c

…

db.c

Use the correct variable when creating the format string

2009-01-06 21:35:57 +00:00

devicestate.c

Fix some errant device states by making the devicestate API more strict in

2008-07-25 17:19:39 +00:00

dial.c

add missing break to case AST_CONTROL_SRCUPDATE

2008-03-16 21:47:10 +00:00

dns.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

dnsmgr.c

notify the user that dnsmgr refresh wont work when dnsmgr is not enabled.

2008-07-14 17:10:21 +00:00

dsp.c

It was possible for a reference to a frame which was part of a freed DSP to still be

2008-04-17 16:28:03 +00:00

ecdisa.h

…

enum.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

file.c

Fix the last couple of places where free() was improperly used directly.

2009-01-07 22:35:36 +00:00

fixedjitterbuf.c

…

fixedjitterbuf.h

Merging the issue11259 branch.

2008-08-06 00:25:10 +00:00

frame.c

Ensure that Asterisk builds with --enable-dev-mode, even on the latest gcc

2008-12-02 00:25:16 +00:00

fskmodem.c

Merged revisions 77942 via svnmerge from

2007-08-02 18:21:40 +00:00

global_datastores.c

Backport fix for 11520--for some reason I didn't do this back in February when I patched for trunk.

2008-06-11 23:47:23 +00:00

http.c

somehow missed a bunch of gcc 4.3.x warnings in this branch on the first pass

2008-11-03 13:01:18 +00:00

image.c

Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"

2006-11-02 23:00:20 +00:00

indications.c

Revert unnecessary indications API change from rev 122314

2009-01-13 19:13:05 +00:00

io.c

Fixing a typo in a comment.

2007-12-27 20:09:06 +00:00

jitterbuf.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

loader.c

remove the dlfcn compatibility stuff, because no platforms that Asterisk currently runs on it use it, and it doesn't build anyway

2008-07-18 16:15:41 +00:00

logger.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

Makefile

remove the dlfcn compatibility stuff, because no platforms that Asterisk currently runs on it use it, and it doesn't build anyway

2008-07-18 16:15:41 +00:00

manager.c

Truncate userevents at the end of a line, when the command exceeds the buffer.

2009-01-19 19:49:25 +00:00

md5.c

…

netsock.c

Merged revisions 59608 via svnmerge from

2007-04-02 15:39:07 +00:00

pbx.c

Do a string comparison instead of pointer comparison since some people specify the context they are actually in as an argument to get around some funkiness.

2009-01-22 15:13:56 +00:00

plc.c

…

poll.c

Don't freak out if the poll emulation receives NULL for the pollfds array

2008-09-03 13:24:35 +00:00

privacy.c

…

rtp.c

Don't crash if RTCP is not enabled on an RTP structure but statistics are output.

2009-01-22 20:02:35 +00:00

say.c

Adding revision 169794 to 1.4 since 1.4 is also affected by the issue

2009-01-21 22:14:52 +00:00

sched.c

It is a normal situation that a task gets put in the scheduler that should run

2008-09-10 16:39:53 +00:00

sha1.c

…

slinfactory.c

Prevent a crash from occurring when a jitter buffer interpolated frame is

2009-01-27 20:06:01 +00:00

srv.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

strcompat.c

Include stdarg.h for build issues on Solaris

2007-06-07 19:30:30 +00:00

tdd.c

Bug fixes to tdd support in zaptel.

2007-11-06 18:53:37 +00:00

term.c

since these variables all have static duration, none of them need initializers (they default to zero anyway)

2006-12-27 22:06:56 +00:00

threadstorage.c

Fix memory leak and invalid reporting issues with DEBUG_THREADLOCALS.

2008-12-16 17:06:29 +00:00

translate.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

udptl.c

Don't read into a buffer without first checking if a value is beyond the end.

2009-01-14 19:02:55 +00:00

ulaw.c

…

utils.c

Fix up timeout handling in ast_carefulwrite().

2008-12-22 17:22:56 +00:00