Terry Wilson b3ea953313 Don't overflow when paging more than 128 extensions ...

The number of available slots for calls in app_page was hardcoded to 128.
Proper bounds checking was not in place to enforce this limit, so if more than
128 extensions were passed to the Page() app, Asterisk would crash.  This patch
instead dynamically allocates memory for the ast_dial structures and removes
the (non-functional) arbitrary limit.

This issue would have special importance to anyone who is dynamically creating
the argument passed to the Page application and allowing more than 128
extensions to be added by an outside user via some external interface.

The patch posted by a_villacis was slightly modified for some coding guidelines
and other cleanups.  Thanks, a_villacis!
(closes issue #14217)
Reported by: a_villacis
Patches: 
      20080912-asterisk-app_page-fix-buffer-overflow.patch uploaded by a (license 660)
Tested by: otherwiseguy


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@168593 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2009-01-14 01:27:18 +00:00

..

app_adsiprog.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

app_alarmreceiver.c

Put in missing \ns on the end of ast_logs (issue #7936 reported by wojtekka)

2006-09-28 18:05:43 +00:00

app_amd.c

From bugtracker: "fix totalAnalysisTime to handle periods of no channel activity"

2008-02-01 00:06:37 +00:00

app_authenticate.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

app_cdr.c

Finished up a previous fix to overcome a compiler warning; the app NoCDR() has been updated to mark the channel CDR as POST_DISABLED instead of destroying the CDR; this way its flags are propagated thru a bridge and the CDR is actually dropped. The cases where only one channel in a bridge has a CDR was cleaned up.

2007-04-10 05:18:26 +00:00

app_chanisavail.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_channelredirect.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_chanspy.c

Ensure that the chanspy datastore is fully initialized.

2008-12-19 15:03:02 +00:00

app_controlplayback.c

Make sure res is a positive value before performing the check to determine whether the user stopped it or not.

2007-10-22 16:15:18 +00:00

app_dahdibarge.c

(closes issue #13480)

2008-12-19 19:48:00 +00:00

app_dahdiras.c

build against the now-typedef-free dahdi/user.h

2008-07-29 22:05:57 +00:00

app_dahdiscan.c

(closes issue #13480)

2008-12-19 19:48:00 +00:00

app_db.c

Fix a couple of typos. Initially pointed out by mrobinson.

2006-11-16 23:19:46 +00:00

app_dial.c

This merges the masqpark branch into 1.4

2008-12-19 22:30:32 +00:00

app_dictate.c

Merged revisions 68526 via svnmerge from

2007-06-08 22:23:22 +00:00

app_directed_pickup.c

Add 'down' as a valid state for directed call pickup. This creeps up when we receive session progress when dialing a device and not ringing.

2008-12-09 21:14:29 +00:00

app_directory.c

Fix some memory leaks found while looking at how realtime

2008-12-17 20:51:38 +00:00

app_disa.c

Revert unnecessary indications API change from rev 122314

2009-01-13 19:13:05 +00:00

app_dumpchan.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_echo.c

Much simpler than previous one ;-)

2007-02-10 09:08:55 +00:00

app_exec.c

Fix a minor spelling error.

2008-03-11 17:32:17 +00:00

app_externalivr.c

Detect another way for a connection to have gone away.

2008-05-14 16:46:48 +00:00

app_festival.c

Fix double declaration of 'x' on the PPC platform.

2008-12-09 20:44:32 +00:00

app_flash.c

build against the now-typedef-free dahdi/user.h

2008-07-29 22:05:57 +00:00

app_followme.c

Do not crash if we are not passed in a followme id.

2008-12-18 16:07:37 +00:00

app_forkcdr.c

(closes issue #12910)

2008-06-22 02:54:52 +00:00

app_getcpeid.c

Adds DAHDI support alongside Zaptel. DAHDI usage favored, but all Zap stuff should continue working. Release announcement to follow.

2008-06-12 19:08:20 +00:00

app_hasnewvoicemail.c

Check to make sure a value has been given to the VMCOUNT dialplan function.

2007-10-16 14:52:22 +00:00

app_ices.c

make app_ices compile on OpenBSD.

2008-08-01 11:43:46 +00:00

app_image.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_ivrdemo.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_lookupblacklist.c

Picky, picky... show deprecation warning in application help, too (reported via list)

2007-02-26 22:01:23 +00:00

app_lookupcidname.c

Picky, picky... show deprecation warning in application help, too (reported via list)

2007-02-26 22:01:23 +00:00

app_macro.c

Reverse the fix from issue #6176 and add proper handling for that issue.

2008-12-17 21:14:37 +00:00

app_meetme.c

(closes issue #13480)

2008-12-19 19:48:00 +00:00

app_milliwatt.c

- Fix a typo in the argument to Playtones

2008-05-29 19:04:52 +00:00

app_mixmonitor.c

Add a trigger mode that triggers on both read and write. The actual function that returns the combined audio frame though will wait until both sides have fed in audio, or until one side stops (such as the case when you call Wait).

2008-03-12 18:26:37 +00:00

app_morsecode.c

Allow app_morsecode to build on PPC Linux by putting the value of the digit char in an int.

2007-07-23 17:48:51 +00:00

app_mp3.c

Merged revisions 48374 via svnmerge from

2006-12-11 00:47:21 +00:00

app_nbscat.c

Merged revisions 48374 via svnmerge from

2006-12-11 00:47:21 +00:00

app_osplookup.c

Fixed OSP module did not report source/devinfo IP in correct format.

2007-10-19 01:45:53 +00:00

app_page.c

Don't overflow when paging more than 128 extensions

2009-01-14 01:27:18 +00:00

app_parkandannounce.c

(closes issue #12193)

2008-06-12 15:46:08 +00:00

app_playback.c

Ensure that help text terminates with a newline

2008-04-19 13:57:17 +00:00

app_privacy.c

Constify the result of a config retrieval function, to avoid mutilation (issue 7983).

2006-09-20 20:40:39 +00:00

app_queue.c

This merges the masqpark branch into 1.4

2008-12-19 22:30:32 +00:00

app_random.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_read.c

Revert unnecessary indications API change from rev 122314

2009-01-13 19:13:05 +00:00

app_readfile.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_realtime.c

Fix some memory leaks found while looking at how realtime

2008-12-17 20:51:38 +00:00

app_record.c

Update app_record documentation to use new CLI command, core show file formats. (issue #9151 reported by junky)

2007-02-26 19:33:48 +00:00

app_rpt.c

System call ioperm is non-portable, so check for its existence in autoconf.

2008-11-25 04:50:00 +00:00

app_sayunixtime.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_senddtmf.c

we can't unlock a channel if we cant find it. - AnthonyL bug #8741

2007-01-08 21:11:16 +00:00

app_sendtext.c

Fix a bug where SENDTEXTSTATUS isn't set properly when it isn't

2008-07-21 20:51:45 +00:00

app_setcallerid.c

For consistency sake, ensure that the values that ${CALLINGPRES} returns are valid as an

2008-04-18 06:49:16 +00:00

app_setcdruserfield.c

Expand deprecation warnings from simply warning on use to the builtin documentation.

2007-03-15 23:11:33 +00:00

app_settransfercapability.c

Expand deprecation warnings from simply warning on use to the builtin documentation.

2007-03-15 23:11:33 +00:00

app_skel.c

Revert inadvertent changes to app_skel that occurred when

2008-08-06 00:27:54 +00:00

app_sms.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

app_softhangup.c

apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process

2006-10-25 14:32:08 +00:00

app_speech_utils.c

If we receive DTMF make sure that the state of the speech structure goes back to being not ready. (issue #LUMENVOX-8)

2008-10-08 14:51:42 +00:00

app_stack.c

Don't execute a gosub if the arguments is zero-len (not just NULL)

2007-10-15 20:29:35 +00:00

app_system.c

The System() and TrySystem() applications can take a substantial amount of

2007-09-19 19:50:48 +00:00

app_talkdetect.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_test.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_transfer.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_url.c

Fix documentation to reflect how Url() really works

2006-09-21 20:22:43 +00:00

app_userevent.c

Remove an extra \r\n from manager user events. (issue #8955, mnicholson)

2007-01-31 18:18:25 +00:00

app_verbose.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_voicemail.c

Add mutexes around accesses to the IMAP library interface. This prevents

2008-12-18 21:14:47 +00:00

app_waitforring.c

merge new_loader_completion branch, including (at least):

2006-08-21 02:11:39 +00:00

app_waitforsilence.c

Check correct values in the return of ast_waitfor(); also, get rid of a

2008-10-14 20:09:06 +00:00

app_while.c

ast_waitfordigit() requires that the channel be up, for no good logical

2008-11-14 00:41:37 +00:00

app_zapateller.c

An empty string is an empty callerid ... so zap it. This closes issue #10502, which was pointed out by dswartz. Thank you, and may the swartz be with you

2007-08-24 22:59:52 +00:00

enter.h

remove extraneous svn:executable properties

2005-11-29 18:24:39 +00:00

leave.h

remove extraneous svn:executable properties

2005-11-29 18:24:39 +00:00

Makefile

remove this, it has been moved to the main Makefile

2008-07-03 22:20:16 +00:00

rpt_flow.pdf

remove extraneous svn:executable properties

2005-11-29 18:24:39 +00:00