Mark Michelson 8fded490ce Avoiding a potentially bad locking situation. ast_merge_contexts_and_delete writelocks the conlock, then ...

calls ast_hint_extension, which attempts to readlock the same lock. Recursion with read-write locks is 
dangerous, so the inner lock needs to be removed. I did this by copying the "guts" of ast_hint_extension
into ast_merge_contexts_and_delete (sans the extra lock).

(this change is inspired by the locking problems seen in issue #11080, but I have no idea if this is the
problematic area experienced by the reporters of that issue)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95577 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2007-12-31 23:43:13 +00:00

..

db1-ast

clean up (and ignore) assembler and preprocessor intermediate files if any are created during the build

2007-10-29 22:12:16 +00:00

editline

Fix build of editline on Solaris.

2007-10-30 15:45:35 +00:00

stdtime

Also set up gmtoff (this is used in the %z gnu extension to strftime)

2007-10-16 19:41:40 +00:00

abstract_jb.c

Merge team/russell/frame_caching

2006-08-29 20:50:36 +00:00

acl.c

Add some fixes for building on Solaris.

2007-08-01 17:56:59 +00:00

aescrypt.c

…

aeskey.c

…

aesopt.h

…

aestab.c

…

alaw.c

This patch solves problem 1 in 8126; it should not slow down the alaw codec, but should prevent signal degradation via multiple trips thru the codec. Fossil estimates the twice thru this codec will prevent fax from working. 4-6 times thru would result hearable, noticeable, voice degradation.

2007-08-21 16:36:34 +00:00

app.c

on second thought... revert all the other changes i've made in app options parsing leaving only one: if an empty argument is supplied for an option, set that argument pointer to point to an empty string rather than NULL, so that the application can do normal checks on it without worrying about it being NULL

2007-11-27 20:16:56 +00:00

ast_expr2.c

Removing expr floating patch from 1.4; too much of a behavior change. If you want this fix, try trunk instead. bug 9508.

2007-07-03 20:17:31 +00:00

ast_expr2.fl

gcc 4.2 has a new set of warnings dealing with cosnt pointers. This set of

2007-09-21 14:37:20 +00:00

ast_expr2.h

Removing expr floating patch from 1.4; too much of a behavior change. If you want this fix, try trunk instead. bug 9508.

2007-07-03 20:17:31 +00:00

ast_expr2.y

Removing expr floating patch from 1.4; too much of a behavior change. If you want this fix, try trunk instead. bug 9508.

2007-07-03 20:17:31 +00:00

ast_expr2f.c

This should get rid of a really, really irritating warning generated by some 64-bit platforms from libc, where free(0) is frowned upon

2007-10-23 20:20:54 +00:00

asterisk.c

Fix for restart-as-user problem reported via the -dev list

2007-12-21 15:07:42 +00:00

astmm.c

Remove a lock that doesn't make any sense. The regions lock needs to be held

2007-10-29 19:21:06 +00:00

astobj2.c

Change the behavior of ao2_link(). Previously, in inherited a reference.

2007-11-30 19:26:04 +00:00

autoservice.c

Just in case the AST_FLAG_END_DTMF_ONLY flag was already set before starting

2007-12-26 19:04:31 +00:00

buildinfo.c

…

callerid.c

Fix for building on PowerPC under Linux.

2007-06-18 21:57:10 +00:00

cdr.c

closes issue #11379; OK, this is an attempt to make both sides happy. To the cdr.conf file, I added the option 'unanswered', which defaults to 'no'. In this mode, you will see a cdr for a call, whether it was answered or not. The disposition will be NO ANSWER or ANSWERED, as appropriate. The src is as you'd expect, the destination channel will be one of the channels from the Dial() call, usually the last in the list if more than one chan was specified. With unanswered set to 'yes', you will still see this cdr entry in both cases. But in the case where the dial timed out, you will also see a cdr for each line attempted, marked NO ANSWER, with no destination channel name. The new option defaults to 'no', so you don't see the pesky extra cdr's by default, and you will not see the irritating 'not posted' messages.

2007-11-27 06:24:02 +00:00

channel.c

Don't report a syntax error when an empty string is passed to ast_get_group.

2007-12-27 21:40:02 +00:00

chanvars.c

make platforms that use mutexes in stdio.h happy

2006-08-22 23:07:11 +00:00

cli.c

Fix an issue with console verbosity when running asterisk -rx to execute a command

2007-10-13 05:48:10 +00:00

coef_in.h

…

coef_out.h

…

config.c

There are a lot of existing systems that #include non-existent files. So, to

2007-12-14 17:36:08 +00:00

cryptostub.c

…

db.c

Suppress a LOG_DEBUG message if debug is not enabled.

2007-10-15 13:16:23 +00:00

devicestate.c

Merged revisions 67593 via svnmerge from

2007-06-06 12:20:27 +00:00

dial.c

Since we are freeing list elements within a list traversal, we need to use the safe

2007-12-21 16:49:35 +00:00

dlfcn.c

…

dns.c

(closes issue #10610)

2007-09-04 13:10:56 +00:00

dnsmgr.c

gcc 4.2 has a new set of warnings dealing with cosnt pointers. This set of

2007-09-21 14:37:20 +00:00

dsp.c

We need to make sure we free the input frame if we return a different frame in ast_dsp_process.

2007-12-07 23:29:01 +00:00

ecdisa.h

…

enum.c

since these variables all have static duration, none of them need initializers (they default to zero anyway)

2006-12-27 22:06:56 +00:00

file.c

Use of "private" as a field name in a header file messes with C++ projects

2007-11-29 17:29:59 +00:00

fixedjitterbuf.c

…

fixedjitterbuf.h

…

frame.c

Put the speex packetization values back in but disable it when setting up the smoother.

2007-06-20 17:52:57 +00:00

fskmodem.c

Merged revisions 77942 via svnmerge from

2007-08-02 18:21:40 +00:00

global_datastores.c

Fix potential memory leak with the dialed interfaces list if another memory allocation fails.

2007-12-11 19:51:40 +00:00

http.c

When serving dynamic content, include a Cache-Control header to instruct the

2007-04-30 15:25:31 +00:00

image.c

Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"

2006-11-02 23:00:20 +00:00

indications.c

…

io.c

Fixing a typo in a comment.

2007-12-27 20:09:06 +00:00

jitterbuf.c

Clean up a few things in the last commit to the adaptive jitterbuffer code.

2007-01-29 16:54:27 +00:00

loader.c

Add a new module flag to indicate that a build sum is present. Modules built

2007-12-06 19:11:35 +00:00

logger.c

Make sure logger is reloaded at general reload in the cli.

2007-12-06 12:54:11 +00:00

Makefile

A big one...

2007-12-03 23:12:17 +00:00

manager.c

make this comment explain the situation in an even more explicit fashion

2007-12-27 01:01:47 +00:00

md5.c

…

netsock.c

Merged revisions 59608 via svnmerge from

2007-04-02 15:39:07 +00:00

pbx.c

Avoiding a potentially bad locking situation. ast_merge_contexts_and_delete writelocks the conlock, then

2007-12-31 23:43:13 +00:00

plc.c

…

poll.c

…

privacy.c

…

rtp.c

Add G729A as another possible payload name for G729. Some devices use this instead of G729, which is perfectly normal since the payload number itself is defined and can't be used by anything else so the name doesn't matter that much.

2007-12-10 16:36:15 +00:00

say.c

Fixing Portuguese syntax for saying dates and times. Also some coding guidelines cleanup.

2007-12-21 15:45:14 +00:00

sched.c

gcc 4.2 has a new set of warnings dealing with cosnt pointers. This set of

2007-09-21 14:37:20 +00:00

sha1.c

…

slinfactory.c

Fix slinfactory logic when dealing with frames coming in that may already be in the signed linear format.

2007-05-24 22:16:58 +00:00

srv.c

Return the proper value when the srv_callback function executes properly.

2007-11-14 01:15:12 +00:00

strcompat.c

Include stdarg.h for build issues on Solaris

2007-06-07 19:30:30 +00:00

tdd.c

Bug fixes to tdd support in zaptel.

2007-11-06 18:53:37 +00:00

term.c

since these variables all have static duration, none of them need initializers (they default to zero anyway)

2006-12-27 22:06:56 +00:00

threadstorage.c

Make the lock in the threadstorage debugging code untracked to avoid a deadlock

2007-12-05 17:31:42 +00:00

translate.c

Use the constant that I really meant to use here ...

2007-12-27 14:44:29 +00:00

udptl.c

Fix various in the udptl implementation. It could return empty modem frames, have an incorrect sequence number on packets, and display the wrong sequence number in the debug messages.

2007-12-06 16:49:42 +00:00

ulaw.c

…

utils.c

Do not try to access information about a lock when printing out a trylock attempt. It is possible for the lock that it references to no longer be valid. This would have caused segfaults or deadlocks.

2007-12-17 22:28:09 +00:00