Alexei Gradinari 1589452fdc pjsip: Fix deadlock with suspend taskprocessor on masquerade ...

If both channels which should be masqueraded
are in the same serializer:
1st channel will be locked waiting condition 'complete'
2nd channel will be locked waiting condition 'suspended'

On heavy load system a chance that both channels will be in
the same serializer 'pjsip/distibutor' is very high.

To reproduce compile res_pjsip/pjsip_distributor.c with
DISTRIBUTOR_POOL_SIZE=1

Steps to reproduce:
1. Party A calls Party B (bridged call 'AB')
2. Party B places Party A on hold
3. Party B calls Voicemail app (non-bridged call 'BV')
4. Party B attended transfers Party A to voicemail using REFER.
5. When asterisk masquerades calls 'AB' and 'BV',
   a deadlock is happened.

This patch adds a suspension indicator to the taskprocessor.
When a session suspends/unsuspends the serializer
it sets the indicator to the appropriate state.
The session checks the suspension indicator before
suspend the serializer.

ASTERISK-26145 #close

Change-Id: Iaaebee60013a58c942ba47b1b4930a63e686663b

2016-08-10 16:01:23 -04:00

..

editline

BuildSystem: Avoid 'ar cru' and use 'ar cr' instead.

2016-06-07 02:34:44 -05:00

stdtime

BuildSystem: Fix a few issues hightlighted by gcc 6.x

2016-06-28 13:56:38 -05:00

.gitignore

build-system: Allow building with static pjproject

2016-03-01 09:33:17 -07:00

abstract_jb.c

func_jitterbuffer: fix frame leaks.

2014-11-02 07:39:36 +00:00

acl.c

Fix error with mixed address family ACLs.

2014-11-20 16:36:54 +00:00

adsi.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

alaw.c

…

aoc.c

json: Audit ast_json_* usage for thread safety.

2015-12-16 17:17:30 -04:00

app.c

app: Queue hangup if channel is hung up during sub or macro execution.

2016-01-13 12:58:36 -04:00

ast_expr2.c

ast_expr2: Fix off-nominal memory leak.

2016-07-11 13:51:17 -05:00

ast_expr2.fl

…

ast_expr2.h

…

ast_expr2.y

ast_expr2: Fix off-nominal memory leak.

2016-07-11 13:51:17 -05:00

ast_expr2f.c

…

asterisk.c

Add missing checks during startup.

2016-08-03 16:39:46 -04:00

asterisk.dynamics

Fix error loading res_monitor.

2014-04-23 15:02:39 +00:00

asterisk.exports.in

pjproject_bundled: Various fixes discovered during testing of OSes

2016-05-03 06:54:29 -06:00

astfd.c

astfd: Not maximum size of a single file but maximum file descriptors.

2016-06-08 13:00:23 +02:00

astmm.c

astmm.c: Add more stats to CLI "memory show" commands.

2016-01-14 19:37:36 -06:00

astobj2_container_private.h

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_container.c

Astobj2: Ensure all calls to __adjust_lock pass a valid object.

2015-04-22 20:44:56 -04:00

astobj2_hash.c

REF_DEBUG: Prevent logging of container node objects.

2016-07-07 13:41:25 -04:00

astobj2_private.h

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_rbtree.c

REF_DEBUG: Prevent logging of container node objects.

2016-07-07 13:41:25 -04:00

astobj2.c

Astobj2: Fix initialization order of refdebug and AO2_DEBUG.

2015-05-01 15:40:45 -04:00

audiohook.c

Fix crash in audiohook translate to slin

2015-12-03 16:04:39 -06:00

autochan.c

app_chanspy: Fix occasional deadlock with ChanSpy and Local channels.

2016-03-11 23:03:08 +01:00

autoservice.c

autoservice: stop thread on graceful shutdown

2014-06-09 03:50:45 +00:00

backtrace.c

Fix memory corruption when trying to get "core show locks".

2013-08-23 18:07:40 +00:00

bridge_after.c

Fix some memory leaks.

2015-01-30 16:47:50 +00:00

bridge_basic.c

Merge "bridge_basic: don't play an attended transfer fail sound after target hangs up" into 13

2016-01-16 08:29:51 -06:00

bridge_channel.c

features: Fix channel datastore access.

2016-06-30 15:31:20 -05:00

bridge_roles.c

ARI: bridges/{bridgeID}/addChannel: add roles parameter

2013-08-05 16:59:13 +00:00

bridge.c

Merge changes from topic 'system_stress_patches' into 13

2016-04-26 04:56:36 -05:00

bucket.c

A couple minor cleanup tweaks.

2015-03-25 18:37:04 +00:00

buildinfo.c

…

callerid.c

SIP diversion: Fix REDIRECTING(reason) value inconsistencies.

2016-03-01 20:13:39 -06:00

ccss.c

ccss.c: Replace space in taskprocessor name.

2016-01-08 20:12:34 -06:00

cdr.c

stasis: Add setting subscription congestion levels.

2016-06-07 18:57:36 -05:00

cel.c

Merge "cel: Ensure only one dial status per channel exists." into 13

2016-06-10 05:09:18 -05:00

channel_internal_api.c

channel api: Create is_t38_active accessor functions.

2016-02-29 12:50:19 -06:00

channel.c

Add missing checks during startup.

2016-08-03 16:39:46 -04:00

chanvars.c

res_phoneprov: Refactor phoneprov to allow pluggable config providers

2014-10-09 17:45:23 +00:00

cli.c

Restrict CLI/AMI commands on shutdown.

2016-03-24 09:29:07 -05:00

codec_builtin.c

Update support for SILK format.

2016-07-14 15:54:21 -05:00

codec.c

codecs: Fix ABI incompatibility created by adding format_name to ast_codec

2016-06-28 13:38:28 -06:00

config_options.c

Fix Alembic upgrades.

2016-06-22 12:21:11 -05:00

config.c

config: Fix ast_config_text_file_save2 writability check for missing files

2016-04-25 18:16:58 -05:00

core_local.c

bridge.c: Crash during attended transfer when missing a local channel half

2016-03-03 13:55:24 -06:00

core_unreal.c

Bridge system: Fix memory leaks and double frees on impart failure.

2016-04-22 16:44:04 -05:00

crypt.c

Fix utils directory breakage.

2013-07-04 13:06:15 +00:00

cygload.c

…

data.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

datastore.c

This is no longer needed.

2013-06-29 00:18:57 +00:00

db.c

AMI: Make AMI actions that generate event lists consistent.

2015-01-09 17:54:49 +00:00

devicestate.c

devicestate: Cleanup engine thread during graceful shutdown.

2016-01-10 18:10:37 -05:00

dial.c

core/dial: New channel variable FORWARDERNAME

2016-05-31 18:07:40 -04:00

dns.c

Clean up files that do not end with newlines

2014-08-21 14:52:06 +00:00

dnsmgr.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

dsp.c

dsp.c: Add fax and DTMF detection unit tests.

2016-07-26 17:51:06 -05:00

ecdisa.h

…

endpoints.c

stasis_cache_pattern: Backport to 13

2016-01-05 12:29:31 -06:00

enum.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

event.c

Clang: change previous tautological-compare fixes.

2015-04-23 18:26:55 +02:00

features_config.c

bridge_basic: don't cache xferfailsound during an attended transfer

2016-01-15 17:45:51 -06:00

features.c

features.c: Remove unneeded adsi.h include.

2016-07-14 22:22:55 -04:00

file.c

file: Ensure nativeformats remains valid for lifetime of use.

2016-05-05 13:01:12 -03:00

fixedjitterbuf.c

…

fixedjitterbuf.h

…

format_cache.c

Update support for SILK format.

2016-07-14 15:54:21 -05:00

format_cap.c

Codecs: strip codec name while parsing allow/disallow options

2016-04-11 17:25:08 -04:00

format_compatibility.c

chan_iax2: Several media format fixes.

2014-08-07 18:51:16 +00:00

format.c

format: Register format-attribute module with cached formats.

2015-11-13 09:26:37 +01:00

frame.c

frame.c: Copy the whole subclass in ast_frdup().

2016-04-06 11:12:48 -05:00

framehook.c

clang compiler warnings: Fix format specified in framehook

2015-04-06 17:52:13 +00:00

fskmodem_float.c

…

fskmodem_int.c

…

fskmodem.c

…

global_datastores.c

Detect potential forwarding loops based on count.

2015-04-17 15:57:10 -05:00

hashtab.c

hashtab: Add NULL check when destroying iterator.

2015-11-14 08:06:35 -05:00

heap.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:05:47 +00:00

http.c

http: leverage 'bindaddr' for TLS in http.conf

2016-06-20 08:10:10 -05:00

image.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

indications.c

clang compiler warnings: Fix autological comparisons

2015-04-09 12:56:30 +00:00

io.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

jitterbuf.c

clang compiler warnings: Fix -Wabsolute-value warnings

2015-03-30 02:44:57 +00:00

json.c

ARI: Fix crash if integer values used in JSON payload 'variables' object.

2015-02-27 18:23:22 +00:00

libasteriskpj.c

build-system: Allow building with static pjproject

2016-03-01 09:33:17 -07:00

libasteriskssl.c

tcptls: Avoiding ERR_remove_state in OpenSSL.

2015-05-08 08:34:22 -05:00

libasteriskssl.exports.in

…

loader.c

loader: Retry dlopen when loading fails

2016-03-03 15:37:48 -06:00

lock.c

lock.c: Check *lt before dereferencing it

2016-04-21 11:35:37 -05:00

logger.c

logging,cdr,cel: Fix stringfield memory leak.

2016-06-01 13:57:53 -05:00

Makefile

pjproject_bundled: Various fixes discovered during testing of OSes

2016-05-03 06:54:29 -06:00

manager_bridges.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager_channels.c

manager_channels.c: Fix allocation failure crash.

2016-04-22 16:44:05 -05:00

manager_endpoints.c

res_pjsip: Add AMI events for chan_pjsip contact lifecycle changes

2015-05-26 15:32:45 -06:00

manager_mwi.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager_system.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

manager.c

stasis: Add setting subscription congestion levels.

2016-06-07 18:57:36 -05:00

max_forwards.c

Detect potential forwarding loops based on count.

2015-04-17 15:57:10 -05:00

md5.c

…

media_index.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

message.c

CHAOS: cleanup possible null vars on msg alloc failure

2016-03-02 12:00:37 -06:00

mixmonitor.c

Removed quotes from svn:keywords props on a few files.

2013-07-29 17:51:25 +00:00

named_acl.c

acl: Fix reloading of configuration if configuration file does not exist at startup.

2014-12-20 20:57:19 +00:00

named_locks.c

lock: Add named lock capability

2016-04-08 12:50:58 -06:00

netsock2.c

Audit ast_sockaddr_resolve() usage for memory leaks.

2015-03-17 21:49:30 +00:00

netsock.c

Move eid functions to utils.c, mark netsock.h deprecated

2014-06-24 02:50:15 +00:00

optional_api.c

Logger/CLI/etc.: Fix some aesthetic issues; reduce chatty verbose messages

2014-05-28 22:54:12 +00:00

parking.c

res_pjsip_refer: Fix bugs involving Parking/PJSIP/transfers

2014-05-22 15:52:30 +00:00

pbx_app.c

main/pbx: Move dialplan application management routines to pbx_app.c.

2016-01-05 12:09:38 -05:00

pbx_builtins.c

asterisk.h: Add ASTERISK_REGISTER_FILE macro

2016-01-05 15:10:09 -07:00

pbx_functions.c

pbx.c: Allow dangerous functions when adding a hint to dialplan.

2016-07-28 15:10:18 -05:00

pbx_hangup_handler.c

main/pbx: Move hangup handler routines to pbx_hangup_handler.c.

2016-01-05 12:10:16 -05:00

pbx_private.h

main/pbx: Move dialplan application management routines to pbx_app.c.

2016-01-05 12:09:38 -05:00

pbx_switch.c

main/pbx: Move switch routines to pbx_switch.c.

2016-01-05 12:07:43 -05:00

pbx_timing.c

main/pbx: Move timing routines to pbx_timing.c.

2016-01-05 12:06:23 -05:00

pbx_variables.c

main/pbx: Move variable routines to pbx_variables.c.

2016-01-04 17:26:40 -05:00

pbx.c

Merge "pbx.c: Fix handling of '-' in extension name and callerid" into 13

2016-08-01 10:25:19 -05:00

pickup.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

plc.c

…

poll.c

…

presencestate.c

AMI: Escape string values.

2015-06-03 14:03:18 -05:00

privacy.c

…

rtp_engine.c

Remove SILK payload mappings from Asterisk core.

2016-08-02 10:50:34 -05:00

say.c

BuildSystem: Fix a few issues hightlighted by gcc 6.x

2016-06-28 13:56:38 -05:00

sched.c

sched.c: Ensure oldest expiring entry runs first.

2016-03-15 12:01:50 -05:00

sdp_srtp.c

res_rtp_asterisk: Use separate SRTP session for RTCP with DTLS

2016-03-29 09:29:45 -05:00

security_events.c

Clang: change previous tautological-compare fixes.

2015-04-23 18:26:55 +02:00

sem.c

Various fixes for OS X

2015-01-26 14:49:32 +00:00

sha1.c

…

sip_api.c

…

slinfactory.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

smoother.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

sorcery.c

Fix Alembic upgrades.

2016-06-22 12:21:11 -05:00

sounds_index.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

srv.c

…

stasis_bridges.c

core: Don't create snapshots with locks.

2015-03-10 23:09:17 +00:00

stasis_cache_pattern.c

stasis_cache_pattern: Backport to 13

2016-01-05 12:29:31 -06:00

stasis_cache.c

main/stasis: Allow subscriptions to use a threadpool for message delivery

2014-12-01 17:57:12 +00:00

stasis_channels.c

json: Audit ast_json_* usage for thread safety.

2015-12-16 17:17:30 -04:00

stasis_endpoints.c

stasis_endpoint.c: Fix contactstatus_to_json().

2016-07-13 14:37:10 -05:00

stasis_message_router.c

stasis: Add setting subscription congestion levels.

2016-06-07 18:57:36 -05:00

stasis_message.c

Manager: Short circuit AMI message processing.

2016-04-22 16:44:05 -05:00

stasis_system.c

res/res_corosync: Raise a Stasis message on node join/leave events

2016-07-06 07:22:46 -05:00

stasis.c

stasis: Add setting subscription congestion levels.

2016-06-07 18:57:36 -05:00

strcompat.c

…

stringfields.c

stringfields: Refactor to allow fields to be added to the end of structures

2016-04-04 18:07:18 -06:00

strings.c

Use doubles instead of floats for conversions when comparing strings.

2016-05-12 14:36:25 -05:00

stun.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

syslog.c

main/syslog: Allow dynamic logs, such as security events, to log to the syslog

2015-01-12 18:01:24 +00:00

taskprocessor.c

pjsip: Fix deadlock with suspend taskprocessor on masquerade

2016-08-10 16:01:23 -04:00

tcptls.c

Check for OpenSSL defines before trying to use them.

2016-02-04 16:57:38 -06:00

tdd.c

…

term.c

main: Slight refactor of main. Improve color situation.

2015-11-25 20:29:42 +01:00

test.c

test.c: Add unit test registration checks for summary and description.

2015-06-24 17:12:19 -05:00

threadpool.c

threadpool: Fix leak in ast_threadpool_serializer_group error path.

2016-07-13 12:30:58 -04:00

threadstorage.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

timing.c

Replace most uses of ast_register_atexit with ast_register_cleanup.

2015-03-26 22:19:21 +00:00

translate.c

translate: explicit format destination not properly set

2016-07-13 18:00:40 -05:00

udptl.c

udptl: Don't eat sequence numbers until OK is received

2016-05-18 14:05:47 -05:00

ulaw.c

…

uri.c

uri: Quiet warning about type qualifiers ignored on function return type

2014-08-21 14:39:27 +00:00

utils.c

Add conditional support for noreturn functions.

2016-07-19 23:35:41 -04:00

uuid.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:54:00 +00:00

xml.c

Detect and use xsltCleanupGlobals when available

2013-10-03 18:00:15 +00:00

xmldoc.c

xmldoc: Improve xmldoc wrapping of 'core show ...' output.

2015-11-06 14:45:19 +01:00