Mark Michelson 7189d75805 Remove an extraneous unlocking operation from ast_channel_free. ...

In the case that we could not remove the desired channel from the
list of channels, there was an extra call to unlock the channel list.
Since we unlock the list later on in the function anyway, this results
in the list being unlocked twice yet only being locked once.

(closes issue #15098)
Reported by: tim_ringenbach
Patches:
      remove_extra_unlock.diff uploaded by tim (license 540)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@194356 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2009-05-13 19:41:44 +00:00

..

db1-ast

Clean up problem with manager implementation of mmap where it was not testing against MAP_FAILED response.

2009-04-20 19:10:56 +00:00

editline

Remove several silly warnings in editline. One about a broken preprocessor directive, and another about strlcpy/strlcat.

2009-03-02 20:14:57 +00:00

stdtime

the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.

2008-11-19 21:34:47 +00:00

abstract_jb.c

Merging the issue11259 branch.

2008-08-06 00:25:10 +00:00

acl.c

Merged revisions 127466 via svnmerge from

2008-07-02 19:47:15 +00:00

aescrypt.c

…

aeskey.c

…

aesopt.h

…

aestab.c

…

alaw.c

This patch solves problem 1 in 8126; it should not slow down the alaw codec, but should prevent signal degradation via multiple trips thru the codec. Fossil estimates the twice thru this codec will prevent fax from working. 4-6 times thru would result hearable, noticeable, voice degradation.

2007-08-21 16:36:34 +00:00

app.c

When ending a recording with silence detection, remember to reduce the duration.

2009-03-02 23:09:01 +00:00

ast_expr2.c

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2.fl

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2.h

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2.y

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2f.c

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

asterisk.c

Add debugging mode for diagnosing file descriptor leaks.

2009-04-09 04:31:38 +00:00

asterisk.exports

Export some more required symbols.

2009-03-19 18:28:16 +00:00

astfd.c

Oops, missed this file in the last commit.

2009-04-09 04:32:40 +00:00

astmm.c

fix some minor issues with rev 144924

2008-09-27 15:13:30 +00:00

astobj2.c

Improve the build system to *properly* remove unnecessary symbols from the runtime global namespace. Along the way, change the prefixes on some internal-only API calls to use a common prefix.

2009-03-18 01:55:22 +00:00

audiohook.c

audio_audiohook_write_list() does not correctly update sample size after ast_translate.

2009-04-14 15:02:04 +00:00

autoservice.c

revert commit that included extranous changes

2009-03-18 01:51:21 +00:00

buildinfo.c

…

callerid.c

fix another symbol namespace issue (reported by Andrew on asterisk-dev)

2009-03-18 11:31:41 +00:00

cdr.c

(closes issue #12694)

2008-11-25 22:41:10 +00:00

channel.c

Remove an extraneous unlocking operation from ast_channel_free.

2009-05-13 19:41:44 +00:00

chanvars.c

make platforms that use mutexes in stdio.h happy

2006-08-22 23:07:11 +00:00

cli.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

coef_in.h

…

coef_out.h

…

config.c

Add check in configure script to check for GLOB_NOMAGIC and GLOB_BRACE in glob.h

2009-04-21 14:00:55 +00:00

cryptostub.c

…

db.c

Fix race in astdb

2009-03-17 05:50:52 +00:00

devicestate.c

fix mis-spelling of the word registered.

2009-02-15 23:37:03 +00:00

dial.c

add missing break to case AST_CONTROL_SRCUPDATE

2008-03-16 21:47:10 +00:00

dns.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

dnsmgr.c

notify the user that dnsmgr refresh wont work when dnsmgr is not enabled.

2008-07-14 17:10:21 +00:00

dsp.c

It was possible for a reference to a frame which was part of a freed DSP to still be

2008-04-17 16:28:03 +00:00

ecdisa.h

…

enum.c

Fix handling of backreferences for ENUM lookups

2009-03-06 17:19:55 +00:00

file.c

Update ast_readvideo_callback to match ast_readaudio_callback.

2009-04-15 20:04:20 +00:00

fixedjitterbuf.c

…

fixedjitterbuf.h

Merging the issue11259 branch.

2008-08-06 00:25:10 +00:00

frame.c

revert commit that included extranous changes

2009-03-18 01:51:21 +00:00

fskmodem.c

Merged revisions 77942 via svnmerge from

2007-08-02 18:21:40 +00:00

global_datastores.c

Fix feature inheritance with builtin features

2009-01-30 17:47:41 +00:00

http.c

somehow missed a bunch of gcc 4.3.x warnings in this branch on the first pass

2008-11-03 13:01:18 +00:00

image.c

Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"

2006-11-02 23:00:20 +00:00

indications.c

Revert unnecessary indications API change from rev 122314

2009-01-13 19:13:05 +00:00

io.c

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00

jitterbuf.c

Improve behavior of jitterbuffer when maxjitterbuffer is set.

2009-02-10 17:52:42 +00:00

loader.c

Remove the use of RTLD_NOLOAD, as it is not behaving like expected.

2009-03-19 17:52:52 +00:00

logger.c

Make absolute paths for logger channels work properly

2009-05-08 14:03:28 +00:00

Makefile

Add debugging mode for diagnosing file descriptor leaks.

2009-04-09 04:31:38 +00:00

manager.c

Clean up problem with manager implementation of mmap where it was not testing against MAP_FAILED response.

2009-04-20 19:10:56 +00:00

md5.c

…

netsock.c

Merged revisions 59608 via svnmerge from

2007-04-02 15:39:07 +00:00

pbx.c

Pull in a piece of murf's 88166 patch that makes it safe to call

2009-05-13 16:18:36 +00:00

plc.c

…

poll.c

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00

privacy.c

…

rtp.c

Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over.

2009-05-13 13:38:01 +00:00

say.c

Adding revision 169794 to 1.4 since 1.4 is also affected by the issue

2009-01-21 22:14:52 +00:00

sched.c

It is a normal situation that a task gets put in the scheduler that should run

2008-09-10 16:39:53 +00:00

sha1.c

…

slinfactory.c

revert commit that included extranous changes

2009-03-18 01:51:21 +00:00

srv.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

strcompat.c

Include stdarg.h for build issues on Solaris

2007-06-07 19:30:30 +00:00

tdd.c

Bug fixes to tdd support in zaptel.

2007-11-06 18:53:37 +00:00

term.c

since these variables all have static duration, none of them need initializers (they default to zero anyway)

2006-12-27 22:06:56 +00:00

threadstorage.c

Fix memory leak and invalid reporting issues with DEBUG_THREADLOCALS.

2008-12-16 17:06:29 +00:00

translate.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

udptl.c

Fix crashes when receiving certain T.38 packets. Also, increase the maximum

2009-02-12 21:19:40 +00:00

ulaw.c

…

utils.c

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00