Mark Michelson 6562e1025c Make a couple of changes with regards to a new message printed in ast_read(). ...

"ast_read() called with no recorded file descriptor" is a new message added
after a bug was discovered. Unfortunately, it seems there are a bunch of places
that potentially make such calls to ast_read() and trigger this error message
to be displayed. This commit does two things to help to make this message appear
less.

First, the message has been downgraded to a debug level message if dev mode is
not enabled. The message means a lot more to developers than it does to end users,
and so developers should take an effort to be sure to call ast_read only when
a channel is ready to be read from. However, since this doesn't actually cause an
error in operation and is not something a user can easily fix, we should not spam
their console with these messages.

Second, the message has been moved to after the check for any pending masquerades.
ast_read() being called with no recorded file descriptor should not interfere with
a masquerade taking place.

This could be seen as a simple way of resolving issue #14723. However, I still want
to try to clear out the existing ways of triggering this message, since I feel that
would be a better resolution for the issue.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@186984 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2009-04-08 15:26:46 +00:00

..

db1-ast

the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.

2008-11-19 21:34:47 +00:00

editline

Remove several silly warnings in editline. One about a broken preprocessor directive, and another about strlcpy/strlcat.

2009-03-02 20:14:57 +00:00

stdtime

the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.

2008-11-19 21:34:47 +00:00

abstract_jb.c

Merging the issue11259 branch.

2008-08-06 00:25:10 +00:00

acl.c

Merged revisions 127466 via svnmerge from

2008-07-02 19:47:15 +00:00

aescrypt.c

…

aeskey.c

…

aesopt.h

…

aestab.c

…

alaw.c

This patch solves problem 1 in 8126; it should not slow down the alaw codec, but should prevent signal degradation via multiple trips thru the codec. Fossil estimates the twice thru this codec will prevent fax from working. 4-6 times thru would result hearable, noticeable, voice degradation.

2007-08-21 16:36:34 +00:00

app.c

When ending a recording with silence detection, remember to reduce the duration.

2009-03-02 23:09:01 +00:00

ast_expr2.c

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2.fl

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2.h

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2.y

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2f.c

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

asterisk.c

Avoid destroying the CLI line when moving the cursor backward and trying to autocomplete.

2009-03-25 14:12:54 +00:00

asterisk.exports

Export some more required symbols.

2009-03-19 18:28:16 +00:00

astmm.c

fix some minor issues with rev 144924

2008-09-27 15:13:30 +00:00

astobj2.c

Improve the build system to *properly* remove unnecessary symbols from the runtime global namespace. Along the way, change the prefixes on some internal-only API calls to use a common prefix.

2009-03-18 01:55:22 +00:00

audiohook.c

Fix crash when moving audiohooks between channels.

2009-03-31 14:06:39 +00:00

autoservice.c

revert commit that included extranous changes

2009-03-18 01:51:21 +00:00

buildinfo.c

…

callerid.c

fix another symbol namespace issue (reported by Andrew on asterisk-dev)

2009-03-18 11:31:41 +00:00

cdr.c

(closes issue #12694)

2008-11-25 22:41:10 +00:00

channel.c

Make a couple of changes with regards to a new message printed in ast_read().

2009-04-08 15:26:46 +00:00

chanvars.c

make platforms that use mutexes in stdio.h happy

2006-08-22 23:07:11 +00:00

cli.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

coef_in.h

…

coef_out.h

…

config.c

Fix the logic in config_text_file_save so that if an

2008-08-25 15:52:59 +00:00

cryptostub.c

…

db.c

Fix race in astdb

2009-03-17 05:50:52 +00:00

devicestate.c

fix mis-spelling of the word registered.

2009-02-15 23:37:03 +00:00

dial.c

add missing break to case AST_CONTROL_SRCUPDATE

2008-03-16 21:47:10 +00:00

dns.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

dnsmgr.c

notify the user that dnsmgr refresh wont work when dnsmgr is not enabled.

2008-07-14 17:10:21 +00:00

dsp.c

It was possible for a reference to a frame which was part of a freed DSP to still be

2008-04-17 16:28:03 +00:00

ecdisa.h

…

enum.c

Fix handling of backreferences for ENUM lookups

2009-03-06 17:19:55 +00:00

file.c

revert commit that included extranous changes

2009-03-18 01:51:21 +00:00

fixedjitterbuf.c

…

fixedjitterbuf.h

Merging the issue11259 branch.

2008-08-06 00:25:10 +00:00

frame.c

revert commit that included extranous changes

2009-03-18 01:51:21 +00:00

fskmodem.c

Merged revisions 77942 via svnmerge from

2007-08-02 18:21:40 +00:00

global_datastores.c

Fix feature inheritance with builtin features

2009-01-30 17:47:41 +00:00

http.c

somehow missed a bunch of gcc 4.3.x warnings in this branch on the first pass

2008-11-03 13:01:18 +00:00

image.c

Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"

2006-11-02 23:00:20 +00:00

indications.c

Revert unnecessary indications API change from rev 122314

2009-01-13 19:13:05 +00:00

io.c

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00

jitterbuf.c

Improve behavior of jitterbuffer when maxjitterbuffer is set.

2009-02-10 17:52:42 +00:00

loader.c

Remove the use of RTLD_NOLOAD, as it is not behaving like expected.

2009-03-19 17:52:52 +00:00

logger.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

Makefile

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00

manager.c

Ensure that \r\n is printed after the ActionID in an OriginateResponse.

2009-04-07 20:43:49 +00:00

md5.c

…

netsock.c

Merged revisions 59608 via svnmerge from

2007-04-02 15:39:07 +00:00

pbx.c

Don't print the CR-NL combination when we aren't outputting to the manager.

2009-02-20 22:59:52 +00:00

plc.c

…

poll.c

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00

privacy.c

…

rtp.c

Fix problems when RTP packet frame size is changed

2009-03-05 18:22:16 +00:00

say.c

Adding revision 169794 to 1.4 since 1.4 is also affected by the issue

2009-01-21 22:14:52 +00:00

sched.c

It is a normal situation that a task gets put in the scheduler that should run

2008-09-10 16:39:53 +00:00

sha1.c

…

slinfactory.c

revert commit that included extranous changes

2009-03-18 01:51:21 +00:00

srv.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

strcompat.c

Include stdarg.h for build issues on Solaris

2007-06-07 19:30:30 +00:00

tdd.c

Bug fixes to tdd support in zaptel.

2007-11-06 18:53:37 +00:00

term.c

since these variables all have static duration, none of them need initializers (they default to zero anyway)

2006-12-27 22:06:56 +00:00

threadstorage.c

Fix memory leak and invalid reporting issues with DEBUG_THREADLOCALS.

2008-12-16 17:06:29 +00:00

translate.c

fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings being passed to printf()-like functions and ignored results from read()/write() and friends

2008-11-01 18:22:39 +00:00

udptl.c

Fix crashes when receiving certain T.38 packets. Also, increase the maximum

2009-02-12 21:19:40 +00:00

ulaw.c

…

utils.c

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00