David Vossel 49c20ee9c5 Fixes crash in audiohook_write_list ...

The middle_frame in the audiohook_write_list function was
being freed if a audiohook manipulator returned a failure.
This is incorrect logic.  This patch resolves this and
adds detailed descriptions of how this function should work
and why manipulator failures must be ignored.

(closes issue #17052)
Reported by: dvossel
Tested by: dvossel

(closes issue #16196)
Reported by: atis

Review: https://reviewboard.asterisk.org/r/623/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@260049 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2010-04-29 15:31:02 +00:00

..

db1-ast

Resolve a valgrind warning about a read from uninitialized memory.

2009-08-01 11:27:25 +00:00

editline

Add gar to the check for AR for those silly OSes (Solaris) that don't have ar.

2010-04-27 21:15:46 +00:00

stdtime

the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.

2008-11-19 21:34:47 +00:00

abstract_jb.c

Fix a bug caused by a partially invalid frame (from the jitterbuffer) passing through the Asterisk core.

2009-11-06 16:41:20 +00:00

acl.c

ast_outaddrfor doesn't do htons() on port, looks odd in strace.

2009-12-02 16:59:18 +00:00

aescrypt.c

…

aeskey.c

…

aesopt.h

…

aestab.c

…

alaw.c

This patch solves problem 1 in 8126; it should not slow down the alaw codec, but should prevent signal degradation via multiple trips thru the codec. Fossil estimates the twice thru this codec will prevent fax from working. 4-6 times thru would result hearable, noticeable, voice degradation.

2007-08-21 16:36:34 +00:00

app.c

Allow application options with arguments to contain parentheses, through a variety of escaping techniques.

2010-04-15 21:23:24 +00:00

ast_expr2.c

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2.fl

Remove reference of documentation in source directory.

2010-02-08 20:39:50 +00:00

ast_expr2.h

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2.y

These changes allow AEL to better check ${} constructs within $[...], that are concatenated with text.

2009-03-03 18:11:34 +00:00

ast_expr2f.c

Remove reference of documentation in source directory.

2010-02-08 20:39:50 +00:00

asterisk.c

Launch Asterisk on Mac OS X with launchd.

2010-03-15 01:33:50 +00:00

asterisk.exports

Reverting index() fix, applying a different methodology, based upon developer discussions.

2009-08-03 16:11:29 +00:00

astfd.c

fixes crash in astfd.c

2009-11-06 15:41:41 +00:00

astmm.c

Prevent false positives when freeing a NULL pointer with MALLOC_DEBUG enabled.

2009-06-25 18:52:22 +00:00

astobj2.c

Fix DEBUG_THREADS issue with out-of-tree modules.

2010-03-25 19:39:23 +00:00

audiohook.c

Fixes crash in audiohook_write_list

2010-04-29 15:31:02 +00:00

autoservice.c

Remove some unnecessary code.

2009-10-11 17:25:06 +00:00

buildinfo.c

…

callerid.c

avoid segfault caused by user error

2009-07-16 21:24:16 +00:00

cdr.c

Fix broken CDR behavior.

2010-04-22 21:49:07 +00:00

channel.c

resolves deadlocks in chan_local

2010-04-28 21:16:03 +00:00

chanvars.c

…

cli.c

AST-2009-005

2009-08-10 19:15:57 +00:00

coef_in.h

…

coef_out.h

…

config.c

Plug a memory leak when reading configs with their comments.

2010-01-18 19:54:19 +00:00

cryptostub.c

…

db.c

Fix race in astdb

2009-03-17 05:50:52 +00:00

devicestate.c

moving ast_devstate_to_extenstate to pbx.c from devicestate.c

2009-07-08 21:35:12 +00:00

dial.c

add missing break to case AST_CONTROL_SRCUPDATE

2008-03-16 21:47:10 +00:00

dns.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

dnsmgr.c

AST-2009-005

2009-08-10 19:15:57 +00:00

dsp.c

Warning message gets displayed only once

2009-12-04 15:17:03 +00:00

ecdisa.h

…

enum.c

Fix handling of backreferences for ENUM lookups

2009-03-06 17:19:55 +00:00

file.c

Handle new SRCCHANGE control message here too

2010-03-25 15:57:29 +00:00

fixedjitterbuf.c

…

fixedjitterbuf.h

Merging the issue11259 branch.

2008-08-06 00:25:10 +00:00

frame.c

Isolate frames returned from a DSP instance or codec translator.

2009-10-21 02:59:54 +00:00

fskmodem.c

Merged revisions 77942 via svnmerge from

2007-08-02 18:21:40 +00:00

global_datastores.c

Fix feature inheritance with builtin features

2009-01-30 17:47:41 +00:00

http.c

Resolve a number of FreeBSD build issues.

2010-03-20 19:17:28 +00:00

image.c

…

indications.c

AST-2009-005

2009-08-10 19:15:57 +00:00

io.c

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00

jitterbuf.c

Improve behavior of jitterbuffer when maxjitterbuffer is set.

2009-02-10 17:52:42 +00:00

loader.c

Backport crash fix from trunk to 1.4, whereby 'core show gracefully' could crash Asterisk.

2010-02-19 19:11:45 +00:00

logger.c

Remove color code sequences from verbose messages that go to logfiles.

2010-02-24 21:02:18 +00:00

Makefile

Revert revisions 254046 and 254098.

2010-03-23 22:45:55 +00:00

manager.c

Add an option to restore past broken behavor of the Events manager action

2010-04-13 16:46:30 +00:00

md5.c

…

netsock.c

fixes an ast_netsock_list memory leak.

2009-10-08 19:45:15 +00:00

pbx.c

Use a safe list traversal while checking for duplicate vars in pbx_builtin_setvar_helper.

2010-01-27 18:06:43 +00:00

plc.c

…

poll.c

Fix cases where the internal poll() was not being used when it needed to be.

2009-03-18 02:09:13 +00:00

privacy.c

…

rtp.c

Several fixes regarding RFC2833 DTMF detection.

2010-03-25 15:59:56 +00:00

say.c

Bounds checking for input string

2010-01-04 21:45:46 +00:00

sched.c

Resolve a number of FreeBSD build issues.

2010-03-20 19:17:28 +00:00

sha1.c

…

slinfactory.c

Improve support for media paths that can generate multiple frames at once.

2009-06-16 17:05:38 +00:00

srv.c

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

2008-11-29 16:58:29 +00:00

strcompat.c

Reverting index() fix, applying a different methodology, based upon developer discussions.

2009-08-03 16:11:29 +00:00

tdd.c

Bug fixes to tdd support in zaptel.

2007-11-06 18:53:37 +00:00

term.c

…

threadstorage.c

Fix memory leak and invalid reporting issues with DEBUG_THREADLOCALS.

2008-12-16 17:06:29 +00:00

translate.c

Revert 225169, as this doesn't account for the possibility of a list of frames.

2009-10-21 16:44:49 +00:00

udptl.c

Allow for UDPTL to use only even-numbered ports if desired.

2009-07-27 17:44:06 +00:00

ulaw.c

…

utils.c

Resolve a number of FreeBSD build issues.

2010-03-20 19:17:28 +00:00