Mark Michelson d821f56b02 chan_sip: Prevent deadlock when performing BYE with Also transfer. ...

When a BYE with an Also header is successfully processed, and the sender
of the BYE is bridged with another channel, chan_sip will unlock the
owner of the dialog on which the BYE was received, call ast_async_goto()
on the bridged channel, and then re-lock the owner. The reason for this
locking behavior is that ast_async_goto() can result in a masquerade,
which requires that the involved channels are unlocked.

The problem here is that this causes a locking inversion since the
dialog's lock is held when re-locking the owner channel after the async
goto. The lock order is supposed to be channel and then sip_pvt.

The fix proposed is simple. In addition to unlocking the owner channel
before the ast_async_goto() call, also unlock the sip_pvt. Then relock
both after ast_async_goto() returns, being sure to lock the channel and
then the sip_pvt.

ASTERISK-25139 #close
Reported by Gregory Massel

Change-Id: I72c4fc295ec8573bee599e8e9213c5350a3cd224

2015-06-11 17:04:36 -05:00

..

h323

v11: More files to ignore.

2015-05-01 12:23:53 -05:00

misdn

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:24:50 +00:00

sip

chan_sip/sdp_crypto.c: allow SDP crypto tag to be up to 9 digits

2015-05-20 17:03:22 -05:00

chan_agent.c

chan_agent: Prevent multiple channels from logging in as the same agent.

2013-01-29 17:54:17 +00:00

chan_alsa.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:28:40 +00:00

chan_bridge.c

confbridge: Minor fixes playing user counts to the conference.

2013-01-22 00:35:34 +00:00

chan_console.c

chan_console: Fix reference leaks to pvt.

2014-11-08 17:28:22 +00:00

chan_dahdi.c

chan_dahdi: Add the chan_dahdi.conf force_restart_unavailable_chans option.

2015-04-30 10:24:36 -05:00

chan_gtalk.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:28:40 +00:00

chan_h323.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:24:50 +00:00

chan_iax2.c

Fix unsafe uses of ast_context pointers.

2015-06-08 11:23:38 -04:00

chan_jingle.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:28:40 +00:00

chan_local.c

chan_local: Only block media frames when a generator is on both ends of a local channel.

2014-05-21 22:05:53 +00:00

chan_mgcp.c

channels/chan_mgcp: Fix regression which causes gateways to be skipped

2014-11-09 00:36:31 +00:00

chan_misdn.c

Fix typo's (retrieve, specified, address).

2015-01-23 14:51:03 +00:00

chan_motif.c

chan_motif: Release format capabilities and config on module load error

2014-10-04 23:59:45 +00:00

chan_multicast_rtp.c

Opaquification for ast_format structs in struct ast_channel

2012-02-24 00:32:20 +00:00

chan_nbs.c

Opaquification for ast_format structs in struct ast_channel

2012-02-24 00:32:20 +00:00

chan_oss.c

main/Makefile: Fix build failure on SmartOS/Illumos/SunOS

2014-04-17 20:06:11 +00:00

chan_phone.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:28:40 +00:00

chan_phone.h

rename DialTone.h to chan_phone.h because chan_phone.c is the only file using it

2008-05-28 20:00:21 +00:00

chan_sip.c

chan_sip: Prevent deadlock when performing BYE with Also transfer.

2015-06-11 17:04:36 -05:00

chan_skinny.c

Fix unsafe uses of ast_context pointers.

2015-06-08 11:23:38 -04:00

chan_unistim.c

Fix typo's (retrieve, specified, address).

2015-01-23 14:51:03 +00:00

chan_vpb.cc

Commit framework for HANGUPCAUSE (replacement for SIP_CAUSE)

2012-05-14 19:44:27 +00:00

console_board.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

console_gui.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

console_video.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

console_video.h

implement the 'freeze' function for incoming frames;

2008-06-30 15:45:15 +00:00

iax2-parser.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:24:50 +00:00

iax2-parser.h

Asterisk media architecture conversion - no more format bitfields

2011-02-03 16:22:10 +00:00

iax2-provision.c

iax2-provision: Fix improper return on failed cache retrieval

2012-09-21 19:29:12 +00:00

iax2-provision.h

Don't reload a configuration file if nothing has changed.

2007-08-16 21:09:46 +00:00

iax2.h

Correct the number of available call numbers in IAX2.

2013-01-28 21:08:04 +00:00

Makefile

make: Remove 'res_features' from libraries to link against with cygwin/mingw32

2015-02-26 04:56:28 +00:00

misdn_config.c

Add named callgroups/pickupgroups

2012-08-07 12:46:36 +00:00

sig_analog.c

chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-03-06 19:52:04 +00:00

sig_analog.h

chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-03-06 19:52:04 +00:00

sig_pri.c

chan_dahdi/sig_pri: Fix crash on ISDN call hangup collision.

2015-05-12 17:34:45 -05:00

sig_pri.h

chan_dahdi: Add the chan_dahdi.conf force_restart_unavailable_chans option.

2015-04-30 10:24:36 -05:00

sig_ss7.c

chan_dahdi: CLI "core stop gracefully" has needless delay for PRI and SS7.

2013-09-25 20:28:29 +00:00

sig_ss7.h

Convert sig_ss7 to use a global callback table.

2012-08-08 00:15:54 +00:00

vcodecs.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:24:50 +00:00

vgrabbers.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00