Files
asterisk/res/stasis/stasis_bridge.c
Scott Griepentrog bdfdb01bcf stasis transfer: fix a race condition on stasis bridge push
After a bridge transfer completes where a local replacement
channel is used, a stasis transfer message with the details
of the transfer is sent.  This is processed by stasis which
then sets the stasis app name and replaced channel snapshot
on the replacement channel.

However, since a separate thread was already started to run
stasis on the new replacement channel, a race was on to see
if the message processing would be completed before the app
name was needed, otherwise the channel would be hung up.

This change moves the calls used to set the stasis app name
and the replace snapshot to the bridge_stasis_push function
callback from the bridge transfer logic, allowing the steps
to be completed earlier and more deterministically, and the
race elimianted.

NOTE: the swap channel parameter to bridge_stasis_push (and
thus all bridge push callbacks) must always be present when
performing a swap with another channel.

ASTERISK-24649 #close
Reported by: John Bigelow
Review: https://reviewboard.asterisk.org/r/4341/



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@430939 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2015-01-22 18:09:35 +00:00

260 lines
7.8 KiB
C

/*
* Asterisk -- An open source telephony toolkit.
*
* Copyright (C) 2014, Digium, Inc.
*
* Richard Mudgett <rmudgett@digium.com>
*
* See http://www.asterisk.org for more information about
* the Asterisk project. Please do not directly contact
* any of the maintainers of this project for assistance;
* the project provides a web site, mailing lists and IRC
* channels for your use.
*
* This program is free software, distributed under the terms of
* the GNU General Public License Version 2. See the LICENSE file
* at the top of the source tree.
*/
/*!
* \file
* \brief Stasis bridge subclass.
*
* \author Richard Mudgett <rmudgett@digium.com>
*
* See Also:
* \arg \ref AstCREDITS
*/
#include "asterisk.h"
ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
#include "asterisk/bridge.h"
#include "asterisk/bridge_after.h"
#include "asterisk/bridge_internal.h"
#include "asterisk/bridge_features.h"
#include "asterisk/stasis_app.h"
#include "asterisk/stasis_channels.h"
#include "stasis_bridge.h"
#include "control.h"
#include "command.h"
#include "app.h"
#include "asterisk/stasis_app.h"
#include "asterisk/pbx.h"
/* ------------------------------------------------------------------- */
static struct ast_bridge_methods bridge_stasis_v_table;
static void bridge_stasis_run_cb(struct ast_channel *chan, void *data)
{
RAII_VAR(char *, app_name, NULL, ast_free);
struct ast_app *app_stasis;
/* Take ownership of the swap_app memory from the datastore */
app_name = app_get_replace_channel_app(chan);
if (!app_name) {
ast_log(LOG_ERROR, "Failed to get app name for %s (%p)\n", ast_channel_name(chan), chan);
return;
}
/* find Stasis() */
app_stasis = pbx_findapp("Stasis");
if (!app_stasis) {
ast_log(LOG_WARNING, "Could not find application (Stasis)\n");
return;
}
if (ast_check_hangup_locked(chan)) {
/* channel hungup, don't run Stasis() */
return;
}
/* run Stasis() */
pbx_exec(chan, app_stasis, app_name);
}
static int add_channel_to_bridge(
struct stasis_app_control *control,
struct ast_channel *chan, void *obj)
{
struct ast_bridge *bridge = obj;
int res;
res = control_add_channel_to_bridge(control,
chan, bridge);
return res;
}
static void bridge_stasis_queue_join_action(struct ast_bridge *self,
struct ast_bridge_channel *bridge_channel)
{
ast_channel_lock(bridge_channel->chan);
command_prestart_queue_command(bridge_channel->chan, add_channel_to_bridge,
ao2_bump(self), __ao2_cleanup);
ast_channel_unlock(bridge_channel->chan);
}
/*!
* \internal
* \brief Push this channel into the Stasis bridge.
* \since 12.5.0
*
* \param self Bridge to operate upon.
* \param bridge_channel Bridge channel to push.
* \param swap Bridge channel to swap places with if not NULL.
*
* \note On entry, self is already locked.
*
* \retval 0 on success.
* \retval -1 on failure. The channel did not get pushed.
*/
static int bridge_stasis_push(struct ast_bridge *self, struct ast_bridge_channel *bridge_channel, struct ast_bridge_channel *swap)
{
struct stasis_app_control *control = stasis_app_control_find_by_channel(bridge_channel->chan);
if (swap) {
struct ast_channel_snapshot *to_be_replaced = ast_channel_snapshot_get_latest(ast_channel_uniqueid(swap->chan));
struct stasis_app_control *swap_control = stasis_app_control_find_by_channel(swap->chan);
/* set the replace channel snapshot */
ast_channel_lock(bridge_channel->chan);
app_set_replace_channel_snapshot(bridge_channel->chan, to_be_replaced);
/* copy the app name from the swap channel */
if (swap_control) {
ast_debug(3, "Copying stasis app name %s from %s to %s\n",
app_name(control_app(swap_control)),
ast_channel_name(swap->chan),
ast_channel_name(bridge_channel->chan));
app_set_replace_channel_app(bridge_channel->chan, app_name(control_app(swap_control)));
}
ast_channel_unlock(bridge_channel->chan);
ao2_cleanup(to_be_replaced);
ao2_cleanup(swap_control);
}
if (!control && !stasis_app_channel_is_internal(bridge_channel->chan)) {
/* channel not in Stasis(), get it there */
/* Attach after-bridge callback and pass ownership of swap_app to it */
if (ast_bridge_set_after_callback(bridge_channel->chan,
bridge_stasis_run_cb, NULL, NULL)) {
ast_log(LOG_ERROR, "Failed to set after bridge callback\n");
return -1;
}
bridge_stasis_queue_join_action(self, bridge_channel);
if (swap) {
/* nudge the swap channel out of the bridge */
ast_bridge_channel_leave_bridge(swap, BRIDGE_CHANNEL_STATE_END_NO_DISSOLVE, 0);
}
/* Return -1 so the push fails and the after-bridge callback gets called
* This keeps the bridging framework from putting the channel into the bridge
* until the Stasis thread gets started, and then the channel is put into the bridge.
*/
return -1;
}
/*
* If going into a holding bridge, default the role to participant, if
* it has no compatible role currently
*/
if ((self->technology->capabilities & AST_BRIDGE_CAPABILITY_HOLDING)
&& !ast_channel_has_role(bridge_channel->chan, "announcer")
&& !ast_channel_has_role(bridge_channel->chan, "holding_participant")) {
if (ast_channel_add_bridge_role(bridge_channel->chan, "holding_participant")) {
ast_log(LOG_ERROR, "Failed to set holding participant on %s\n", ast_channel_name(bridge_channel->chan));
return -1;
}
if (ast_channel_set_bridge_role_option(bridge_channel->chan, "holding_participant", "idle_mode", "none")) {
ast_log(LOG_ERROR, "Failed to set holding participant mode on %s\n", ast_channel_name(bridge_channel->chan));
return -1;
}
}
ao2_cleanup(control);
if (self->allowed_capabilities & STASIS_BRIDGE_MIXING_CAPABILITIES) {
ast_bridge_channel_update_linkedids(bridge_channel, swap);
if (ast_test_flag(&self->feature_flags, AST_BRIDGE_FLAG_SMART)) {
ast_bridge_channel_update_accountcodes(bridge_channel, swap);
}
}
return ast_bridge_base_v_table.push(self, bridge_channel, swap);
}
static int bridge_stasis_moving(struct ast_bridge_channel *bridge_channel, void *hook_pvt,
struct ast_bridge *src, struct ast_bridge *dst)
{
if (src->v_table == &bridge_stasis_v_table &&
dst->v_table != &bridge_stasis_v_table) {
RAII_VAR(struct stasis_app_control *, control, NULL, ao2_cleanup);
struct ast_channel *chan;
chan = bridge_channel->chan;
ast_assert(chan != NULL);
control = stasis_app_control_find_by_channel(chan);
if (!control) {
return -1;
}
stasis_app_channel_set_stasis_end_published(chan);
app_send_end_msg(control_app(control), chan);
}
return -1;
}
/*!
* \internal
* \brief Pull this channel from the Stasis bridge.
* \since 12.5.0
*
* \param self Bridge to operate upon.
* \param bridge_channel Bridge channel to pull.
*
* \note On entry, self is already locked.
*
* \return Nothing
*/
static void bridge_stasis_pull(struct ast_bridge *self, struct ast_bridge_channel *bridge_channel)
{
if ((self->allowed_capabilities & STASIS_BRIDGE_MIXING_CAPABILITIES)
&& ast_test_flag(&self->feature_flags, AST_BRIDGE_FLAG_SMART)) {
ast_bridge_channel_update_accountcodes(NULL, bridge_channel);
}
if (self->technology->capabilities & AST_BRIDGE_CAPABILITY_HOLDING) {
ast_channel_clear_bridge_roles(bridge_channel->chan);
}
ast_bridge_move_hook(bridge_channel->features, bridge_stasis_moving, NULL, NULL, 0);
ast_bridge_base_v_table.pull(self, bridge_channel);
}
struct ast_bridge *bridge_stasis_new(uint32_t capabilities, unsigned int flags, const char *name, const char *id)
{
void *bridge;
bridge = bridge_alloc(sizeof(struct ast_bridge), &bridge_stasis_v_table);
bridge = bridge_base_init(bridge, capabilities, flags, "Stasis", name, id);
bridge = bridge_register(bridge);
return bridge;
}
void bridge_stasis_init(void)
{
/* Setup the Stasis bridge subclass v_table. */
bridge_stasis_v_table = ast_bridge_base_v_table;
bridge_stasis_v_table.name = "stasis";
bridge_stasis_v_table.push = bridge_stasis_push;
bridge_stasis_v_table.pull = bridge_stasis_pull;
}