Mark Michelson e909bfcea9 Fix an fd leak that would occur in HTTP AMI sessions ...

The explanation behind this fix is a bit complicated, and I've already
typed it up in the code as a huge comment inside of manager.c, so I'll
give the abridged version here.

We needed a way to separate action-specific data from session-specific data.
Unfortunately, the only way to maintain API compatibility and to not have to
change every single manager action was to rename the current mansession structure
and wrap it inside a new mansession structure which actually contains action-
specific data.

(closes issue #14364)
Reported by: awk
Patches:
      14364_better.patch uploaded by putnopvut (license 60)
Tested by: putnopvut

Review: http://reviewboard.digium.com/r/148/



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@174764 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2009-02-10 21:45:14 +00:00

..

db1-ast

Merged revisions 157859 via svnmerge from

2008-11-20 00:08:12 +00:00

editline

Merged revisions 163761 via svnmerge from

2008-12-12 22:04:26 +00:00

stdtime

Merged revisions 157859 via svnmerge from

2008-11-20 00:08:12 +00:00

abstract_jb.c

Create logfile safely.

2009-01-22 21:25:46 +00:00

acl.c

Another big chunk of changes from the RSW branch. Bunch of stuff from main/

2008-08-10 19:35:50 +00:00

adsistub.c

…

aescrypt.c

…

aeskey.c

…

aesopt.h

…

aestab.c

…

alaw.c

Whitespace changes only

2008-03-04 23:04:29 +00:00

app.c

Merged revisions 172438 via svnmerge from

2009-01-29 23:15:40 +00:00

ast_expr2.c

This patch allows null args in ast_expr2 func calls, and fixes commas being converted to pipes, which was 1.4 type stuff.

2009-01-15 20:54:59 +00:00

ast_expr2.fl

Merged revisions 144924-144925 via svnmerge from

2008-09-27 15:52:56 +00:00

ast_expr2.h

This patch allows null args in ast_expr2 func calls, and fixes commas being converted to pipes, which was 1.4 type stuff.

2009-01-15 20:54:59 +00:00

ast_expr2.y

This patch allows null args in ast_expr2 func calls, and fixes commas being converted to pipes, which was 1.4 type stuff.

2009-01-15 20:54:59 +00:00

ast_expr2f.c

bring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch, and add the ones needed for all the new code here too

2008-11-02 18:52:13 +00:00

asterisk.c

Merged revisions 172438 via svnmerge from

2009-01-29 23:15:40 +00:00

astmm.c

Janitor, use ARRAY_LEN() when possible.

2008-12-05 10:31:25 +00:00

astobj2.c

Remove some error messages. This is the default handler that is valid to use.

2008-12-22 17:44:23 +00:00

audiohook.c

Always detach and destroy the whisper and barge audiohooks. Additionally also allow an audiohook to be detached if it has not been attached.

2009-02-06 15:59:17 +00:00

autoservice.c

Merged revisions 163448 via svnmerge from

2008-12-12 13:55:30 +00:00

buildinfo.c

fix a few small things found by using sparse

2008-10-30 16:49:02 +00:00

callerid.c

Merged revisions 160943 via svnmerge from

2008-12-04 16:45:06 +00:00

cdr.c

Merge ast_str_opaque branch (discontinue usage of ast_str internals)

2008-12-13 08:36:35 +00:00

channel.c

Add extensions and context on manager event when new channel is created.

2009-01-26 12:32:30 +00:00

chanvars.c

Add additional memory debugging to several core APIs, and fix several memory

2008-10-14 22:38:06 +00:00

cli.c

Remove tabs from comment

2009-01-29 23:15:20 +00:00

config.c

Merge ast_str_opaque branch (discontinue usage of ast_str internals)

2008-12-13 08:36:35 +00:00

cryptostub.c

Don't include logger.h in asterisk.h by default as it is causing problems building

2008-10-10 00:42:13 +00:00

cygload.c

…

datastore.c

make datastore creation and destruction a generic API since it is not really channel related, and add the ability to add/find/remove datastores to manager sessions

2008-08-05 16:56:11 +00:00

db.c

Merged revisions 167299 via svnmerge from

2009-01-06 21:36:44 +00:00

devicestate.c

Slightly optimize ast_devstate_str and rename global functions devstate2str and config_text_file_save to have an ast_ prefix

2008-11-04 18:47:20 +00:00

dial.c

* Fixed timeout logic in the dialing API as setting timeouts

2008-10-31 20:05:46 +00:00

dns.c

incorporates r159808 from branches/1.4:

2008-11-29 17:57:39 +00:00

dnsmgr.c

Record the previous port in the temporary address structure so that the comparison does not treat the host as having changed even if it did not. This would have been uninitialized before and would have led to a baddddd port.

2008-12-22 16:08:13 +00:00

dsp.c

Add an option, waitfordialtone, for UK analog lines which do not end a call

2008-11-25 22:45:59 +00:00

ecdisa.h

…

enum.c

Create a new config file status, CONFIG_STATUS_FILEINVALID for differentiating

2008-09-12 23:30:03 +00:00

event.c

incorporates r159808 from branches/1.4:

2008-11-29 17:57:39 +00:00

features.c

Merged revisions 173211 via svnmerge from

2009-02-04 21:17:53 +00:00

file.c

Fix a problem where file playback would cause fds to remain open forever

2009-02-04 15:30:12 +00:00

fixedjitterbuf.c

…

fixedjitterbuf.h

Merged revisions 135841,135847,135850 via svnmerge from

2008-08-06 00:30:53 +00:00

frame.c

Make sure we handle a uint32_t payload in ast_frdup()

2008-12-15 21:53:30 +00:00

fskmodem_float.c

Optionally build integer-based routines for FSK tone decoding (but default

2008-07-21 20:59:03 +00:00

fskmodem_int.c

Optionally build integer-based routines for FSK tone decoding (but default

2008-07-21 20:59:03 +00:00

fskmodem.c

(Step 2 of 2)

2008-07-21 21:00:47 +00:00

global_datastores.c

Merged revisions 172517 via svnmerge from

2009-01-30 21:29:12 +00:00

hashtab.c

Add additional memory debugging to several core APIs, and fix several memory

2008-10-14 22:38:06 +00:00

http.c

Fix qualify for TCP peer

2009-01-17 01:56:36 +00:00

image.c

Whitespace changes only

2008-03-04 23:04:29 +00:00

indications.c

Merged revisions 168561 via svnmerge from

2009-01-13 19:22:13 +00:00

io.c

…

jitterbuf.c

Merged revisions 174583 via svnmerge from

2009-02-10 18:16:31 +00:00

loader.c

Create a new config file status, CONFIG_STATUS_FILEINVALID for differentiating

2008-09-12 23:30:03 +00:00

logger.c

Added a comment to logger.c about where to put includes

2009-01-09 18:01:26 +00:00

Makefile

Merge ast_str_opaque branch (discontinue usage of ast_str internals)

2008-12-13 08:36:35 +00:00

manager.c

Fix an fd leak that would occur in HTTP AMI sessions

2009-02-10 21:45:14 +00:00

md5.c

…

netsock.c

Make OpenBSD compile again

2008-06-19 20:25:37 +00:00

pbx.c

Ensure that commas placed in the middle of extension character classes do not

2009-02-04 00:43:52 +00:00

plc.c

…

poll.c

Merged revisions 140816 via svnmerge from

2008-09-03 13:26:43 +00:00

privacy.c

…

rtp.c

Merged revisions 170239 via svnmerge from

2009-01-22 20:04:39 +00:00

say.c

Fix a crash when saying certain numbers in Chinese

2009-01-21 22:10:02 +00:00

sched.c

Add a common implementation of a scheduler context with a dedicated thread.

2009-02-06 10:55:35 +00:00

sha1.c

…

slinfactory.c

improve slinfactory API to remove implicit sample rate and require explicit sample rate selection by creator of the slinfactory

2009-02-10 19:38:26 +00:00

srv.c

bump the verbosity of a message in srv.c up by one. It used to be

2009-01-12 23:12:30 +00:00

strcompat.c

Whitespace changes only

2008-03-04 23:04:29 +00:00

strings.c

Remove duplicate code from the ast_str API. We now use __AST_STR_* to

2008-12-18 15:25:15 +00:00

taskprocessor.c

correct a CLI description

2009-01-13 16:02:13 +00:00

tcptls.c

When using a socket as a FILE *, the stdio functions will sometimes try to do

2009-02-04 18:48:06 +00:00

tdd.c

Don't include logger.h in asterisk.h by default as it is causing problems building

2008-10-10 00:42:13 +00:00

term.c

Merge changes from team/group/appdocsxml

2008-11-01 21:10:07 +00:00

threadstorage.c

Merged revisions 164736 via svnmerge from

2008-12-16 17:14:01 +00:00

timing.c

- add get_max_rate timing API call

2008-06-26 15:37:01 +00:00

translate.c

Merge ast_str_opaque branch (discontinue usage of ast_str internals)

2008-12-13 08:36:35 +00:00

udptl.c

Merged revisions 168603 via svnmerge from

2009-01-14 19:11:14 +00:00

ulaw.c

…

utils.c

Merged revisions 166297 via svnmerge from

2008-12-22 17:29:10 +00:00

xml.c

1. Make OS X compile cleanly with app_stack.

2009-02-03 00:29:49 +00:00

xmldoc.c

Don't forget to free typename

2008-12-31 22:53:55 +00:00