kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-06 14:12:15 +00:00
Code Issues Projects Releases Wiki Activity

Expand test cases for transaction creation through the API.

Browse Source
This commit is contained in:
James Cole
2018-02-18 19:55:35 +01:00
parent 77aced6734
commit 0b61c16eb0
4 changed files with 689 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/Factory/TransactionFactory.php
View File

@@ -241,8 +241,10 @@ class TransactionFactory
return $this->accountRepository->findNull($accountId);
}
if (strlen($accountName) > 0) {
// alternatively, return by name. Validator should catch invalid names.
return $this->accountRepository->findByName($accountName, [AccountType::EXPENSE]);
/** @var AccountFactory $factory */
$factory = app(AccountFactory::class);
$factory->setUser($this->user);
return $factory->findOrCreate($accountName, AccountType::EXPENSE);
}
// return cash account:
@@ -254,8 +256,11 @@ class TransactionFactory
return $this->accountRepository->findNull($accountId);
}
if (strlen($accountName) > 0) {
// alternatively, return by name. Validator should catch invalid names.
return $this->accountRepository->findByName($accountName, [AccountType::REVENUE]);
// alternatively, return by name.
/** @var AccountFactory $factory */
$factory = app(AccountFactory::class);
$factory->setUser($this->user);
return $factory->findOrCreate($accountName, AccountType::REVENUE);
}
// return cash account: