Add some TODO's, refactor some code.

This commit is contained in:
James Cole
2019-08-03 19:17:59 +02:00
parent cf121fea50
commit 0b8427f881
13 changed files with 60 additions and 29 deletions

View File

@@ -91,6 +91,9 @@ class PiggyBankFactory
public function findByName(string $name): ?PiggyBank
{
$set = $this->user->piggyBanks()->get();
// TODO no longer need to loop like this
/** @var PiggyBank $piggy */
foreach ($set as $piggy) {
if ($piggy->name === $name) {