Automated code cleanup.

This commit is contained in:
James Cole
2015-04-07 18:26:14 +02:00
parent bf354275b3
commit 0d336727e8
20 changed files with 48 additions and 41 deletions

View File

@@ -1,6 +1,5 @@
<?php namespace FireflyIII\Http\Controllers; <?php namespace FireflyIII\Http\Controllers;
use Amount;
use Auth; use Auth;
use Carbon\Carbon; use Carbon\Carbon;
use Config; use Config;
@@ -166,7 +165,6 @@ class AccountController extends Controller
$journals->setPath('accounts/show/' . $account->id); $journals->setPath('accounts/show/' . $account->id);
return view('accounts.show', compact('account', 'what', 'subTitleIcon', 'journals', 'subTitle')); return view('accounts.show', compact('account', 'what', 'subTitleIcon', 'journals', 'subTitle'));
} }
@@ -192,7 +190,7 @@ class AccountController extends Controller
]; ];
$account = $repository->store($accountData); $account = $repository->store($accountData);
Session::flash('success', 'New account "' . $account->name . '" stored!'); Session::flash('success', 'New account "' . $account->name . '" stored!');
if (intval(Input::get('create_another')) === 1) { if (intval(Input::get('create_another')) === 1) {
return Redirect::route('accounts.create', $request->input('what'))->withInput(); return Redirect::route('accounts.create', $request->input('what'))->withInput();

View File

@@ -173,7 +173,7 @@ class BillController extends Controller
*/ */
public function show(Bill $bill, BillRepositoryInterface $repository) public function show(Bill $bill, BillRepositoryInterface $repository)
{ {
$journals = $repository->getJournals($bill); $journals = $repository->getJournals($bill);
$bill->nextExpectedMatch = $repository->nextExpectedMatch($bill); $bill->nextExpectedMatch = $repository->nextExpectedMatch($bill);
$hideBill = true; $hideBill = true;

View File

@@ -3,9 +3,10 @@
use Cache; use Cache;
use ErrorException; use ErrorException;
use League\CommonMark\CommonMarkConverter; use League\CommonMark\CommonMarkConverter;
use Log;
use Response; use Response;
use Route; use Route;
use Log;
/** /**
* Class HelpController * Class HelpController
* *

View File

@@ -2,12 +2,13 @@
use Auth; use Auth;
use Carbon\Carbon; use Carbon\Carbon;
use Config;
use FireflyIII\Repositories\Account\AccountRepositoryInterface; use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use Input; use Input;
use Preferences; use Preferences;
use Session;
use Redirect; use Redirect;
use Config; use Session;
/** /**
* Class HomeController * Class HomeController
* *
@@ -31,8 +32,10 @@ class HomeController extends Controller
Session::put('end', $end); Session::put('end', $end);
} }
public function flush() { public function flush()
{
Session::clear(); Session::clear();
return Redirect::route('index'); return Redirect::route('index');
} }
@@ -42,7 +45,7 @@ class HomeController extends Controller
public function index(AccountRepositoryInterface $repository) public function index(AccountRepositoryInterface $repository)
{ {
$types = Config::get('firefly.accountTypesByIdentifier.asset'); $types = Config::get('firefly.accountTypesByIdentifier.asset');
$count = $repository->countAccounts($types); $count = $repository->countAccounts($types);
$title = 'Firefly'; $title = 'Firefly';
$subTitle = 'What\'s playing?'; $subTitle = 'What\'s playing?';

View File

@@ -2,7 +2,6 @@
use Amount; use Amount;
use Auth; use Auth;
use Carbon\Carbon;
use DB; use DB;
use FireflyIII\Models\Account; use FireflyIII\Models\Account;
use FireflyIII\Models\Bill; use FireflyIII\Models\Bill;

View File

@@ -16,8 +16,8 @@ use Input;
use Redirect; use Redirect;
use Session; use Session;
use Steam; use Steam;
use View;
use URL; use URL;
use View;
/** /**
* Class PiggyBankController * Class PiggyBankController
@@ -170,7 +170,7 @@ class PiggyBankController extends Controller
if (!isset($accounts[$account->id])) { if (!isset($accounts[$account->id])) {
$accounts[$account->id] = [ $accounts[$account->id] = [
'name' => $account->name, 'name' => $account->name,
'balance' => Steam::balance($account,null,true), 'balance' => Steam::balance($account, null, true),
'leftForPiggyBanks' => $repository->leftOnAccount($account), 'leftForPiggyBanks' => $repository->leftOnAccount($account),
'sumOfSaved' => $piggyBank->savedSoFar, 'sumOfSaved' => $piggyBank->savedSoFar,
'sumOfTargets' => floatval($piggyBank->targetamount), 'sumOfTargets' => floatval($piggyBank->targetamount),
@@ -326,6 +326,7 @@ class PiggyBankController extends Controller
if (intval(Input::get('create_another')) === 1) { if (intval(Input::get('create_another')) === 1) {
Session::put('piggy-banks.create.fromStore', true); Session::put('piggy-banks.create.fromStore', true);
return Redirect::route('piggy-banks.create')->withInput(); return Redirect::route('piggy-banks.create')->withInput();
} }
@@ -360,6 +361,7 @@ class PiggyBankController extends Controller
if (intval(Input::get('return_to_edit')) === 1) { if (intval(Input::get('return_to_edit')) === 1) {
Session::put('piggy-banks.edit.fromUpdate', true); Session::put('piggy-banks.edit.fromUpdate', true);
return Redirect::route('piggy-banks.edit', $piggyBank->id); return Redirect::route('piggy-banks.edit', $piggyBank->id);
} }

View File

@@ -11,7 +11,6 @@ use Preferences;
use Session; use Session;
use Steam; use Steam;
use View; use View;
use Crypt;
/** /**
* Class ReportController * Class ReportController
@@ -246,7 +245,7 @@ class ReportController extends Controller
/** /**
* Start getExpenseGroupedForMonth DONE * Start getExpenseGroupedForMonth DONE
*/ */
$set = $this->query->journalsByExpenseAccount($start, $end, $showSharedReports); $set = $this->query->journalsByExpenseAccount($start, $end, $showSharedReports);
$expenses = Steam::makeArray($set); $expenses = Steam::makeArray($set);
$expenses = Steam::sortArray($expenses); $expenses = Steam::sortArray($expenses);

View File

@@ -3,17 +3,13 @@
namespace FireflyIII\Http\Middleware; namespace FireflyIII\Http\Middleware;
use Carbon\Carbon; use App;
use Closure; use Closure;
use FireflyIII\Models\PiggyBank; use FireflyIII\Models\PiggyBank;
use FireflyIII\Models\PiggyBankRepetition; use FireflyIII\Models\PiggyBankRepetition;
use Illuminate\Contracts\Auth\Guard; use Illuminate\Contracts\Auth\Guard;
use Illuminate\Database\Query\JoinClause;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Support\Collection; use Illuminate\Support\Collection;
use Navigation;
use Session;
use App;
/** /**
* Class PiggyBanks * Class PiggyBanks

View File

@@ -30,7 +30,7 @@ class BudgetFormRequest extends Request
$nameRule = 'required|between:1,100|uniqueObjectForUser:budgets,name,encrypted'; $nameRule = 'required|between:1,100|uniqueObjectForUser:budgets,name,encrypted';
if (Budget::find(Input::get('id'))) { if (Budget::find(Input::get('id'))) {
$nameRule = 'required|between:1,100|uniqueObjectForUser:budgets,name,encrypted,'.intval(Input::get('id')); $nameRule = 'required|between:1,100|uniqueObjectForUser:budgets,name,encrypted,' . intval(Input::get('id'));
} }
return [ return [

View File

@@ -30,7 +30,7 @@ class CategoryFormRequest extends Request
$nameRule = 'required|between:1,100|uniqueObjectForUser:categories,name,encrypted'; $nameRule = 'required|between:1,100|uniqueObjectForUser:categories,name,encrypted';
if (Category::find(Input::get('id'))) { if (Category::find(Input::get('id'))) {
$nameRule = 'required|between:1,100|uniqueObjectForUser:categories,name,encrypted,'.intval(Input::get('id')); $nameRule = 'required|between:1,100|uniqueObjectForUser:categories,name,encrypted,' . intval(Input::get('id'));
} }
return [ return [

View File

@@ -3,9 +3,7 @@
namespace FireflyIII\Http\Requests; namespace FireflyIII\Http\Requests;
use Auth; use Auth;
use Carbon\Carbon;
use Input; use Input;
use Navigation;
/** /**
* Class PiggyBankFormRequest * Class PiggyBankFormRequest
@@ -32,7 +30,7 @@ class PiggyBankFormRequest extends Request
$nameRule = 'required|between:1,255|uniquePiggyBankForUser'; $nameRule = 'required|between:1,255|uniquePiggyBankForUser';
$targetDateRule = 'date'; $targetDateRule = 'date';
if (intval(Input::get('id'))) { if (intval(Input::get('id'))) {
$nameRule = 'required|between:1,255|uniquePiggyBankForUser:'.intval(Input::get('id')); $nameRule = 'required|between:1,255|uniquePiggyBankForUser:' . intval(Input::get('id'));
} }

View File

@@ -54,6 +54,7 @@ class Account extends Model
App::abort(500, 'Could not create new account with data: ' . json_encode($fields)); App::abort(500, 'Could not create new account with data: ' . json_encode($fields));
} }
return $account; return $account;
} }

View File

@@ -1,8 +1,9 @@
<?php namespace FireflyIII\Models; <?php namespace FireflyIII\Models;
use Crypt;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes; use Illuminate\Database\Eloquent\SoftDeletes;
use Crypt;
/** /**
* Class Category * Class Category
* *
@@ -46,6 +47,7 @@ class Category extends Model
$this->attributes['name'] = Crypt::encrypt($value); $this->attributes['name'] = Crypt::encrypt($value);
$this->attributes['encrypted'] = true; $this->attributes['encrypted'] = true;
} }
/** /**
* @param $value * @param $value
* *

View File

@@ -1,8 +1,9 @@
<?php namespace FireflyIII\Models; <?php namespace FireflyIII\Models;
use Crypt;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes; use Illuminate\Database\Eloquent\SoftDeletes;
use Crypt;
/** /**
* Class PiggyBank * Class PiggyBank
* *
@@ -92,6 +93,7 @@ class PiggyBank extends Model
$this->attributes['name'] = Crypt::encrypt($value); $this->attributes['name'] = Crypt::encrypt($value);
$this->attributes['encrypted'] = true; $this->attributes['encrypted'] = true;
} }
/** /**
* @param $value * @param $value
* *

View File

@@ -1,9 +1,10 @@
<?php namespace FireflyIII\Models; <?php namespace FireflyIII\Models;
use Carbon\Carbon; use Carbon\Carbon;
use Crypt;
use Illuminate\Database\Eloquent\Builder as EloquentBuilder; use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
use Crypt;
/** /**
* Class Reminder * Class Reminder
* *
@@ -43,6 +44,7 @@ class Reminder extends Model
if (intval($this->encrypted) == 1) { if (intval($this->encrypted) == 1) {
return json_decode(Crypt::decrypt($value)); return json_decode(Crypt::decrypt($value));
} }
return json_decode($value); return json_decode($value);
} }
@@ -90,7 +92,7 @@ class Reminder extends Model
public function setMetadataAttribute($value) public function setMetadataAttribute($value)
{ {
$this->attributes['encrypted'] = true; $this->attributes['encrypted'] = true;
$this->attributes['metadata'] = Crypt::encrypt(json_encode($value)); $this->attributes['metadata'] = Crypt::encrypt(json_encode($value));
} }
/** /**

View File

@@ -1,10 +1,11 @@
<?php namespace FireflyIII\Models; <?php namespace FireflyIII\Models;
use Carbon\Carbon;
use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes; use Illuminate\Database\Eloquent\SoftDeletes;
use Watson\Validating\ValidatingTrait; use Watson\Validating\ValidatingTrait;
use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
use Carbon\Carbon;
/** /**
* Class Transaction * Class Transaction
* *

View File

@@ -13,6 +13,7 @@ use Illuminate\Database\QueryException;
use Illuminate\Foundation\Support\Providers\EventServiceProvider as ServiceProvider; use Illuminate\Foundation\Support\Providers\EventServiceProvider as ServiceProvider;
use Log; use Log;
use Reminder; use Reminder;
/** /**
* Class EventServiceProvider * Class EventServiceProvider
* *
@@ -60,13 +61,15 @@ class EventServiceProvider extends ServiceProvider
); );
PiggyBank::deleting(function(PiggyBank $piggyBank) { PiggyBank::deleting(
$reminders = $piggyBank->reminders()->get(); function (PiggyBank $piggyBank) {
/** @var Reminder $reminder */ $reminders = $piggyBank->reminders()->get();
foreach($reminders as $reminder) { /** @var Reminder $reminder */
$reminder->delete(); foreach ($reminders as $reminder) {
$reminder->delete();
}
} }
}); );
Account::deleted( Account::deleted(

View File

@@ -89,7 +89,6 @@ interface BillRepositoryInterface
public function lastFoundMatch(Bill $bill); public function lastFoundMatch(Bill $bill);
/** /**
* @param Bill $bill * @param Bill $bill
* *

View File

@@ -2,8 +2,8 @@
namespace FireflyIII\Repositories\Journal; namespace FireflyIII\Repositories\Journal;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\Transaction; use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal;
use Illuminate\Support\Collection; use Illuminate\Support\Collection;
/** /**
@@ -48,6 +48,7 @@ interface JournalRepositoryInterface
/** /**
* Get users first transaction journal * Get users first transaction journal
*
* @return TransactionJournal * @return TransactionJournal
*/ */
public function first(); public function first();

View File

@@ -223,10 +223,10 @@ class FireflyValidator extends Validator
} }
$set = $query->get(['piggy_banks.*']); $set = $query->get(['piggy_banks.*']);
foreach($set as $entry) { foreach ($set as $entry) {
$isEncrypted = intval($entry->encrypted) == 1 ? true : false; $isEncrypted = intval($entry->encrypted) == 1 ? true : false;
$checkValue = $isEncrypted ? Crypt::decrypt($entry->name) : $entry->name; $checkValue = $isEncrypted ? Crypt::decrypt($entry->name) : $entry->name;
if($checkValue == $value) { if ($checkValue == $value) {
return false; return false;
} }
} }