From 0ef3d0cf03bd0537b7b098beac98caa6820ae78c Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 29 Apr 2016 17:26:59 +0200 Subject: [PATCH] Better message for issue #247 --- app/Support/Models/TransactionJournalSupport.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/Support/Models/TransactionJournalSupport.php b/app/Support/Models/TransactionJournalSupport.php index 253361547a..8786338f0a 100644 --- a/app/Support/Models/TransactionJournalSupport.php +++ b/app/Support/Models/TransactionJournalSupport.php @@ -12,12 +12,14 @@ namespace FireflyIII\Support\Models; use Carbon\Carbon; +use FireflyIII\Exceptions\FireflyException; use FireflyIII\Models\Account; use FireflyIII\Models\Transaction; use FireflyIII\Models\TransactionJournal; use FireflyIII\Support\CacheProperties; use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Eloquent\Model; +use Log; /** * Class TransactionJournalSupport @@ -43,7 +45,11 @@ class TransactionJournalSupport extends Model } $transaction = $journal->transactions->sortByDesc('amount')->first(); - $amount = $transaction->amount; + if (is_null($transaction)) { + Log::error('Transaction journal #' . $journal->id . ' has ZERO transactions (or they have been deleted).'); + throw new FireflyException('Transaction journal #' . $journal->id . ' has ZERO transactions. Visit this page for a solution: https://git.io/vwPFY'); + } + $amount = $transaction->amount; if ($journal->isWithdrawal()) { $amount = bcmul($amount, '-1'); }