kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-05 12:12:18 +00:00
Code Issues Projects Releases Wiki Activity

Code cleanup

Browse Source
This commit is contained in:
James Cole
2018-04-28 06:23:13 +02:00
parent 6f0e1c79ac
commit 13b78bdc20
218 changed files with 621 additions and 681 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/Validation/FireflyValidator.php
View File

@@ -55,7 +55,7 @@ class FireflyValidator extends Validator
*/
public function validate2faCode($attribute, $value): bool
{
if (!is_string($value) || null === $value || 6 != strlen($value)) {
if (!\is_string($value) || null === $value || 6 != \strlen($value)) {
return false;
}
@@ -117,7 +117,7 @@ class FireflyValidator extends Validator
*/
public function validateIban($attribute, $value): bool
{
if (!is_string($value) || null === $value || strlen($value) < 6) {
if (!\is_string($value) || null === $value || \strlen($value) < 6) {
return false;
}
// strip spaces
@@ -197,9 +197,10 @@ class FireflyValidator extends Validator
*/
public function validateMore($attribute, $value, $parameters): bool
{
$compare = (string)$parameters[0] ?? '0';
/** @var mixed $compare */
$compare = $parameters[0] ?? '0';
return bccomp((string)$value, $compare) > 0;
return bccomp((string)$value, (string)$compare) > 0;
}
/**
@@ -232,11 +233,11 @@ class FireflyValidator extends Validator
{
// get the index from a string like "rule-action-value.2".
$parts = explode('.', $attribute);
$index = $parts[count($parts) - 1];
$index = $parts[\count($parts) - 1];
// loop all rule-actions.
// check if rule-action-value matches the thing.
if (is_array($this->data['rule-action'])) {
if (\is_array($this->data['rule-action'])) {
$name = $this->data['rule-action'][$index] ?? 'invalid';
$value = $this->data['rule-action-value'][$index] ?? false;
switch ($name) {
@@ -278,7 +279,7 @@ class FireflyValidator extends Validator
{
// get the index from a string like "rule-trigger-value.2".
$parts = explode('.', $attribute);
$index = $parts[count($parts) - 1];
$index = $parts[\count($parts) - 1];
// loop all rule-triggers.
// check if rule-value matches the thing.